Feature #1035

Revise IFormFactor::getRadius and IFormFactor::getHeight

Added by pospelov almost 5 years ago. Updated about 4 years ago.

Status:ArchivedStart date:10 Apr 2015
Priority:NormalDue date:
Assignee:herck% Done:

0%

Category:-
Target version:Sprint 30

Description

For example, our FormFactorTruncatedSphere didn't have getRadius() implemented, parent IFormFactor::getRadius was used instead. This was giving an error.

Do we need these methods at all in IFormFactor?

History

#1 Updated by herck almost 5 years ago

  • Status changed from New to Backlog

#2 Updated by herck almost 5 years ago

  • Tracker changed from Bug to Feature

#3 Updated by wuttke over 4 years ago

  • Description updated (diff)

[Joachim:]
"This was giving an error."
error in the sense of wrong result or of error message?

[Gennady:]
FormFactorTruncatedSphere::getRadius was returning wrong radius, not the one which is used in class constructor.
This was giving the error in GUI, during on-the-fly generation of python script representing the sample being constructed on graphics scene.

#4 Updated by herck over 4 years ago

  • Status changed from Backlog to Sprint
  • Target version set to Sprint 30

#5 Updated by herck about 4 years ago

  • Assignee set to herck

#6 Updated by herck about 4 years ago

  • Status changed from Sprint to Resolved

Removed getHeight() (not needed)
Removed setters for length, width, height, etc.
Made getRadius() pure virtual, so it needs to be correctly implemented in each concrete form factor

#7 Updated by pospelov about 4 years ago

  • Status changed from Resolved to Archived

Also available in: Atom PDF