Refactoring #1486

Feature #964: === GUI ===

GUI: refactor SampleView

Added by pospelov over 3 years ago. Updated about 1 year ago.

Status:ResolvedStart date:01 Jul 2016
Priority:NormalDue date:
Assignee:pospelov% Done:

0%

Category:-
Target version:Sprint 39

Description

  • switch to the dock structure as in JobView
  • make SampleViewDocks (to be created) and JobViewDocks relying on same base
  • get rid of SampleViewComponents
  • introduce status bar for dock menu as in JobActivityStatusBar
  • split responsibilities: separate actions from toolbar
  • restore broken drag-and-drop in the ItemTreeView (top right corner)
  • cleanup in DesignerHelper (e.g. move common calls to CommonWidgets)
  • make InfoWidget relying on common InfoPanel/InfoPanelToolbar
  • refactor PySampleWidget to rely on common UpdateTimer
  • switch to svg icons

History

#1 Updated by pospelov over 3 years ago

Adding here Joachim's comments

By default (unless overwritten by more specific behavior) a right click pops up a menu window that allows to choose whether or not to show the items toolbox, the property editor, and so on. This is exactly what one would expect in a topbar pulldown menu entitled "Windows" [at least under Unix - maybe Microsoft has a different name for it??].

For sure, we should add this topbar item.

In principle, we could leave the current right-click behavior as an alternative way to access the windows menu. However, I find it rather counterintuitive that while working in the main canvas a mouse click brings up a menu that is not about my current editing but about some global settings. So I would strongly opt for leaving the right click inactive unless sensibly used for some operation related to the widget the mouse is pointing at.

#2 Updated by pospelov over 3 years ago

In general, my idea to have same dock menu switch, as in JobView (very right bottom corner). So the right-bottom context menu will be gone in SampleView.

It would be nice to have same GUI tricks across the whole BornAgain. So user should not get used to the new concept of layout switches while changing between SampleView and JobView.

Please also see my comments here #1508.

This is exactly what one would expect in a topbar pulldown menu entitled "Windows" [at least under Unix

It would be useful to collect some successful examples of GUI design decisions under Unix/Windows (screenshots would suffice), particularly how multi dock windows (i.e. like our SampleView) are handled, so we could learn from it.

#3 Updated by pospelov over 3 years ago

  • Status changed from Backlog to Sprint
  • Target version set to Sprint32

#4 Updated by pospelov about 3 years ago

  • Target version changed from Sprint32 to Sprint 33

#5 Updated by herck over 2 years ago

  • Status changed from Sprint to Backlog

#6 Updated by herck over 2 years ago

  • Target version deleted (Sprint 33)

#7 Updated by pospelov about 1 year ago

  • Status changed from Backlog to Sprint
  • Target version set to Sprint 38

Adding to the current sprint (may be moved to the next one).

During conference I have realized that we need better docking in SampleView to make full use of our 3D viewer.

#8 Updated by pospelov about 1 year ago

  • Assignee set to pospelov

#9 Updated by pospelov about 1 year ago

  • Assignee deleted (pospelov)
  • Target version changed from Sprint 38 to Sprint 39

#10 Updated by pospelov about 1 year ago

  • Assignee set to pospelov

#11 Updated by pospelov about 1 year ago

  • Description updated (diff)

#12 Updated by pospelov about 1 year ago

  • Status changed from Sprint to Resolved

Implemented most of features mentioned in the description.
Created issues #2202 and #2206 for skipped parts.

Also available in: Atom PDF