Refactoring #1541

Feature #1290: === Core: framework ===

Feature #1712: == Code maintenance ==

review areAlmostEqual and get_relative_difference

Added by wuttke about 3 years ago. Updated almost 3 years ago.

Status:BacklogStart date:28 Jul 2016
Priority:LowDue date:
Assignee:-% Done:

0%

Category:-
Target version:-

Description

Is there need for a tolerance_factor? Probably not.

Are small numbers meant on a linear or a logarithmic scale? Is 1e-100 - 0 a small relative difference?

Why isn't get_relative_difference(a,b) symmetric in a<->b?

What are the consequences for simulations and fits?

By the way: areAlmostEqual is used only once in the new Fit/ directory, and should therefore be replaced by a local routine, so that Numeric.h can be moved to Core/.

History

#1 Updated by wuttke about 3 years ago

With 7c816ab there comes a rudimentary unit test TestRelDiff, to be expanded while this issue is being solved.

#2 Updated by wuttke about 3 years ago

  • Status changed from Sprint to Backlog
  • Priority changed from High to Normal

With ba2dff7f2, the non-monotonicity in |b| is cured.

The remaining questions are less urgent.

#3 Updated by wuttke about 3 years ago

  • Target version deleted (Sprint32)

#4 Updated by wuttke almost 3 years ago

  • Priority changed from Normal to Low

#5 Updated by wuttke almost 3 years ago

  • Description updated (diff)

#6 Updated by wuttke almost 3 years ago

  • Parent task changed from #1290 to #1712

Also available in: Atom PDF