Refactoring #1660

Feature #1290: === Core: framework ===

remove global functions

Added by wuttke almost 4 years ago. Updated almost 4 years ago.

Status:ResolvedStart date:22 Nov 2016
Priority:NormalDue date:
Assignee:wuttke% Done:

0%

Category:-
Target version:Sprint 33

Description

Now listed under Doxygen tab "Globals".
Some global functions are actually used in one file only => enclose them in an anonymous namespace.
Others are really meant to be global => consider enclosing them in an utility namespace, or refactor them into class member functions.

History

#1 Updated by herck almost 4 years ago

Moving global functions to scope-limited functions is a good refactoring. Moving them to class methods increases the exposure of the class implementation. The other way around is generally preferred.

#2 Updated by wuttke almost 4 years ago

  • Status changed from New to Sprint
  • Assignee set to wuttke

#3 Updated by wuttke almost 4 years ago

  • Status changed from Sprint to Resolved

Learned from Walter that not all global functions are bad. Unnecessary globals are mostly removed with pull request #88.

Also available in: Atom PDF