Refactoring #1735

Feature #1290: === Core: framework ===

Feature #1712: == Code maintenance ==

remove include guards from unit tests

Added by wuttke almost 4 years ago. Updated almost 4 years ago.

Status:ResolvedStart date:12 Dec 2016
Priority:NormalDue date:
Assignee:wuttke% Done:

0%

Category:-
Target version:-

Description

There is no reason why a unit test h file should be included twice, therefore there is no reason to have include guards.

If accidentally the same include guard is used in two different unit tests (as may happen when a new test is created by copy & paste), then one of the two tests will not be executed. No warning will appear, and the bug may go unnoticed for long. To mitigate this risk, I suggest to remove the include guards for good.

History

#1 Updated by wuttke almost 4 years ago

  • Assignee set to wuttke

-> pull request 121

#2 Updated by wuttke almost 4 years ago

  • Status changed from New to Resolved

Resolved in 38845bca.

Also available in: Atom PDF