Refactoring #2234

Fit: Simplify minimizer constructor

Added by pospelov almost 2 years ago. Updated 13 days ago.

Status:BacklogStart date:29 Nov 2018
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:-
Target version:-

Description

For the moment minimizer initialization string has 3 parameters which allows to set minimizer type, minimizer algorithm and option string

minimizer.setMinimizer("Minuit2")
minimizer.setMinimizer("Minuit2", "Migrad")
minimizer.setMinimizer("Minuit2", "Migrad", "MaxFunctionCalls=500;Strategy=2")

The problem is that some minimizers has only one algorithm, so the string become

minimizer.setMinimizer("Genetic", "", "seed=1");

Empty string as second parameter looks not very natural and complicates tutorial writing.

Suggestion: merge algorithm and option string together.

minimizer.setMinimizer("Minuit2", "Algorithm=Migrad;MaxFunctionCalls=500;Strategy=2")

Related issues

Related to BornAgain - Refactoring #2476: Fit: catalogize algorithms, not minimizers Backlog 14 Jul 2020

History

#1 Updated by wuttke 13 days ago

  • Subject changed from Simplify minimizer constructor to Fit: Simplify minimizer constructor

#2 Updated by wuttke 13 days ago

Also available in: Atom PDF