Refactoring #2240

Refactor unit convertor construction in InstrumentItem

Added by pospelov 9 months ago.

Status:BacklogStart date:03 Dec 2018
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:-
Target version:-

Description

Suggestions:

  • Introduce public Simulation::createConvertor()
    • Thus, move all convertors creation on board of corresponding Simulation, get rid of ConverterUtils::createConverter
  • Remove InstrumentItem::createInstrument()
  • Introduce InstrumentItem::createSimulation()
    • Move all simulation creation code from DomainBuilder* on board of corresponding instrument.
  • Introduce InstrumentItem::createConverter()
    • On board it will simply do createSimulation().createConverter()
    • Get rid of DomainObjectBuilder::createUnitConverter
  • Make InstrumentItem to be the interface class which contains only virtual createSimulation()
    • No background, masks, initBeamGroup, updateToRealData, alignedWith etc.

Also available in: Atom PDF