Refactoring #2457

Code organisation: facilitate sample model API changes

Added by wuttke 7 months ago. Updated about 9 hours ago.

Status:RejectedStart date:18 May 2020
Priority:HighDue date:
Assignee:wuttke% Done:

0%

Category:-
Target version:v.1.19

Description

To add, remove or rename a form factor one needs to change close to 40 files [1,2].
This must be radically simplified.

[1] https://github.com/scgmlz/BornAgain/pull/949/commits/19275098f7077f8c336a7c8105bb19b34a60c6bf
[2] https://github.com/scgmlz/BornAgain/pull/955/commits/fb72b71bfa5e350779f2cbff7187efa7dce55668


Related issues

Related to BornAgain - Refactoring #1766: Core: FF: Replace all form factors in sample creation by shapes Backlog 16 Feb 2017

History

#1 Updated by wuttke 7 months ago

  • Description updated (diff)

#2 Updated by wuttke 7 months ago

Easy simplifications in Core:
  • set name in constructor; get rid of ...Type string constants in BornAgainNamespace.h; no need for testing name in Tests/UnitTests/Core/Sample/FormFactorBasicTest.cpp
  • in Core/Parametrization/INodeVisitor.h, no need for forward class declaration, just use "class" in " virtual void visit" definitions.

#3 Updated by wuttke 5 months ago

  • Assignee set to wuttke

#4 Updated by wuttke 5 months ago

  • Related to Refactoring #1766: Core: FF: Replace all form factors in sample creation by shapes added

#5 Updated by wuttke 5 months ago

  • Status changed from New to Sprint
  • Target version set to v1.18

#6 Updated by wuttke 2 months ago

  • Subject changed from Facilitate sample model API changes to Code organisation: facilitate sample model API changes
  • Status changed from Sprint to Backlog

#7 Updated by wuttke 2 months ago

  • Target version changed from v1.18 to v.1.19

#8 Updated by wuttke about 9 hours ago

  • Status changed from Backlog to Rejected

No longer an aim in itself; will be addressed as we go along.

Also available in: Atom PDF