Code organisation: facilitate sample model API changes
|Status:||Rejected||Start date:||18 May 2020|
To add, remove or rename a form factor one needs to change close to 40 files [1,2].
This must be radically simplified.
Easy simplifications in Core:
- set name in constructor; get rid of ...Type string constants in BornAgainNamespace.h; no need for testing name in Tests/UnitTests/Core/Sample/FormFactorBasicTest.cpp
- in Core/Parametrization/INodeVisitor.h, no need for forward class declaration, just use "class" in " virtual void visit" definitions.