Activity

From 18 Apr 2016 to 17 May 2016

17 May 2016

18:03 Revision b5414322: New experimental InfoLabelWidget to display messages on top of arbitrary viewp...
pospelov
16:58 Revision 73f35421: Tooltips for FitParameterItem tree columns
pospelov
16:27 Revision 68bbab64: FitParameterItem now takes limits attributes from first ParameterItem being dr...
pospelov
15:40 Revision e1a97103: Drop of ParameterItem to empty tree, cleanup in FitParameterWidget
pospelov
14:13 Refactoring #1428 (Backlog): Compactify code that handles parameters (use abstract mechanism inst...
agreed in meeting today wuttke
14:13 Refactoring #1428: Compactify code that handles parameters (use abstract mechanism instead of tre...
By convention, all lengths are in nm, all angles are internally in rad. Therefore, we only need the physical dimensio... wuttke
14:10 Refactoring #1430 (Resolved): Consider moving FormFactor unit tests to a single functional test
The main concern will be resolved per issue #1433.
Renaming of subdirectories will follow later, when Core/ is res...
wuttke
13:59 Refactoring #1433 (Resolved): move massive numeric tests under 'make check' / 'ctest'
to be done when the polyhedral FF is stable (#1432) wuttke
13:56 Refactoring #1432 (Rejected): final polish of polyhedral form factor
* specific tests for frusta that are true pyramids
* exact treatment of vertices that coincide
* -improve edge sum ...
wuttke
11:42 Documentation #1431 (Resolved): simplify cross-referencing using package cleveref
wuttke
11:12 Revision c2dc3592: New mime types in SessionXML and minor renaming
pospelov
11:01 Revision 08f30e3f: Blocked drag operation in the case of ParameterLabel item
pospelov
10:45 Revision 23d3a229: Cleanup in ParameterTuning* family
pospelov
10:43 Revision c5f1d8c1: Merge branch 'fftest' into develop: corrected termination criterion for series...
wuttke
09:59 Revision 76fa799e: Renaming in ModelTuningDelegate and co
pospelov
09:39 Revision 071ffc34: ParameterTuningModel is introduced to encapsulate parameter tuning/dragging ac...
pospelov
09:32 Revision c207cc4e: make FormFactorPolyhedron pure virtual
wuttke
08:56 Revision aa87806d: SessionModel modified to allow copy action
pospelov

16 May 2016

17:49 Revision 3683c7b5: First version of dragging from ModelTuningWidget
pospelov
16:51 Revision 13b0d653: FitParameter link drag/drop within FitParameterTree is working
pospelov
16:16 Revision 7dd1cf4a: First drag/drop attempts in FitParameterAbsModel
pospelov
14:49 Revision 21707625: Removal of FitParameterItemLinks from the tree is implemented
pospelov
14:26 Revision 0db5c8e4: todo note
wuttke
14:21 Revision 6739816f: move sym_Ci to Topology
wuttke
14:17 Revision 0b910234: Method for getSelectedParameterItem moved to ModelTuningWidget
pospelov
14:06 Revision 5110b34f: continuity test requires revert of q_lim from 1e-4 to 1e-5; this requires rela...
wuttke
13:50 Revision 212f7e76: Delete event filter installed to fit parameter tree
pospelov
13:47 Revision 9957968e: Further reduction of test limits
wuttke
13:32 Revision f38c51cc: Stricter criteria in spec and sym tests
wuttke
13:20 Revision ebb4ae38: FitParameter's min/max now of grey color if not editable
pospelov
13:11 Revision f29c3e2d: Improved summation now also for q expansion.
wuttke
12:51 Revision ac9f5cee: merged qpa expansion code for prism and others; new termination criterion now ...
wuttke
12:50 Revision 2e275c4e: Updated logic on fit parameter type change
pospelov
12:17 Revision 92c343b6: improved termination criterion for qpa expansion, improves worst-cast continui...
wuttke
11:40 Revision 4ef78262: revert Kahan (no advantage)
wuttke
10:11 Revision 0a795c5e: try Kahan summation algorithm in edge_sum_ff => no advantage, it seems
wuttke

15 May 2016

12:29 Revision 40ae2457: stricter limits for some more tests ..
wuttke
12:21 Revision 6ca4c843: much stricter FormFactorBasicTest
wuttke
12:14 Revision 547592a8: moved common factor e^iqrperp out of analytic ff2d() => breakthrough in accura...
wuttke

13 May 2016

17:10 Feature #1238: nicer layout for newsletter@bornagainproject.org (reopened: v1.6.0 round mail stil...
I really do not like the black topbar.
Plain ASCII would be nicer than this HTML.
wuttke
16:37 Revision c24d3df3: New mapping in FitParameterItems
pospelov
15:42 Revision 1cdeb903: New fit parameter type introduced (fixed, free, etc) and corresponding delegat...
pospelov
15:12 Revision 5cb77085: SessionModel technical view appearance is controlled now from main window.
pospelov
14:57 Revision a8598891: Base of AnisoPyramid has symmetry S2. Matching test strangely broken.
wuttke
13:53 Refactoring #1424: reduce verbosity of googletest output
Feature request submitted at https://github.com/google/googletest/issues/771. wuttke
10:29 Revision 2229e6e4: Zwischenstand
wuttke

12 May 2016

19:15 Revision 50a81263: Found test case where Re F(q) > V
wuttke
18:45 Revision 599f83c6: BROKEN (trying to improve accuracy of 2d analytic ff)
wuttke
18:16 Revision 70b3856a: New developer's SessionModelView will be hidden part of mainwindow on permanen...
pospelov
17:26 Revision cf672c7d: New universal SessionModelDelegate to operate together with SessionModel
pospelov
13:21 Refactoring #1428: Compactify code that handles parameters (use abstract mechanism instead of tre...
So I withdraw default units from the current proposal. Are units acceptable for you? wuttke
13:12 Refactoring #1428: Compactify code that handles parameters (use abstract mechanism instead of tre...
Maybe this issue should also be split: default values vs units herck
13:11 Refactoring #1428: Compactify code that handles parameters (use abstract mechanism instead of tre...
> > It's not their responsibility.
>
> We are free to assign responsibilities to our creatures as we deem appropri...
herck
13:01 Refactoring #1428: Compactify code that handles parameters (use abstract mechanism instead of tre...
So yes, you want users to get default parametrized items. OK, I accept.
> Core form factors should not have any de...
wuttke
12:38 Refactoring #1428: Compactify code that handles parameters (use abstract mechanism instead of tre...
In GUI default values should be provided to reduce amount of clicks/typing. This allows to start a simulation with a ... pospelov
11:59 Refactoring #1428: Compactify code that handles parameters (use abstract mechanism instead of tre...
The very first question then: Is it actually appropriate for the GUI to assign default parameters to newly created it... wuttke
11:43 Refactoring #1428: Compactify code that handles parameters (use abstract mechanism instead of tre...
The {FF}Items need default values because the GUI needs to create them without user initialization. There is no need ... herck
11:39 Refactoring #1428: Compactify code that handles parameters (use abstract mechanism instead of tre...
interesting consequence. why not? wuttke
10:57 Refactoring #1428: Compactify code that handles parameters (use abstract mechanism instead of tre...

> Each parameter should have a default value
What does it mean? "new FormFactorSphere()" becomes valid and becom...
pospelov
13:16 Refactoring #1430: Consider moving FormFactor unit tests to a single functional test
The number 200k comes from arbitrary choices and can be changed if time is a concern.
The tests are concerned with...
wuttke
13:00 Refactoring #1430: Consider moving FormFactor unit tests to a single functional test
I also agree that these tests conceptually do not belong to unit tests. It also obscures unit test coverage (having 2... herck
12:54 Refactoring #1430: Consider moving FormFactor unit tests to a single functional test
My previous reply disappeared since you commented same record I was commenting.
> Why do we actually have a functi...
pospelov
12:42 Refactoring #1430: Consider moving FormFactor unit tests to a single functional test
> [ RUN] OK is better than just [——]
Agree. Implemented in 91d8e8f5b0.
wuttke
12:36 Refactoring #1430: Consider moving FormFactor unit tests to a single functional test
Nothing in googletest says it is limited to unit tests, let alone to unit tests in the most narrow sense. Why do we a... wuttke
12:31 Refactoring #1430: Consider moving FormFactor unit tests to a single functional test
I put two issues in one, that's true. The major issue is to move Unit to Functional. pospelov
12:09 Refactoring #1430: Consider moving FormFactor unit tests to a single functional test
These are two different issues:
* Move extensive ff tests from Unit to Functional?
* Don't split Core/Unit tests in...
wuttke
10:43 Refactoring #1430 (Resolved): Consider moving FormFactor unit tests to a single functional test
I think that tests of form factor behaviour near singularity and along symmetry axes belongs to the functional tests,... pospelov
12:27 Revision 91d8e8f5: improve output from patched gtest.cc.
wuttke
11:31 Revision f8e2695c: New methods in ModelMapper to notify subscribers on item deletion
pospelov

11 May 2016

18:28 Bug #1371: presence of some boost components not checked by cmake
Btw: testing under Debian is somewhat difficult because of the non-standard packaging of Boost. Reported at https://b... wuttke
17:39 Bug #1371 (Resolved): presence of some boost components not checked by cmake
Resolved in ac0d39e, using a patched FindBoost.cmake that is to be submitted to CMake: https://github.com/rleigh-dund... wuttke
18:10 Refactoring #1366: Revise boost libraries usage
Migration of regex from Boost to regex is suspended because compilers are not ready. => commit d14b964d17bb wuttke
17:34 Refactoring #1366: Revise boost libraries usage
Only now enacted the deletion of boost components regex and thread in cmake/modules/SearchInstalledSoftware.cmake. wuttke
18:08 Revision d4423818: Experimenting with add/remove rows of FitParameterModel
pospelov
17:54 Revision d14b964d: restore dependence on boost::regex (std:regex not supported by gcc 4.8)
wuttke
17:37 Revision ac0d39ed: Include patched FindBoost.cmake from https://github.com/Kitware/CMake/compare/...
wuttke
17:07 Revision 17552e30: FitParameterModel now re-emits signals when source model has rows inserted/rem...
pospelov
16:38 Revision 46e56b74: Context menu to remove fit parameters in FitParametersWidget
pospelov
15:20 Revision 97f5392f: setData now is working for FitParameterAbsModel
pospelov
14:36 Refactoring #1424 (Resolved): reduce verbosity of googletest output
wuttke
14:36 Refactoring #1424: reduce verbosity of googletest output
Solved in rather unexpected way in 24204e5, namely by brutally patching gtest. Inheriting outside gtest.cc from the d... wuttke
14:35 Revision 1e737b43: Model cleanup before moving further
pospelov
14:33 Revision 24204e5f: Patched gtest to suppress output from successful subtests. This resolves #1424.
wuttke
14:31 Revision 6485acc3: Bug ifx in FitParameterAbsModel while calculating index of parent
pospelov
14:15 Revision 740374e9: Correct column calculation in FitParameterAbsModel
pospelov
13:46 Revision a07d3946: Bugfix in FitParameterModel preventing item links from selection in a tree view.
pospelov
13:07 Bug #1429 (Resolved): Unit tests files are not shown in Qt Creator IDE
Solved in 03d6c5d, using 'add_custom_target' as suggested in http://stackoverflow.com/questions/28384935/qtcreator-cm... wuttke
08:48 Bug #1429 (Archived): Unit tests files are not shown in Qt Creator IDE
Files from UnitTests/TestCore directory (and similar) are not shown in "Project Structure" by Qt creator IDE. It is n... pospelov
13:06 Revision 03d6c5dd: Twist UnitTests.cmake to make .h sources appear in QtCreator's project tree. T...
wuttke
12:39 Refactoring #1428: Compactify code that handles parameters (use abstract mechanism instead of tre...
To automatically generate Python constructors,
* either use named arguments
* or make sure that parameters are orde...
wuttke
10:11 Revision ff203c51: Merge branch 'fftest' into develop
wuttke
09:57 Revision dc72bf9b: correct/improve comments
wuttke

10 May 2016

18:11 Revision e4ef6cab: New unit tests for FitParameterAbsModel
pospelov
15:28 Revision 3a175205: + comment
wuttke
15:07 Revision 8e84ab2d: Yet another experimental FitParameterModel based on QAbstractItemModel
pospelov
14:08 Refactoring #1428 (Archived): Compactify code that handles parameters (use abstract mechanism ins...
Each parameter should have -a default value and- a -unit- physical dimension, assigned upon registration.
This wil...
wuttke
13:34 Revision 85f90aba: New FitModelHelper containing all helper methods for hadling fit parameter items
pospelov
13:21 Revision 4e709b18: Merge branch 'fftest' into develop: Improved ff tests; rotated prism3 and tetr...
wuttke
12:47 Documentation #1279 (Archived): Inkscape tasks
wuttke
12:46 Documentation #1280 (Resolved): draw tetrahedron as seen from -x
Completed in 4003c83. wuttke
12:45 Revision 4003c836: Tetrahedron cuts redrawn after rotation by 30 deg. This closes #1280.
wuttke
12:20 Revision ee8eaa84: Prism3 cuts redrawn after rotation by 30 deg
wuttke
09:54 Revision 1f789794: Further experiments with FitParameterModel
pospelov
09:34 Revision 7fb24a36: Start drawing rotated Prism3d.
wuttke

09 May 2016

16:58 Revision 93067f85: Experimenting with proxy model
pospelov
15:45 Revision ef404064: New FitParameterProxyModel to show fit parameters in 5 column view (will repla...
pospelov
11:30 Revision 17e3b0c5: Merge branch 'JobViewRef' into develop
pospelov
11:29 Revision 8f4ccacb: Mainwindow returned to the default state
pospelov
09:00 Revision b5c70076: + triangle_runs
wuttke
08:59 Revision 0d21d422: ..
wuttke

07 May 2016

08:06 Revision 6f2ef695: Rotated Tetrahedron and Prism3 to maximize the symmetry of xz detector images.
wuttke

06 May 2016

22:16 Revision e119f819: latest version used to produced figures for ff paper
wuttke
16:59 Revision 3485f0fd: + ff triangle, for test purposes; corr and improved runff.
wuttke
14:48 Revision dd0746d4: new test mode: loop over |q| for given direction
wuttke
12:04 Revision cb0c757e: ..
wuttke
11:39 Revision fe34042e: ..
wuttke
11:29 Revision c5f07ca5: q scans for continuity test completely renewed
wuttke
10:02 Revision da8997b8: Split continuity test / other loops done.
wuttke
09:14 Revision c1bc6738: preparing ff test for extension
wuttke

04 May 2016

21:06 Revision 41d18abb: Correct construction of q in looped tests, and remove duplication.
wuttke
19:48 Revision 06a8fadb: Many more symmetry and specialization tests - and voilà, tolerances need to be...
wuttke
19:16 Refactoring #1424 (Sprint): reduce verbosity of googletest output
with increasing number of tests, this is becoming urgent wuttke
17:06 Revision e56cebfb: Merge branch 'develop' of apps.jcns.fz-juelich.de:BornAgain into develop
wuttke
17:06 Revision 21f63125: Stricter limits in ff unit tests
wuttke
16:11 Revision e099654b: Place holders for minimizer settings and fir results widgets.
pospelov
15:49 Revision 98ad190b: Size grip is disabled on JobView status bar
pospelov
15:18 Revision 1681147a: Update interval slider is connected with fitting engine. Fitting interruption ...
pospelov
14:19 Feature #1427: Implement new roughness calculation that is more stable for large roughness
Resolved in #d212f6feba85d4a7f41db0b15ae90a697e1acd01 herck
14:19 Feature #1427 (Resolved): Implement new roughness calculation that is more stable for large rough...
herck
14:18 Feature #1427 (Archived): Implement new roughness calculation that is more stable for large rough...
herck
14:17 Revision d212f6fe: Merge branch 'roughness_stable' into develop
herck
14:13 Revision a2703fd8: Regenerated reference files for functional tests related to roughness
herck
13:51 Revision 51365991: Regenerate Python bindings
herck
13:41 Revision 4dffe754: Removed old roughness calculation code
herck
13:05 Revision 7ec2a05c: Restored sign conventions of BornAgain for new roughness calculation
herck
12:47 Revision cbd51054: In q expansion, term n=1 no longer needed (zero thanks to choice of origin)
wuttke
12:44 Revision d59b2f5a: Number of fit iterations propagated from domain to FitControlWidget
pospelov
12:28 Revision 7524beb3: mv 'class' declaration into methods (... while reading ...)
wuttke
12:16 Revision 579414af: Merge branch 'cog' into develop: Polyhedra now have origin at center of mass.
wuttke
12:14 Revision 72985692: Bugfix: PyGenVisitor still exported 'radius' of Cone6. Discovered after comput...
wuttke
12:06 Revision 28d1eda0: Merge branch 'tmp' into cog
wuttke
12:05 Revision 27470439: mv comment
wuttke
11:56 Revision 19540b0b: Now all polyhedra have center of mass at origin.
wuttke
10:37 Revision 81255f4d: Moved method to function that is translation unit local using anonymous namespace
herck
10:36 Revision 13ca85f3: FormFactorPolygon now requests origin at center of mass.
AnisoPyramid broken. wuttke

03 May 2016

19:45 Revision 6af4ea4b: preparing for cog
wuttke
18:02 Revision 5453de6c: New label in FitControlWidget showing current slider update interval
pospelov
17:37 Revision d35152d1: Added new roughness calculation with usage of Faddeeva package
herck
17:09 Revision 1fc9ddd8: Further simplification of API: setVertices, precompute merged in setPolyhedron
wuttke
17:02 Revision 3840d734: Bugfix in FitParameterModel on close application event
pospelov
16:46 Revision 822a7ff2: WarningSign in FitRunControlWidget now reports about fitting failure
pospelov
16:24 Revision 5162c02c: Simplify API: topology passed as parameter.
wuttke
15:55 Revision 0c444232: Mapper in ModelTuningDelegate makes fitting crash and thus he is removed (seem...
pospelov
15:35 Revision 7311a49a: New RunFitControl widget to get all control elements out of FitActivityPanel
pospelov
14:08 Revision 9730f00c: Initial sizes of JobRealTimeWidget and FitActivityPanel are changed
pospelov
13:25 Revision 9f3239f0: Code cleanup
pospelov
11:48 Revision 9938a56a: FitParameter values are propagated back to ParameterTree in the course of fitting
pospelov
11:03 Revision 66964d58: ParameterContainerType introduced for all items participating in real time tuning
pospelov
10:04 Revision 96472fbc: Valid links to domain objects are generated for FitParameterItem and Parameter...
pospelov

02 May 2016

20:00 Revision fdf6aa25: more systematic tests
wuttke
18:05 Revision ee5f43c9: First working version of FitSuiteWidget (with functionality similar to David's...
pospelov
17:35 Revision 1cead180: test program runff can now manipulate limits in polyhedral ff computation
wuttke
17:12 Revision 0983ae4b: FitParameterItem now carries link to ParameterTreeContainer item, and not mult...
pospelov
16:39 Revision 9926c814: New DomainFittingBuilder to generate FitSuite object from jobItem
pospelov
13:51 Revision ce18faf3: Start/Stop fitting signals are connected
pospelov
12:48 Revision 0def8d85: FitSuiteWidget and JobRealTime widgets are connected to provide fit parameters...
pospelov
12:32 Revision 5959eac9: New JobPresenter class common for all job views (realTime, OutputData, activit...
pospelov
10:05 Revision 0262f4f3: FitActivityPanel now reacts on activity change
pospelov

29 Apr 2016

18:55 Revision abfb9b6e: correct error in Doxy/LaTeX
wuttke
18:51 Revision 9e9e8a0f: Unit test source files, assembled by CMake, now go into build directory.
wuttke
18:25 Revision 644d3ae3: New FitSuiteWidget to hold fitting settings now part of FitActivityPanel
pospelov
17:54 Refactoring #1366 (Resolved): Revise boost libraries usage
Good progress has been made, thanks Jonathan. There is no need to get rid of _all_ of Boost. wuttke
17:54 Refactoring #1366 (Sprint): Revise boost libraries usage
wuttke
17:48 Bug #1416 (Waiting): form factors with numeric integration fail for small and for large q
waiting for student to work this out wuttke
17:22 Revision 362c1d6e: Merge branch 'iffmanual' into develop: New text on inter-particle correlations...
wuttke
17:20 Revision e5c75763: Merge branch 'fftests' into develop: improve numeric details in form factors,
repair usage of S2 symmetry, update History sections in Manual. wuttke
17:17 Refactoring #1418 (Resolved): provide cotangent, and replace division by tan(alpha) in pyramids
Done in 8c53f8f.
The remaining division by tan(alpha) in FormFactorCone shall be removed later, when this integratio...
wuttke
17:14 Revision 8c53f8f0: Replaced tan by cot in pyramid computations. This resolves #1418.
wuttke
16:00 Bug #1420 (Resolved): Symmetry S2 not usable
A factor i had been accidentally deleted. Now it's back working. Note however that computations with and without sym_... wuttke
13:11 Revision 53da7ad9: Tuned q/qpa limits in polyhedron, and acceptance level in aniso specicializati...
wuttke
10:38 Revision 3429853e: New icons for jobView status bar
pospelov
10:27 Revision 8bd935dc: Dock menu button on jobView status bar
pospelov

28 Apr 2016

18:38 Revision b585f624: Merge branch 'fftests' of apps.jcns.fz-juelich.de:BornAgain into fftests
wuttke
18:37 Revision ba3f7cdf: now searching discrepancy at level 1e-8 ...
wuttke
16:24 Revision d2daa49e: Toggling for job list view is implemented
pospelov
15:57 Revision 4fd09978: Job activity selector is moved from toolbar to status bar
pospelov
15:50 Refactoring #1424 (Archived): reduce verbosity of googletest output
http://stackoverflow.com/questions/36847322/ wuttke
15:02 Revision 501fe63d: Repair bug in prism ff with symmetry S2.
wuttke
14:45 Revision 2e7ca60d: Two new docks in JobView for messages and fit activity.
pospelov
13:25 Revision 761c44af: Refactored order of widgets initialization in mainwindow/JobView
pospelov
12:00 Bug #1423 (Resolved): == eliminate warnings ==
We should aim for zero warnings from the standard build process.
Current warnings
* From third-party C++ code => ...
wuttke
11:29 Documentation #875 (Archived): Provide content for http://gisaxs.com
herck
11:28 Documentation #875 (Resolved): Provide content for http://gisaxs.com
herck
11:28 Documentation #875 (Sprint): Provide content for http://gisaxs.com
herck
11:05 Revision 712bd124: Merge branch 'FitParametersWidget' into develop
pospelov
11:05 Revision 1fe2fcd4: mainwindow is back to default state
pospelov
10:23 Documentation #987 (Rejected): Tidy up the gisas/theory directory
not a task to be done at once, but work in progress wuttke
10:15 Documentation #1262 (Resolved): Fix IsGISAXS references in form factor section
Done in 0871f28. Hopefully, it's now clear where our computation deviates from IsGISAXS. wuttke
10:14 Revision 0871f288: Unify note on F(q) in Manual; review History section (but change little). This...
wuttke

27 Apr 2016

17:47 Revision 052ba03a: Add link to existing fit parameter
pospelov
17:47 Revision 151dc39c: Attempt to make cross-selection between fit items
pospelov
17:47 Revision 1eea68d3: New FitParameterModel to adopt FitParameterItem for 5 columns trees
pospelov
17:47 Revision 2bd4eb38: On the way to implement context menu for ModelTuningWidget
pospelov
17:47 Revision 41385ead: Protection from repetitive adding of the same tuning parameter as fit parameter
pospelov
17:47 Revision 4c243f34: Add tuning parameter to fit parameter implemented
pospelov
17:47 Revision 6785e627: Possibility to remove link from fit parameters
pospelov
17:47 Revision ecef314e: FitSuiteItem and Co for FitParametersWidget
pospelov
17:47 Revision 0c46e5df: FitModel renamed to ObsoleteFitModel
pospelov
17:47 Revision 9a405b56: The rest of fit items which will be refactored, renamed to obsoleteItems.
pospelov
17:47 Revision 9f0a6968: New playground for fit widgets testing
pospelov
17:47 Revision b6d8c41b: FitSettings, RunFit and ImportData widgets renamed to Obsolete*
pospelov
17:47 Revision d6c51c13: FitView renamed to ObsoleteFitView
pospelov
16:35 Revision 5b2b1833: Derivation of sphere ff now in manual.
wuttke
15:45 Revision 71f9cfa5: Add link to existing fit parameter
pospelov
15:03 Revision 409cfd18: Possibility to remove link from fit parameters
pospelov
14:11 Revision 60707e86: Protection from repetitive adding of the same tuning parameter as fit parameter
pospelov
13:41 Bug #1417 (Resolved): numeric inaccuracies in form factors
Anisopyramid reimplemented using polyhedral ff; sym_S2 in Pyramid disabled until resolution of #1420 wuttke
13:37 Refactoring #1422 (Resolved): provide clue when test fails
* when reference test fails, indicate location of old and new image
* when python test fails, provide a clue what to...
wuttke
11:24 Revision e39fbc8d: correct argument of J_0 in cylinder FF derivation
wuttke
11:14 Revision 6bbdebd9: Add tuning parameter to fit parameter implemented
pospelov
10:23 Revision 2dd4e94a: Merge branch 'fftests' into develop: Improved tests, reimplemented AnisoPyramid.
wuttke
10:15 Revision c29a3dfe: adjust q ranges in tests; add comments and references to open issues
wuttke
09:09 Revision 6d0894ff: extend range for series expansion in FormFactorFullSphere => now passes string...
wuttke
09:00 Revision 9cb61810: AnisoPyramid reimplemented using Polyhedron.
Updates SpecializationTests.
BROKEN: BasicTest.
wuttke
08:46 Bug #1420: Symmetry S2 not usable
wrong results, therefore disabled in Prism6 and Pyramid wuttke
08:13 Revision 090877dd: Merge branch 'fftests' into develop: Corrected FullSphere FF,
which wrongly yielded 0 for very small q. wuttke
08:12 Revision f7076816: Update reference data involving FF FullSphere: has improved
wuttke

26 Apr 2016

20:54 Revision 0e47b749: Derivation of cylinder form factor: so simple it can be made.
wuttke
18:14 Revision 4399f3e6: On the way to implement context menu for ModelTuningWidget
pospelov
17:41 Feature #975 (Backlog): man page should be built at release time
wuttke
17:40 Documentation #1262 (Sprint): Fix IsGISAXS references in form factor section
wuttke
17:39 Refactoring #1065 (Sprint): Revise particle form factors: change names, add few form factors, cha...
agreed since long that this should be part of the next API-breaking sprint wuttke
17:25 Revision 9af3f276: New FitParameterModel to adopt FitParameterItem for 5 columns trees
pospelov
17:20 Feature #1415 (Backlog): onChange() should invalidate cache, and not immediately execute precompu...
wuttke
16:42 Bug #1421 (Resolved): FullSphere F(q)=0 for small q
Done in c3568ef. wuttke
12:50 Bug #1421 (Resolved): FullSphere F(q)=0 for small q
runff 1 0 11 1 0 0 0 0 0 1e-7 => (4.15786325694,0)
runff 1 0 11 1 0 0 0 0 0 1e-8 => (0,0)
wuttke
16:41 Revision c3568eff: Repaired FormFactorFullSphere.
Rearranged formula. At this occasion, switched to series expansion for qR<5e-5. wuttke
14:24 Revision 5957c577: FitSuiteItem and Co for FitParametersWidget
pospelov
12:48 Bug #1420 (Resolved): Symmetry S2 not usable
therefore the symmetry is not used until this is resolved wuttke
12:46 Bug #1294 (Resolved): provide substantial unit tests for factor computations
Done in 6b09bc4.
We are now testing:
* whether F(0)=V
* continuity (comparing F(q) for small q with F(0))
* sym...
wuttke
12:43 Revision 6b09bc43: Merge branch 'fftests' into develop: Form factor tests.
This closes issue 1294 (provide substantial tests for form factors).
We are now testing:
- whether F(0)=V
- symmetry ...
wuttke
12:36 Revision 552ef9c9: sort directories
wuttke
11:41 Revision a3d85f9a: start new test program in ad-hoc/JWu to investigate freshly discovered problems
wuttke
10:10 Revision 1edd8082: correct notation, and temporarily switch off sym_S2, which solves the problem ...
wuttke
09:54 Revision 639d5a20: Specialization test on Prism6 also fails.
wuttke
09:45 Revision bf9f620b: Implemented small-q test in FormFactorBasicTest;
not ready fro merge because severe errors were detected in three form factors. wuttke

25 Apr 2016

21:24 Revision 6bb1feeb: more symmetry tests. Prism6 detects considerable inaccuracy
wuttke
19:41 Revision 330ccddd: outcommented attempts to reduce noise
wuttke
17:47 Revision 82e0bab5: start symmetry tests
wuttke
17:39 Revision 469ebd53: utility file for q looping rewritten, and moved to UnitTests/utilities
wuttke
17:18 Revision 68cf935f: Separate functionality within QLoopedTests
wuttke
16:57 Revision e9428dcd: Let Google do the looping
wuttke
16:53 Revision a07770cc: New playground for fit widgets testing
pospelov
16:10 Revision 6e00cf0c: Move generation of q values for tests to qGenerator.h
wuttke
16:06 Refactoring #1419 (Archived): move test code out of core
qGenerator.h has been provisionally packed in Core/StandardSamples.
If I see correctly, this directory contains much...
wuttke
15:03 Bug #1294: provide substantial unit tests for factor computations
Specialization tests implemented.
More tests needed.
wuttke
15:02 Refactoring #1418 (Resolved): provide cotangent, and replace division by tan(alpha) in pyramids
somehow 1/tan(pi/2) works, but we should not rely on it wuttke
15:00 Revision 0ce89f3b: prism tests: work in spite of division by tan(pi/2).
wuttke
14:30 Revision 9688be58: document issue with q-range restricted form factors
wuttke
14:25 Revision eecdb3bb: corrections
wuttke
13:28 Revision 0211f997: Polyhedral topology is now const static.
This will allow us to procompute diameter (= characteristic length scale)
before creating polyhedral faces.
wuttke
11:12 Revision 667b04a4: Dismantle special treatment of true pyramids: this shall be implemented in a m...
wuttke
10:55 Revision 24b96b17: new specialization test: pyramid4
wuttke
10:51 Bug #1417 (Resolved): numeric inaccuracies in form factors
* According to FormFactorSpecializationTest:
** Pyramid and AnisoPyramid agree only for moderate values of |q|.
* -...
wuttke
10:06 Revision 91d743b1: no more constructor calls PolyhedralFace(..) with empty vertex list
wuttke
09:09 Bug #1416 (Waiting): form factors with numeric integration fail for small and for large q
* For small q: inaccurate results, as demonstrated by TruncatedSphere vs FullSphere in FormFactorSpecializationTests.... wuttke
09:02 Revision 7a37f8fa: nontrivial form factor test: does truncated sphere with H=2R agree with full s...
wuttke
06:57 Revision ab3024c6: Merge branch 'fftests' into develop:
Unit tests now handled by module UnitTests.cmake.
Core tests splitted in several directories, to allow parallel compi...
wuttke

24 Apr 2016

19:37 Revision d15a61a2: minor edits in long unit test sources
wuttke
19:18 Revision e74c236a: Test fixture for MultiLayerTest.h
wuttke
08:07 Revision 8c570c8e: Improve comments in autogenerated gtest files.
wuttke

23 Apr 2016

19:13 Revision 461e92ab: move template files out of UnitTests.cmake
wuttke
18:31 Revision 48f8930b: New module UnitTests.cmake, handling UnitsTests subdirectories Core and Fit.
wuttke
18:09 Revision cf6d116c: UnitTest/Core split in several subdirectories to allow parallel make
wuttke
08:41 Revision d27e6e4a: Most of CMakeLists goes into function UNIT_TEST_DIRECTORY
wuttke
07:56 Revision 5f412ba4: List of #include's for main.cpp now autogenerated by CMake.
Furthermore, gtest.h included only in main.cpp, not in every single test (=> only tiny speed gain). wuttke

22 Apr 2016

18:01 Revision 48b38cd5: repetetive tests -> function clone_test
wuttke
16:10 Revision f42b59b6: Revert "Re-enable unicode-math package"
This reverts commit 0c23b53a3f1a94c3e91c0b9518cf8d049617f1d0. wuttke
16:03 Revision 03eb6da0: Added reference to used formalism and small correction
herck
16:03 Revision 101aba98: Copied subsection to be modified for one dimensional paracrystal
herck
16:03 Revision 18024cea: Add small absorptive component when eigenvalue in polarized Parratt formalism ...
herck
16:03 Revision 7c734443: Small corrections
herck
16:03 Revision 841c7f9a: Minor corrections and removed redundant T-R decoupling approximation
herck
16:03 Revision 8720e1f6: Added one- and two-dimensional lattice interference function to documentation
herck
16:03 Revision 8ada51e6: Changed notation in two-dimensional lattice interference function documentation
Walter Van Herck
16:03 Revision 99658a84: Documented one-dimensional and radial paracrystal interference function
Walter Van Herck
16:03 Revision cfe05c10: Small changes to definitions and formulas for interference function
herck
16:03 Revision efe49256: Added particle type to normalized perturbation potential and swapped two parti...
herck
16:03 Revision f032ead6: Added two-dimensional paracrystal description to user manual
Walter Van Herck
16:03 Revision fbdb2b9c: Re-enable \iffalse to remove old documentation
herck
16:00 Revision 0c23b53a: Re-enable unicode-math package
herck
16:00 Revision 2e2cf9ce: Additional general expression for particle flux and correction for case when k...
herck
16:00 Revision 449ecfb4: Uncomment old parts of text and replace old macro's by new ones
herck
16:00 Revision 505d38e6: Provided appropriate way of dealing with k_\perp becoming zero in BornAgain (d...
herck
16:00 Revision c6534a82: Minor corrections
herck
16:00 Revision d0299e12: Corrected treatment of k_\perp is zero for top layer of multilayer and impleme...
herck
16:00 Revision e1b0ac03: Added comment to clarify why amplitudes need to vanish for a multilayer when t...
herck
15:17 Bug #1371 (Waiting): presence of some boost components not checked by cmake
wuttke
14:21 Feature #1415 (Sprint): onChange() should invalidate cache, and not immediately execute precompute()
on advise by Walter, we go for option 1:
* each thread has it's own copy of sample parts, so threading will not be a...
wuttke
11:27 Feature #1415 (Rfc): onChange() should invalidate cache, and not immediately execute precompute()
wuttke
09:17 Feature #1415 (Backlog): onChange() should invalidate cache, and not immediately execute precompu...
This is not only for elegance, but improves functionality: Currently, an exception is thrown whenever one parameter i... wuttke
13:08 Documentation #1102 (Backlog): review normalization, especially in view of finite sample extensio...
wuttke
13:01 Revision 970f72bb: The rest of fit items which will be refactored, renamed to obsoleteItems.
pospelov
11:37 Revision cb33eadd: FitSettings, RunFit and ImportData widgets renamed to Obsolete*
pospelov
11:36 Refactoring #1410 (Resolved): rename GCCXML_SKIP_THIS
Resolved in d163e2e. wuttke
11:28 Refactoring #1410: rename GCCXML_SKIP_THIS
no, only the name is obsolete wuttke
11:35 Revision d163e2ed: Replaced GCCXML_SKIP_THIS by SWIG. This resolves #1410.
wuttke
11:22 Revision 22399faa: FitView renamed to ObsoleteFitView
pospelov
11:17 Revision 1efd1543: FitModel renamed to ObsoleteFitModel
pospelov
10:52 Revision 8fa327cf: Merge branch 'fftests' into develop: Several minor repairs and improvements;
renamed UnitTests/ subdirectories; not yet worked on the form factor tests. wuttke
10:50 Revision 795c6632: repaired FitParameterLinkedTest (however, addMatchedParametersFromPool is curr...
wuttke

21 Apr 2016

19:19 Revision 8221c3ee: Restore RealParameterWrapperTest.h, with RealParameterWrapper part of an IPara...
wuttke
18:36 Revision 0bcd4e19: update CMakeLists (App has gone)
wuttke
18:32 Revision 3444c38b: Checked Bessel function outcome against online calculator, and removed 'TODO' ...
wuttke
18:32 Revision e0561c4a: shorter directory names under UnitTests/
wuttke
18:28 Documentation #1400 (Sprint): blender: paint dodecahedron and icosahedron
I put it in the sprint, and when later assign to myself when in the 'blender' mood. pospelov
18:27 Bug #1411 (Rejected): FindGSL version test fails under cmake-3.0 => BornAgain does not build on D...
Should be fixed by now. pospelov
18:26 Bug #1404 (Resolved): compilation broken for libgsl2
I have updated minimizers and removed check for GSL version. It compiles with 1.16 and 2.1 without any additional cma... pospelov
18:06 Revision c3caf8dd: Merge branch 'FixGSL2' into develop
pospelov
18:05 Revision 5d7cb455: Removed requirement on GSL version, should compile with 1.16 and 2.1
pospelov
17:59 Bug #1294 (Sprint): provide substantial unit tests for factor computations
first, repair broken tests related to parameter pool wuttke
17:56 Support #852: Make GUI available at JCNS servers
Not worth the fight - wait unless we have user contact wuttke
17:55 Bug #1413 (Resolved): polyhedra won't react to ex-post parameter variation
Solved in 5f3e7a72: things are now precomputed upon parameter change. Broken tests will be restored under issue #1294. wuttke
17:42 Revision 5f3e7a72: Merge branch 'precompute' into develop:
- Form factors of polyhedron and polygonal prism now compute vertex positions etc
upon call of onChange().
- Parame...
wuttke
17:42 Revision cf3bf76f: Merge branch 'develop' of apps.jcns.fz-juelich.de:BornAgain into develop
wuttke
17:41 Revision 3a496e9b: Moved call of onChange() from ParameterPool to RealParameterWrapper.
wuttke
16:57 Documentation #1412: avoid horizontal scrolling in code examples
two things to do:
* decrease font size by one; determine maximum number of characters per line
* rework examples to...
wuttke
15:43 Revision 69dd4c79: Formfactor computation reacts to parameter changes, using precomputation. This...
Missing tests will be reactivated or written under issue 1294. wuttke
15:42 Revision 0d7fb801: Updates in ROOT minimizers
pospelov
15:34 Revision c758cfbd: prism3,6 should work, but something is wrong with my ad-hoc test
wuttke
15:02 Revision d2d029cf: Unify parameter names Length, Radius -> BaseEdge
wuttke
14:04 Revision 04a6cbd7: Dodecahedron reacts to parameter change. This almost solves bug 1413. Still TO...
wuttke
12:53 Revision f85ac851: Merge branch 'ModelMapper' into develop
pospelov
12:52 Bug #1370 (Resolved): Fix numerous "features" introduced by latest major GUI refactoring
With this the GUI "ParameterizedItem" refactoring is over. Old functionality is restored.
* It's not possible to o...
pospelov
12:38 Revision ded49472: onChange() implemented in FormFactorDodecahedron; tests for other polyhedra fail
wuttke
12:29 Revision b92a6267: Fixed mouse tracking for ColorMapPlot when switched to projections mode, so st...
pospelov
11:42 Revision cc5f03a5: Gentle way of clearing JobModel to properly notify dependent widgets
pospelov
10:49 Revision 135ca0ac: Fixed bug in RealTime widget (app crashes when remove all jobs from list and t...
pospelov
09:54 Revision 30bea193: Constatness of subscriber in ModelMapper
pospelov
09:37 Revision 85f9bf83: FitKernel is back to unique_ptr for uniformity.
pospelov
09:31 Revision 6171f992: corrections. Now ready for implementing the actual precomputation.
wuttke
08:09 Revision a4967a0e: store debugging version as an example for python introspection: print all meth...
wuttke

20 Apr 2016

23:35 Revision dedbf28a: + test script
wuttke
23:32 Revision 5d3781e8: Implemented onCheck(). setValue(..) no longer returns bool, but throw in case ...
Replaced another typedef (shared_ptr<ISampleBuilder>). wuttke
20:58 Revision 94d81ce0: getParameters() and printout functions restored
wuttke
20:38 Revision 3ea0e7e5: ParameterPool now has an attribute IParameterized* m_parent.
This will allow us to notify the parent about changed parameter values.
Accompanying changes and problems:
- The defa...
wuttke
17:57 Revision 095f0084: expand parameter_t (no typedef as alias for lengthy class names, except perhap...
wuttke
15:53 Revision d2c5230a: Celnup in commented code
pospelov
15:37 Revision 78f237c4: All widgets switched to mapper belonging to an item
pospelov
13:54 Revision c6bcf02f: Merge branch 'precompute' into develop - before starting to really work on the...
wuttke
13:01 Revision bcb6aa56: m_fit_kernel -> m_kernel, to unify usage, which differed between the two variants
wuttke
12:56 Revision ebf401ce: Exclude size_t from doxygen collaboration diagrams
wuttke
12:23 Revision a9b11dde: Refactored tests for model mapper.
pospelov
10:24 Revision e31c3686: Unsubscription machinery is implemented for ModelMapper
pospelov
10:16 Revision 773cf3e1: Unify comment style
wuttke
08:56 Revision cb31d50a: IMinimizer: keep catalogue out of interface
wuttke
08:24 Revision 870c3dd0: minor edits, while reading ...
wuttke

19 Apr 2016

23:16 Revision 39084170: minor edits, while reading ...
wuttke
23:14 Revision 7e0c74d4: Merge branch 'develop' of apps.jcns.fz-juelich.de:BornAgain into develop
wuttke
22:00 Revision 118a2328: corrections
wuttke
21:47 Revision 1d692ffa: corr
wuttke
21:44 Revision 481f548a: Merge branch 'develop' of apps.jcns.fz-juelich.de:BornAgain into develop
wuttke
21:43 Revision cae1993e: added AttLimits.cpp (was missing in previous commits)
wuttke
21:24 Revision 637fa1ae: forward class declarations back to top of file, except for TransformFromDomain.h
wuttke
19:18 Revision 95d41c59: rm unused include
wuttke
19:13 Revision 2ac1af67: Merge branch 'precompute' into develop
wuttke
19:11 Revision b1e1ace4: Merge branch 'develop' of apps.jcns.fz-juelich.de:BornAgain into develop
wuttke
19:06 Revision a7d40bf6: Made clear that FitSuite is pointer to implementation FitKernel.
Removed inclusion of FitKernel.h from FitSuite.
This required one nontrivial change: The pointer-to-implementation
mu...
wuttke
18:17 Revision c668c692: Comments in FitKernel.h
wuttke
18:07 Revision 786620f1: Comments, rm unused getSTLvector, prepare for removal of include FitKernel fro...
wuttke
17:13 Revision 83db45d1: Set of standard signals added to ModelMapper
pospelov
16:35 Revision 035eeac2: More accurate ModelMapper usage accross all QWidget's
pospelov
15:47 Revision db1b24c0: Merge branch 'GUIFixes5' into develop
pospelov
15:44 Revision 3805b439: Protection in ModelMapper to stop signaling if own item is deleted
pospelov
15:06 Revision 4e76318b: Correct technical language: .h headers do not »define«, they »declare«
wuttke
15:00 Revision 0ae004c4: improve comments
wuttke
14:20 Revision d4522f1f: minor changes; add Doxyfile.long
wuttke
14:04 Revision 67b7e754: Message service restored, minimal supported project version introduced.
pospelov
13:42 Revision bc59df88: correct doxygen entry @file (rm inc/, src/)
wuttke
13:36 Revision 572eeb56: simplify parameter registration
wuttke
12:20 Support #852: Make GUI available at JCNS servers
Answer from Josef Heinen 29mar16:
* BornAgain is installed on the Macs
* This seems not to include the Mac notebo...
wuttke
11:34 Documentation #1414 (Backlog): regenerate form factor images in manual
- in k coordinates
- choose q along more and less directions
wuttke
09:51 Revision 0eb179f0: SampleViewAligner repaired
pospelov
09:30 Revision d91e2b6b: Tooltips restored in ComponentEditor
pospelov

18 Apr 2016

20:05 Bug #1413 (Archived): polyhedra won't react to ex-post parameter variation
needs to be corrected, and test mus be written wuttke
17:57 Revision 16b3c90c: Modifications in ModelMapper to track onSiblingsChange
pospelov
16:57 Documentation #1412 (Archived): avoid horizontal scrolling in code examples
Some Python examples have some really long lines.
To read them, one needs to scroll horizontally.
But some examples...
wuttke
15:35 Revision 3b50974b: Removed unused GUI code
pospelov
15:30 Revision 5d170b53: GUI unit tests are reenabled
pospelov
15:28 Revision 2ee3c484: Fix in component editors to update on FlagRole change (enable/disable properties)
pospelov
15:15 Revision 0119b2bb: Merge branch 'GUIFixes4' into develop
pospelov
15:15 Revision 2c8ebffa: Fixed group property is finally removed from SessionItem family
pospelov
14:47 Revision 51911926: ditto for Icosahedron
wuttke
14:37 Revision 06490c94: All SessionItems switched to new addGroupProperty method
pospelov
14:32 Revision 537e4f33: Better ff examples for Dodeca
wuttke
13:59 Revision 48876db7: Fixed group property is removed from BeamItem
pospelov
13:39 Revision 7415be8c: Fixed group property is removed from IntensityDataItem
pospelov
13:09 Revision 1d521c28: Fixed group property is removed from RectangularDetectorItem
pospelov
12:54 Revision 1183e752: Fixed group is removed from SphericalDetectorItem
pospelov
12:47 Revision 12f19ad7: remove unused figures
wuttke
12:44 Revision 14d9f254: MaterialItem is refactored to gret rid from FixedGroupProperty
pospelov
12:40 Revision 5e9684d4: rm unused old form factor figures
wuttke
11:39 Revision 8bac253e: ParticleItem's position is refactored to get rid from FixedGroupProperty
pospelov
11:13 Revision 0ac16cf6: pass complex_t by value
wuttke
11:09 Revision 34e19a7e: SessionModel machinery now allows to add items like VectorItem without FixedGr...
pospelov
10:38 Revision c2acb169: bugfix: pass by reference where value is purposedly changed
wuttke
10:24 Bug #1411: FindGSL version test fails under cmake-3.0 => BornAgain does not build on Debian Jessie
Let's not even attempt to repair the version testing. First resolve 1404, then remove the version testing from FindGSL. wuttke
09:48 Bug #1411 (Rejected): FindGSL version test fails under cmake-3.0 => BornAgain does not build on D...
The failure seems to be related to the recent changes in the file cmake/modules/FindGSL.cmake
The error message:
...
ganeva
10:11 Revision 5053449d: pass *vector_t by value
wuttke
08:28 Feature #1399 (Resolved): Implement form factors for dodecahedron and icosahedron
wuttke
 

Also available in: Atom