Activity
From 09 May 2016 to 07 Jun 2016
07 Jun 2016
- 22:52 Revision 78594ad7: Merge branch 'analyfutests' into develop
- 22:52 Revision c26c45c8: copy edit
- 22:47 Revision 6736ce00: corr (CMakeLists.txt for new subdir was missing)
- 18:35 Revision c853053d: Merge branch 'analyfutests' into develop: Resolved #1452, parallel ctest (-j<n...
- 18:32 Revision e293cc1e: copy editing and little simplification
- 18:18 Revision 66667254: Final cleanup in JobViewDocks
- 18:12 Bug #1452: PySuite tests fail when executed in parallel
- For the record: cause of the bug were constant file names (Py script and simulation output) in PyScriptFunctionalTest...
- 18:10 Bug #1452 (Resolved): PySuite tests fail when executed in parallel
- Solved in [analyfutests 3aee823], soon to be merged into develop.
- 18:08 Revision 02883ec3: Toggling of jobSelector is moved down to JobViewDocks
- 18:04 Revision 3aee8239: For functional tests with subcomponents (i.e. FormFactors and Basic2DParaCryst...
- 17:56 Revision 619ab774: JobView's resetLayout now is handled by JobViewDocks
- 17:45 Revision 7ee58072: JobView's activity selection is moved to JobViewDocks
- 17:12 Bug #1455 (Resolved): RuntimeError if CrossCorrLength=0
- Fixed in 724fe9f8d2e64f0e8d82013f5f36170a2f7a6351
- 16:49 Bug #1455 (Archived): RuntimeError if CrossCorrLength=0
- BornAgain Python script exits with the "RuntimeError: Attempt to set crossCorrLength to zero" message if the cross co...
- 17:11 Revision 724fe9f8: Merge branch 'crosscorrlength' into develop
- 17:10 Revision 5e1c3767: Fixed bug in setting cross correlation length of multilayer
- 17:03 Revision 5fb5a35e: New JobViewFlags to hold common enums in single place.
- 16:36 Revision f4f08a11: merge code into ICloneableRegistry::getNames()
- 16:26 Revision d8945232: Replaced MathFunctions::isinf with std::isinf
- 16:18 Revision b228c7ec: Replaced MathFunctions::isnan with std::isnan
- 16:08 Revision 8d3fab40: JobActivityStatusBar now requires MainWindow for initialization.
- 16:02 Revision 73143d56: copy edit and simplify ...
- 15:45 Revision 213a3b35: copy edit and simplify, while reading
- 15:44 Revision 20d36265: New JobViewDocks to separate docking logic from JobView
- 14:32 Refactoring #1454 (Resolved): Export to Python: generated scripts should not require "from bornag...
- Automatically generated scripts should teach best practice in BornAgain/Python usage. Therefore:
import bornag... - 14:22 Revision 59cd9b77: split directory: TestPyDump for the Core-to-Python export, TestPyCore for Pyth...
- 14:09 Revision 64dfd1b5: copy editing
- 13:14 Revision 045090ce: reenabled unit tests
- 13:05 Revision ba086953: Merge branch 'ImportDataWidget' into develop
- 12:58 Revision 85f33e09: Returning mainwindow to initial state before the merge
- 12:03 Revision 7e50b89b: Further simplify PyScriptFunctionalTest: set m_pyscript_filename from name; us...
- 11:17 Revision 0781cace: simplify PyScriptFunctionalTest
- 10:44 Revision b100be78: missed files
- 10:44 Revision 9fa89f6a: FitActivityPanel is refactored to rely on ItemStackPresenter
- 09:37 Revision 05c5381d: while reading ...
- 09:03 Revision b5aee8eb: Bugfix in real data selection combo.
- 08:50 Revision 44f5b09a: Made FunctionalTestComponentService::getFunctionalTest() pure virtual instead ...
- 08:41 Revision b016e807: rm unused declarations
- 08:34 Revision 545c01da: Merged common code from *Suite into registry. Made info a pointer.
- 07:44 Revision 1d1143f7: merge (fit|gui)_functional_tests.* into *Suite
- 07:03 Revision 0c4dc3a8: New directory Core/TestMachinery.
- Remove empty line from Googletest output.
06 Jun 2016
- 17:46 Revision 617db4e1: Real data for fit is finally taken from RealDataModel
- 17:31 Revision 033fcc51: STILL BROKEN
- 16:48 Revision 9763edd8: option -DSKIP_UTESTS to accelerate cmake configuration
- 16:38 Revision e4a927bd: Cleanup in SessionModel to get rid fromtopItemMap and family
- 16:16 Revision b8289f39: Refactored the way sample/instrument selected
- 13:41 Revision 8f63863b: ProjectManager dependency is removed from SimulationSetupWidget
- 13:37 Revision 97c5ccf4: Sample/instrument selection logic is extracted from SimulationSetupWidget into...
- 12:38 Revision 0797e6ce: BROKEN: mv futest machinery from Core/StandardSamples/ to Tests/FunctionalTest...
- 11:32 Revision c824e8e5: IntensityData projectFile's saving/reading is refactored for both JobItem and ...
- 10:50 Revision e2ff26c8: merge core_functional_tests into CoreSuite
- 10:44 Revision dcfff64f: merge pyscript_functional_tests into PySuite.cpp
- 10:39 Bug #1452: PySuite tests fail when executed in parallel
- I'm investigating ..
- 09:54 Bug #1452 (Resolved): PySuite tests fail when executed in parallel
- ctest -j4 yields e.g.
The following tests FAILED:
77 - PySuite/FormFactors (Failed)
78 - P... - 09:41 Revision b426a0cd: correct missing merge (truncate negative convolution results)
- 07:50 Documentation #1451: update to Drupal 8
Suggested order of upgrade:
* Install drupal locally
** with Bitnami Drupal stack https://bitnami.com/stack/dr...
05 Jun 2016
- 23:30 Revision c546094f: Merge branch 'thisandthat' into develop
- 23:28 Revision 669a9f57: Merge branch 'makecheck' into develop
- 23:28 Revision 32968dbb: Merge branch 'develop' of apps.jcns.fz-juelich.de:BornAgain into develop
- 23:27 Revision ffe84046: Merge branch 'makecheck' of apps.jcns.fz-juelich.de:BornAgain into makecheck
- 22:03 Revision 0678324a: New tests: example and code line length
- 21:16 Revision 38dfae37: edit doclines in getSample() in Py examples; limit lines to 85 chars
- 18:53 Revision 668af323: No Core source file longer than 100 chars.
- 16:45 Revision ff595272: no Core source line longer than 120 chars
04 Jun 2016
- 18:45 Revision 1b0e0796: no C++ source line longer than 180 chars
- 18:19 Revision f30fc001: count-line-length with variable limit given as first argument
- 18:15 Revision 8c4d212e: enable_testing() -> top-level CMakeLists, as recommended by CMake doc
- 18:15 Revision 0cf55ccc: enable_testing() not needed below top-level
- 18:15 Revision 7d29f05f: correction, to repair 'make check'
- 18:15 Revision 58ac180b: destination_runtime_configs -> BUILD_AUTO_DIR
- 18:15 Revision 5f958328: get_filename_component -> separate cmake module
- 18:15 Revision 599aba62: split directory: generic CMake modules vs BornAgain-specific CMake modules
- 18:15 Revision e13dfc72: cmake: shorter directory names, clearer hierarchy
- 18:15 Revision 5efbb8ee: renamed BornAgainMacros.cmake -> FuTestMacros.cmake
- because that's all the file is about
- 18:15 Revision 62c14b01: GoogletestWrapper generates either compile-time or post-build test.
- 18:15 Revision 7fd8cb52: outcomment target property install unit test to binary/lib
- 18:15 Revision 9cb95710: bin/*Suite are now build under target 'all'
- TODO: - also build TestCorePQS
- restore EXCLUDE_FROM_ALL - 18:15 Revision 9f6e9351: TestCorePQS runs under ctest (="make check")
- 18:15 Revision ff67a6ad: rm debmsg
- 18:15 Revision 27dc2f77: try CTest
- 18:15 Revision ae67e096: revert from include(CTest) to enable_testing() [had no advantage]
- 18:15 Revision b7262554: off-topic: demonstrate removal of unused func_arg
- 18:14 Revision 44e1e340: update and simplify line-count script; still not to be taken literally
- 09:01 Revision 623569d6: revert from include(CTest) to enable_testing() [had no advantage]
03 Jun 2016
- 20:59 Revision 389fcb1f: try CTest
- 20:14 Revision cc2115c2: off-topic: demonstrate removal of unused func_arg
- 19:38 Revision bdede291: rm debmsg
- 19:27 Revision 22c2c373: TestCorePQS runs under ctest (="make check")
- 19:20 Revision 1d51d3c3: bin/*Suite are now build under target 'all'
- TODO: - also build TestCorePQS
- restore EXCLUDE_FROM_ALL - 16:46 Revision 04106215: outcomment target property install unit test to binary/lib
- 16:36 Revision 0d3ea2dd: On the way to refactor IntensityData saving
- 16:05 Revision 0be8532d: GoogletestWrapper generates either compile-time or post-build test.
- 15:59 Bug #1449 (Resolved): Apply detector resolution function can give negative results
- Negative values arise as a result of the finite precision in the fft's. In special cases, as in the given example, wh...
- 11:15 Bug #1449 (Archived): Apply detector resolution function can give negative results
- Reproduce:
use HexCylinders.py from gisas/support/015_AnatolyBerezkin and add the following line to create_simulatio... - 15:51 Revision 86dc5205: Merge branch 'det_resolution' into develop
- 15:50 Revision 0f7636ee: Truncated negative values from convolve with fft
- 15:32 Revision 207cb1a9: renamed BornAgainMacros.cmake -> FuTestMacros.cmake
- because that's all the file is about
- 14:35 Revision 3f5befe0: load/save nonXMLData logic moved to ApplicationModels
- 14:10 Revision 88c1e786: Remove commented code
- 13:52 Revision dcc868d7: cmake: shorter directory names, clearer hierarchy
- 13:29 Revision 4d2f27e2: Break lines that are too long
- 13:28 Revision 2ca1c685: Remove commented code
- 13:03 Revision a56fbd10: split directory: generic CMake modules vs BornAgain-specific CMake modules
- 12:56 Revision d74b2126: ReadFrom, writeToXML logic is moved from ProjectDocument to ApplicationModels.
- 12:48 Revision 595cd9ba: get_filename_component -> separate cmake module
- 12:38 Revision 350ecefa: destination_runtime_configs -> BUILD_AUTO_DIR
- 12:26 Revision 78afbcc4: correction, to repair 'make check'
- 12:19 Revision 87e0a94f: enable_testing() not needed below top-level
- 11:53 Documentation #1437: Release requirement: Update example scripts
- Under Drupal 8 (#1451), we might use RESTful services, described at https://drupalize.me/blog/201401/introduction-res...
- 11:52 Documentation #1451 (Rejected): update to Drupal 8
- especially if we want to use RESTful service to automatize update of Python example scripts, #1437
- 11:24 Revision 85d0cfda: Selection logic in IntensityDataView, bunch of sizeHints
- 11:09 Revision e7bbdc35: enable_testing() -> top-level CMakeLists, as recommended by CMake doc
- 10:48 Revision 901e907d: Code that is common to Core and Fit moved to new cmake module
- 10:16 Revision d15a01a9: mv ValidatePythonInstallation to separate cmake module (unused?);
- save one line in after-installation message
- 09:24 Bug #1448 (Rejected): Remove html directory from source tarball
* It looks like our current 1.5.1 tarball contains unnecessary 'html' directory with whole content
** Our previous...- 09:22 Configuration #1150 (Sprint): Improve release script procedure
- 08:57 Configuration #1447 (Archived): Migrate to GitHub
* Merging to the develop should be allowed only after successful builds on build server- 08:26 Revision c39ba1e9: Working on RealDataEditor widget
02 Jun 2016
- 00:11 Revision 4b2a1259: + tool to report too long lines, to trim drupal examples
- 00:11 Documentation #1412: avoid horizontal scrolling in code examples
- develop 4b2a125 provides tool dev-tools/code-tools/count-line-length.py
- 11:24 Documentation #1412 (In Progress): avoid horizontal scrolling in code examples
- Clue from stackexchange: syntaxhighlighter style can be overwritten in our theme's CSS: in
/www/apps/drupal/sites/... - 19:10 Documentation #330: Core: beam propagation: take care of kz=0 case appropriately
- no hope that I'll be free for this any soon
- 19:08 Envelope task #1402 (Archived): cmake tasks (OS independent)
- no tasks left open
- 19:07 Revision e0864962: Correction, and improved file header comment
- 18:21 Revision 58d87dfd: Merge branch 'develop' of apps.jcns.fz-juelich.de:BornAgain into develop
- 18:18 Revision f1c3b67a: plot_utils/__init__.py and plot_utils.py work both, but the latter is easier.
- 17:50 Revision eb2be03f: Load of intensity data into realDataItem implemented.
- 17:46 Revision dc950d58: mv python-setup -> python; frombin... -> thisbornagain.
- 17:25 Revision ec6debc4: Fix bug in FormFactorGauss
- 16:44 Revision 88bb05c7: New ImportDataAssitant responsible for files import, import directory is saved...
- 16:09 Revision 2db61815: mv python-setup -> python
- 16:05 Revision d60c91c2: assemble all __init__ copy commands in Core/CMakeLists
- 16:01 Revision 60a5cf39: rm unused variable
- 15:53 Revision 2b4f7fda: merge Apple and non-Apple code; rm inconsequential copy command.
- 14:45 Revision edc831bd: New AppSvc for common access to key GUI components.
- 14:33 Bug #1070 (Backlog): Unix should install to /usr/local/lib, not to versioned subdirectory
- destination_libexec: libexec/ is highly nonstandard; executable should go to bin/
- 12:58 Revision f122795c: Restore auto-generated stuff to git repository.
- 12:56 Revision a1008b26: Use standard CMake command to make directory, instead of system call
- 12:16 Revision fb54442b: rm CMAKE_RUNTIME_OUTPUT_DIRECTORY_DEBUG|RELEASE (apparently unused)
- 11:44 Revision afed21ac: Fixed problem with python binding generation (on system with numpy 1.8.2)
- 11:18 Revision c0e549be: WRAP_DIR needed outside auto-generation
01 Jun 2016
- 22:53 Bug #1439 (Resolved): put PythonAPI under CMake control
- Resolved in 95d1a38f.
- 10:58 Bug #1439 (Sprint): put PythonAPI under CMake control
- I'll try in branch cmake
- 22:51 Revision 95d1a38f: Merge branch 'cmake' into develop: PythonAPI fully under CMake control, tempor...
- 21:29 Revision 2556f885: split compound add_custom_command to keep intermediate files accessible
- 19:45 Revision 41fd1673: Doxyfile generation now also in wrap / tmp / auto scheme
- 17:22 Revision d8ef2dbe: swig parametrization now in Wrap/, swig output in auto/;
- simplified tweaks.py and Core/CMakeLists.txt
- 16:06 Revision efcedae9: Bugfix with correct widget removal in the case of removed item
- 15:54 Revision 58c5500c: Add data/remove data logic are implemented
- 15:11 Revision b7218afe: New set of icons for ImoprtDataView
- 14:16 Revision eaf0de80: New ItemStackPresenter for uniform treating of SessionItem's stacked widgets.
- 13:53 Revision 3ec1c772: mv dev-tools python-setup -> Wrap/
- 13:21 Revision f2bc389a: mv dev-tools/swig -> Wrap/swig
- 12:40 Revision 197046b2: Make libtiff required, unless flag is set to -DBORNAGAIN_TIFF_SUPPORT=OFF.
- libtiffxx is also required.
- 12:19 Revision 0ccda90e: exceptionally, auto-indent an important and complex file
- 11:27 Revision cec62903: status messages from CMake: more uniform, more compact
- 10:59 Revision 20949399: Merge branch 'cmake' into develop: pod2man under CMake control, result put to ...
- 10:55 Envelope task #424 (Archived): === PythonAPI ===
- no subtasks left open
- 10:52 Feature #975 (Resolved): man page should be built at release time
- 10:51 Feature #975 (Sprint): man page should be built at release time
- Resolved in 8f51e90.
- 10:50 Revision 8f51e90a: Presence of pod2man now correctly checked by CMake.
- This concludes the resolution of #975.
- 10:38 Revision f9c325fc: Merge branch 'cmake' of apps.jcns.fz-juelich.de:BornAgain into cmake
- 10:38 Revision be58ce90: mv man -> Doc/
- 10:38 Revision 6ebf714f: Starting directory auto, to receive auto-generated code.
- Works for man page.
- 10:38 Revision 542d7b82: corr PythonAPI/README
- 10:30 Revision 25572531: Merge branch 'fftest' into develop: corrections to make it work on other platf...
- 10:29 Revision 21c00e81: Merge branch 'fftest' into develop:
- improved numeric accuracy
- 09:50 Revision f94e30cf: Test for presence of pod2man. This partly resolves #975.
- 09:38 Revision dd8ef171: rm remainders of APP
- 09:04 Revision c8fbc98c: now special treatment if any one of u, v1, v2, v is zero
- 08:46 Revision 2fde6d7e: simplify notation in contrib(): m+1 -> M
31 May 2016
- 18:31 Revision 82865617: v=0 broken, rederive factors!
- 17:51 Revision 0e788499: try to restore v=0 case - spectest fails
- 17:45 Revision 6767f7bf: New RealDataModel to hold imported real data
- 17:00 Revision 5044a439: New placeholder widgets for RealData selection/editing
- 16:14 Revision 59e5f2b9: Majority of toolbars refactored to rely on StyledToolBar
- 14:42 Revision 4b802981: New ImportDataView is implemented
- 13:56 Documentation #1437: Release requirement: Update example scripts
- From https://www.drupal.org/node/811950
> There is very rarely any justification for directly interacting with the d... - 12:58 Documentation #1437: Release requirement: Update example scripts
- There is no simple way to automatize this. We may need to write a script that directly accesses the MySQL data base.
- 12:21 Revision d915d665: Version number of this develop branch set to 1.5.99, as agreed in meeting today.
- 12:20 Documentation #1282: Drupal: unique form of persistent page URLs
- There is a module that auto-generates URLs from titles - but we might prefer shorter names ...
- 11:48 Documentation #1282: Drupal: unique form of persistent page URLs
- The explicit form is preferred. It can be set under Edit > URL path settings.
- 11:47 Bug #900 (Rejected): Custom form factors in python do not work with multithreading
- as agreed in meeting
- 11:40 Feature #975: man page should be built at release time
- Implemented in branch cmake, commit e33ded6da34, except for testing presence of pod2man.
- 11:39 Feature #606: Restore automatic doxygen API generation
- make clear that this concerns the master branch
- 11:36 Bug #1070: Unix should install to /usr/local/lib, not to versioned subdirectory
- Discussed today. No fundamental objections - but beware of possible side effects:
* MacOS
* header files, C++ examp... - 11:31 Documentation #1104 (Rejected): don't use version-dependent URLs in the online docs
- Much simpler solution is already implemented: use a few variables in Drupal.
To set them: Drupal > Admin > Structu... - 10:16 Revision aad92c6f: corr PythonAPI/README
- 10:14 Revision e33ded6d: Starting directory auto, to receive auto-generated code.
- Works for man page.
- 09:46 Revision f9cd8c4e: mv man -> Doc/
30 May 2016
- 22:18 Refactoring #1440 (Archived): cover Python examples by functional tests
- Test should check that all examples execute without failure, and that they produce about the same detector image as b...
- 16:21 Bug #1439 (Resolved): put PythonAPI under CMake control
- Currently, when API has changed, one needs to rm Core/PythonAPI/lib*. We should put the generation of these wrappers ...
- 16:18 Refactoring #1432: final polish of polyhedral form factor
- rel err now <1e-11
- 16:15 Bug #1423: == eliminate warnings ==
- warnings come from cmake-called processes, but not from CMake
- 15:15 Documentation #1412: avoid horizontal scrolling in code examples
- no clue how to change the font size -> http://drupal.stackexchange.com/questions/202612/
- 13:41 Refactoring #1071 (Resolved): Example scripts: No global import from Python module bornagain
- Resolved in 3b5d014b0, using the regular expressions appended below, plus very little hand editing.
All scripts in... - 13:34 Refactoring #1071 (Sprint): Example scripts: No global import from Python module bornagain
- 13:37 Revision 3b5d014b: Python examples no longer 'from bornagain import *', but 'import bornagain as ...
- This resolves #1071.
Manually repaired AllFormFactorsAvailable.py. - 13:33 Documentation #1437 (Rejected): Release requirement: Update example scripts
- During a sprint, examples are updated in Examples/python/...
Upon release, they need to be moved to the Drupal sit... - 13:19 Bug #1436 (Archived): repair ex06_Miscellaneous/AccessingSimulationResults.py: type object 'IHist...
- broken after past refactoring
$ p2 AccessingSimulationResults.py
Traceback (most recent call last):
File "Acc... - 13:01 Revision 7c770f83: prepare removal of global import from bornagain
- 11:13 Documentation #1360: reequilibrate hierarchy levels in online docs
- no objections raised, so we go for it
- 11:01 Bug #900: Custom form factors in python do not work with multithreading
- Suggestion: Declare this a feature, update the documentation of CustomFormFactor, and close this issue. Serious work ...
- 10:18 Bug #1070: Unix should install to /usr/local/lib, not to versioned subdirectory
- probably strong interdependence with #1256
- 10:16 Bug #1070 (Rfc): Unix should install to /usr/local/lib, not to versioned subdirectory
- 10:12 Documentation #1104 (Rfc): don't use version-dependent URLs in the online docs
- 09:57 Revision 98e404b5: rm duplicate typedef
- 09:51 Revision 217f737f: Merge branch 'fftest' into develop: rel err now <1e-11.
28 May 2016
- 19:01 Revision ecf8e426: qpalim=3e-2, qlim=1e-2, symtest<3.8e-12, spectest<7.5e-13, cont<88.61e-12
- 12:25 Revision 91c8e967: qpalim=1e-1, qlim=1e-2 => symtest<4e-12 spectest<7.5e-13 cont@sh9<8.55e-13
- 11:52 Revision 0b61674a: Corr: inconsistently, the fixed qperp term was still present in contrib for v=0;
- outcommented this case.
Big improvement, q expansion works now up to 1e0 and further.
Test case sym::Cone6 split in t...
27 May 2016
- 13:44 Revision 580eb7fe: Last fine-tuning: qlim=8e-5, qpalim=1.2e-2 => symtests<2.6e-11, spectests<1.8e...
- 10:10 Revision 6bfd74be: start point for today
26 May 2016
- 19:06 Revision f54eda5e: make debmsg'es permanent; make test shape 9 a nontrivial AnisoPyramid
- 18:28 Revision bb231853: with q_lim=8e-5, symtests<2.6e-11, spectests<1.7e-11
- 17:41 Revision 89097c80: in innermost q expansion, expand further to separate constant term qperp*R
- 15:23 Revision d87af84f: Corrected Py binding (TYpes.h -> VDouble, Complex);
- improved sum over edges in q expansion.
25 May 2016
- 19:13 Revision 6555bde2: exp_I and mul_I in FFPolyhedron
- 18:04 Revision 1644cf21: using mul_I and exp_I throughout the numeric code
- 17:24 Revision af1d9720: renamed Types.h -> Complex.h
- 17:12 Revision 16e6b232: VDouble.h split off from Types.h; using size_t removed from Types.h
- 16:53 Revision 9ce208d2: rm include<cstddef> from Types.h
- 16:31 Refactoring #1296 (Resolved): update internal information about performance tests
- Information in README files updated.
Wiki main page provides links to README files. - 16:24 Revision ece17d6e: + comment
- 16:09 Revision 6b5c0cc5: Notes on Linux tool perf
- 16:06 Revision 534eafae: explanations from wiki -> README files
- 15:38 Feature #1290: === Core: framework ===
- To keep the code base readable and maintainable
- 14:45 Revision c5d0ab76: convert perf_log to YAML (not pursued to a satisfactory end)
- 12:55 Revision a8d238d3: repair test_performance.py
- 12:32 Revision 3b2df3cf: Merge branch 'fftest' into develop
24 May 2016
18 May 2016
- 16:23 Revision ff57c53a: Merge branch 'FitParametersProxy' into develop
- 16:22 Revision 14dbf217: MultiLayer within JobItem now always has fixed name
- 15:51 Revision 4f4812bb: mainwindow is returned to default state
- 15:43 Revision 85fcfea1: Selection in fit parameter tree is propagated to tuning widget
- 15:20 Revision 6f5b4ade: Cleanup in the Addams family
- 15:00 Revision f563c816: Cleanup in overlay label widgets
- 14:54 Revision 1ddc4b80: Finally info label appears/disappears when tree is empty
- 11:23 Revision 37186e28: New controller widget to palce overlay labels on top of abstract scroll areas.
17 May 2016
- 18:03 Revision b5414322: New experimental InfoLabelWidget to display messages on top of arbitrary viewp...
- 16:58 Revision 73f35421: Tooltips for FitParameterItem tree columns
- 16:27 Revision 68bbab64: FitParameterItem now takes limits attributes from first ParameterItem being dr...
- 15:40 Revision e1a97103: Drop of ParameterItem to empty tree, cleanup in FitParameterWidget
- 14:13 Refactoring #1428 (Backlog): Compactify code that handles parameters (use abstract mechanism inst...
- agreed in meeting today
- 14:13 Refactoring #1428: Compactify code that handles parameters (use abstract mechanism instead of tre...
- By convention, all lengths are in nm, all angles are internally in rad. Therefore, we only need the physical dimensio...
- 14:10 Refactoring #1430 (Resolved): Consider moving FormFactor unit tests to a single functional test
- The main concern will be resolved per issue #1433.
Renaming of subdirectories will follow later, when Core/ is res... - 13:59 Refactoring #1433 (Resolved): move massive numeric tests under 'make check' / 'ctest'
- to be done when the polyhedral FF is stable (#1432)
- 13:56 Refactoring #1432 (Rejected): final polish of polyhedral form factor
- * specific tests for frusta that are true pyramids
* exact treatment of vertices that coincide
* -improve edge sum ... - 11:42 Documentation #1431 (Resolved): simplify cross-referencing using package cleveref
- 11:12 Revision c2dc3592: New mime types in SessionXML and minor renaming
- 11:01 Revision 08f30e3f: Blocked drag operation in the case of ParameterLabel item
- 10:45 Revision 23d3a229: Cleanup in ParameterTuning* family
- 10:43 Revision c5f1d8c1: Merge branch 'fftest' into develop: corrected termination criterion for series...
- 09:59 Revision 76fa799e: Renaming in ModelTuningDelegate and co
- 09:39 Revision 071ffc34: ParameterTuningModel is introduced to encapsulate parameter tuning/dragging ac...
- 09:32 Revision c207cc4e: make FormFactorPolyhedron pure virtual
- 08:56 Revision aa87806d: SessionModel modified to allow copy action
16 May 2016
- 17:49 Revision 3683c7b5: First version of dragging from ModelTuningWidget
- 16:51 Revision 13b0d653: FitParameter link drag/drop within FitParameterTree is working
- 16:16 Revision 7dd1cf4a: First drag/drop attempts in FitParameterAbsModel
- 14:49 Revision 21707625: Removal of FitParameterItemLinks from the tree is implemented
- 14:26 Revision 0db5c8e4: todo note
- 14:21 Revision 6739816f: move sym_Ci to Topology
- 14:17 Revision 0b910234: Method for getSelectedParameterItem moved to ModelTuningWidget
- 14:06 Revision 5110b34f: continuity test requires revert of q_lim from 1e-4 to 1e-5; this requires rela...
- 13:50 Revision 212f7e76: Delete event filter installed to fit parameter tree
- 13:47 Revision 9957968e: Further reduction of test limits
- 13:32 Revision f38c51cc: Stricter criteria in spec and sym tests
- 13:20 Revision ebb4ae38: FitParameter's min/max now of grey color if not editable
- 13:11 Revision f29c3e2d: Improved summation now also for q expansion.
- 12:51 Revision ac9f5cee: merged qpa expansion code for prism and others; new termination criterion now ...
- 12:50 Revision 2e275c4e: Updated logic on fit parameter type change
- 12:17 Revision 92c343b6: improved termination criterion for qpa expansion, improves worst-cast continui...
- 11:40 Revision 4ef78262: revert Kahan (no advantage)
- 10:11 Revision 0a795c5e: try Kahan summation algorithm in edge_sum_ff => no advantage, it seems
15 May 2016
- 12:29 Revision 40ae2457: stricter limits for some more tests ..
- 12:21 Revision 6ca4c843: much stricter FormFactorBasicTest
- 12:14 Revision 547592a8: moved common factor e^iqrperp out of analytic ff2d() => breakthrough in accura...
13 May 2016
- 17:10 Feature #1238: nicer layout for newsletter@bornagainproject.org (reopened: v1.6.0 round mail stil...
- I really do not like the black topbar.
Plain ASCII would be nicer than this HTML. - 16:37 Revision c24d3df3: New mapping in FitParameterItems
- 15:42 Revision 1cdeb903: New fit parameter type introduced (fixed, free, etc) and corresponding delegat...
- 15:12 Revision 5cb77085: SessionModel technical view appearance is controlled now from main window.
- 14:57 Revision a8598891: Base of AnisoPyramid has symmetry S2. Matching test strangely broken.
- 13:53 Refactoring #1424: reduce verbosity of googletest output
- Feature request submitted at https://github.com/google/googletest/issues/771.
- 10:29 Revision 2229e6e4: Zwischenstand
12 May 2016
- 19:15 Revision 50a81263: Found test case where Re F(q) > V
- 18:45 Revision 599f83c6: BROKEN (trying to improve accuracy of 2d analytic ff)
- 18:16 Revision 70b3856a: New developer's SessionModelView will be hidden part of mainwindow on permanen...
- 17:26 Revision cf672c7d: New universal SessionModelDelegate to operate together with SessionModel
- 13:21 Refactoring #1428: Compactify code that handles parameters (use abstract mechanism instead of tre...
- So I withdraw default units from the current proposal. Are units acceptable for you?
- 13:12 Refactoring #1428: Compactify code that handles parameters (use abstract mechanism instead of tre...
- Maybe this issue should also be split: default values vs units
- 13:11 Refactoring #1428: Compactify code that handles parameters (use abstract mechanism instead of tre...
- > > It's not their responsibility.
>
> We are free to assign responsibilities to our creatures as we deem appropri... - 13:01 Refactoring #1428: Compactify code that handles parameters (use abstract mechanism instead of tre...
- So yes, you want users to get default parametrized items. OK, I accept.
> Core form factors should not have any de... - 12:38 Refactoring #1428: Compactify code that handles parameters (use abstract mechanism instead of tre...
- In GUI default values should be provided to reduce amount of clicks/typing. This allows to start a simulation with a ...
- 11:59 Refactoring #1428: Compactify code that handles parameters (use abstract mechanism instead of tre...
- The very first question then: Is it actually appropriate for the GUI to assign default parameters to newly created it...
- 11:43 Refactoring #1428: Compactify code that handles parameters (use abstract mechanism instead of tre...
- The {FF}Items need default values because the GUI needs to create them without user initialization. There is no need ...
- 11:39 Refactoring #1428: Compactify code that handles parameters (use abstract mechanism instead of tre...
- interesting consequence. why not?
- 10:57 Refactoring #1428: Compactify code that handles parameters (use abstract mechanism instead of tre...
> Each parameter should have a default value
What does it mean? "new FormFactorSphere()" becomes valid and becom...- 13:16 Refactoring #1430: Consider moving FormFactor unit tests to a single functional test
- The number 200k comes from arbitrary choices and can be changed if time is a concern.
The tests are concerned with... - 13:00 Refactoring #1430: Consider moving FormFactor unit tests to a single functional test
- I also agree that these tests conceptually do not belong to unit tests. It also obscures unit test coverage (having 2...
- 12:54 Refactoring #1430: Consider moving FormFactor unit tests to a single functional test
- My previous reply disappeared since you commented same record I was commenting.
> Why do we actually have a functi... - 12:42 Refactoring #1430: Consider moving FormFactor unit tests to a single functional test
- > [ RUN] OK is better than just [——]
Agree. Implemented in 91d8e8f5b0. - 12:36 Refactoring #1430: Consider moving FormFactor unit tests to a single functional test
- Nothing in googletest says it is limited to unit tests, let alone to unit tests in the most narrow sense. Why do we a...
- 12:31 Refactoring #1430: Consider moving FormFactor unit tests to a single functional test
- I put two issues in one, that's true. The major issue is to move Unit to Functional.
- 12:09 Refactoring #1430: Consider moving FormFactor unit tests to a single functional test
- These are two different issues:
* Move extensive ff tests from Unit to Functional?
* Don't split Core/Unit tests in... - 10:43 Refactoring #1430 (Resolved): Consider moving FormFactor unit tests to a single functional test
- I think that tests of form factor behaviour near singularity and along symmetry axes belongs to the functional tests,...
- 12:27 Revision 91d8e8f5: improve output from patched gtest.cc.
- 11:31 Revision f8e2695c: New methods in ModelMapper to notify subscribers on item deletion
11 May 2016
- 18:28 Bug #1371: presence of some boost components not checked by cmake
- Btw: testing under Debian is somewhat difficult because of the non-standard packaging of Boost. Reported at https://b...
- 17:39 Bug #1371 (Resolved): presence of some boost components not checked by cmake
- Resolved in ac0d39e, using a patched FindBoost.cmake that is to be submitted to CMake: https://github.com/rleigh-dund...
- 18:10 Refactoring #1366: Revise boost libraries usage
- Migration of regex from Boost to regex is suspended because compilers are not ready. => commit d14b964d17bb
- 17:34 Refactoring #1366: Revise boost libraries usage
- Only now enacted the deletion of boost components regex and thread in cmake/modules/SearchInstalledSoftware.cmake.
- 18:08 Revision d4423818: Experimenting with add/remove rows of FitParameterModel
- 17:54 Revision d14b964d: restore dependence on boost::regex (std:regex not supported by gcc 4.8)
- 17:37 Revision ac0d39ed: Include patched FindBoost.cmake from https://github.com/Kitware/CMake/compare/...
- 17:07 Revision 17552e30: FitParameterModel now re-emits signals when source model has rows inserted/rem...
- 16:38 Revision 46e56b74: Context menu to remove fit parameters in FitParametersWidget
- 15:20 Revision 97f5392f: setData now is working for FitParameterAbsModel
- 14:36 Refactoring #1424 (Resolved): reduce verbosity of googletest output
- 14:36 Refactoring #1424: reduce verbosity of googletest output
- Solved in rather unexpected way in 24204e5, namely by brutally patching gtest. Inheriting outside gtest.cc from the d...
- 14:35 Revision 1e737b43: Model cleanup before moving further
- 14:33 Revision 24204e5f: Patched gtest to suppress output from successful subtests. This resolves #1424.
- 14:31 Revision 6485acc3: Bug ifx in FitParameterAbsModel while calculating index of parent
- 14:15 Revision 740374e9: Correct column calculation in FitParameterAbsModel
- 13:46 Revision a07d3946: Bugfix in FitParameterModel preventing item links from selection in a tree view.
- 13:07 Bug #1429 (Resolved): Unit tests files are not shown in Qt Creator IDE
- Solved in 03d6c5d, using 'add_custom_target' as suggested in http://stackoverflow.com/questions/28384935/qtcreator-cm...
- 08:48 Bug #1429 (Archived): Unit tests files are not shown in Qt Creator IDE
- Files from UnitTests/TestCore directory (and similar) are not shown in "Project Structure" by Qt creator IDE. It is n...
- 13:06 Revision 03d6c5dd: Twist UnitTests.cmake to make .h sources appear in QtCreator's project tree. T...
- 12:39 Refactoring #1428: Compactify code that handles parameters (use abstract mechanism instead of tre...
- To automatically generate Python constructors,
* either use named arguments
* or make sure that parameters are orde... - 10:11 Revision ff203c51: Merge branch 'fftest' into develop
- 09:57 Revision dc72bf9b: correct/improve comments
10 May 2016
- 18:11 Revision e4ef6cab: New unit tests for FitParameterAbsModel
- 15:28 Revision 3a175205: + comment
- 15:07 Revision 8e84ab2d: Yet another experimental FitParameterModel based on QAbstractItemModel
- 14:08 Refactoring #1428 (Archived): Compactify code that handles parameters (use abstract mechanism ins...
- Each parameter should have -a default value and- a -unit- physical dimension, assigned upon registration.
This wil... - 13:34 Revision 85f90aba: New FitModelHelper containing all helper methods for hadling fit parameter items
- 13:21 Revision 4e709b18: Merge branch 'fftest' into develop: Improved ff tests; rotated prism3 and tetr...
- 12:47 Documentation #1279 (Archived): Inkscape tasks
- 12:46 Documentation #1280 (Resolved): draw tetrahedron as seen from -x
- Completed in 4003c83.
- 12:45 Revision 4003c836: Tetrahedron cuts redrawn after rotation by 30 deg. This closes #1280.
- 12:20 Revision ee8eaa84: Prism3 cuts redrawn after rotation by 30 deg
- 09:54 Revision 1f789794: Further experiments with FitParameterModel
- 09:34 Revision 7fb24a36: Start drawing rotated Prism3d.
09 May 2016
- 16:58 Revision 93067f85: Experimenting with proxy model
- 15:45 Revision ef404064: New FitParameterProxyModel to show fit parameters in 5 column view (will repla...
- 11:30 Revision 17e3b0c5: Merge branch 'JobViewRef' into develop
- 11:29 Revision 8f4ccacb: Mainwindow returned to the default state
- 09:00 Revision b5c70076: + triangle_runs
- 08:59 Revision 0d21d422: ..
Also available in: Atom