Activity

From 12 May 2016 to 10 Jun 2016

10 Jun 2016

22:31 Revision cf44658e: + class comments
wuttke
20:04 Bug #1458 (Archived): Compilation under Mac OS is broken

CMake Error: File /Users/pospelov/development/BornAgain/BornAgain/cmake/scripts/MacOSXBundleInfo.plist.in does no...
pospelov
20:02 Refactoring #1454: Export to Python: generated scripts should not require "from bornagain import *"
It's not a bug, it how it was done. Changing to "Refactoring". pospelov
19:07 Revision 4d61589a: Merge branch 'analyfutests' into develop: Further simplification of FutestSuit...
Still TODO: give clue to user where test output and reference data are located. wuttke
18:50 Revision 7d5c4f6f: corr
wuttke
18:38 Revision eb229ffc: corr wrapper
wuttke
18:37 Revision d95e748d: rm unused
wuttke
17:52 Revision 3c4ab32f: sectioning
wuttke
17:44 Revision 51a830a2: SimulationRegistry -> SimulationFactory
wuttke
17:33 Revision 77485863: There is only one subtest registry pointer left, of type IRegistry<IParameteri...
wuttke
16:29 Revision 83d75321: comments..
wuttke
16:14 Revision 83f58c97: further simplification
wuttke
16:10 Revision f70afea6: adapt choice of local / member variables to state of merger
wuttke
16:00 Revision 3b0daf33: class comment
wuttke
15:53 Revision 8f987e7c: restore "protected" in FutestSuite
wuttke
15:51 Revision a6088a6c: same parameter order for all getFutest()
wuttke
15:46 Revision 5d88993a: revert *Suite from callback to inheritance, but with everything in the *Suite....
wuttke
15:44 Documentation #1269 (Resolved): Update documentation for new phi angle definition
herck
14:58 Documentation #1269: Update documentation for new phi angle definition
This is about the user manual, not drupal. herck
15:33 Revision 2dcba2d8: Added clarification about the defined orientation of the experimental angles
herck
15:18 Refactoring #1422 (Resolved): provide clue when test fails
Resolved in f72cbb5. CTest actually does have a pertinent macro, see my own answer at http://stackoverflow.com/questi... wuttke
15:16 Revision f72cbb56: After tests, print "For details, see the log files in Testing/Temporary/." Thi...
wuttke
15:11 Revision f95c6614: found out how to print an after-test message (http://stackoverflow.com/questio...
wuttke
15:07 Revision f7277e3b: SimulationSetupAssistant now validates correspondance of realData and Instrume...
pospelov
14:17 Revision 18c48763: merge further subroutines into linear execute()
wuttke
14:15 Revision b4535f7b: Sample validation is moved out of SimulationSetupWidget to the new SimulationS...
pospelov
14:01 Revision 316938ee: Just one loop over all subtests
wuttke
13:43 Refactoring #1457 (Rejected): Calculate precomputed tables at compile time
See class Precompute herck
13:41 Revision 9fb1db7e: Merge branch 'cleansingleton' into develop
herck
13:19 Revision 252f36ba: Remove unneeded interface IPrecomputed and refactor the singleton (private con...
herck
13:13 Revision bdcf149d: Make singleton constructors private
herck
13:09 Revision 8673a344: Refactor ISingleton: 0 -> nullptr and clear error message
herck
12:25 Revision af7c8c37: rm redundant "inline"
(A function defined entirely inside a class/struct/union definition, whether it's a member function or a non-member f... wuttke
12:15 Revision 2e47c0e0: rename FunctionalTestComponentService -> FutestSuite
wuttke
12:15 Revision 423ad1e6: *Suite passes one callback function to FutestSuite. This saves one level of in...
there are no more suite-specific children of FutestSuite. wuttke
12:15 Revision de7bb053: move MultiTest calls from *Suite to FutestSuite
wuttke
12:15 Revision 93377e97: Merged remaining code from *Suite to FutestSuite::execute
wuttke
12:15 Revision 1eae32dc: Rename FunctionalTest -> Futest; directory FunctionalTest -> Functional.
Start making more consequential use of INamed. wuttke
12:15 Revision d2ed5c01: copy edit some interface classes
wuttke
12:15 Revision 409bf3d1: merged FunctionalMultiTest into FutestSuite.
wuttke
11:36 Revision 93814d9a: Bugfix in SimulationSetting widget (no sample selected case)
pospelov
11:32 Revision c29a304b: Merge branch 'JobActivitiesRef' into develop
pospelov
10:10 Refactoring #1333 (Resolved): MSC switches hopefully obsolete
Replaced with std::isnan and std::isinf and fixed tons of build errors on Windows herck
09:52 Revision 5b4cab57: Rename FunctionalTest -> Futest; directory FunctionalTest -> Functional.
Start making more consequential use of INamed. wuttke
09:41 Revision f159ce1a: Bugfix in ImportDataView with zero selection. Mainwindow returned to default s...
pospelov
08:35 Revision 31e86832: Merged remaining code from *Suite to FutestSuite::execute
wuttke
08:21 Revision c9982ae8: move MultiTest calls from *Suite to FutestSuite
wuttke
08:12 Revision 3a7f356d: *Suite passes one callback function to FutestSuite. This saves one level of in...
there are no more suite-specific children of FutestSuite. wuttke
06:56 Revision 155c80df: rename FunctionalTestComponentService -> FutestSuite
wuttke

09 Jun 2016

18:24 Revision 71ea7fa3: un-comment unit tests
wuttke
18:20 Revision 098af70c: Merge branch 'analyfutests' into develop:
many wuttke
18:15 Revision 42d84da2: key type = string now also in ICloneableRegistry
wuttke
18:09 Revision 7b354df1: Yes another sizeHint fix for ItemStackWidget
pospelov
18:09 Revision ec7d6b67: Merge branch 'msvc_templates' into develop
herck
18:07 Revision 7cfe0c3a: define destination_libexec for Windows installation
herck
17:55 Revision 4d0afffe: pointer -> reference
wuttke
17:49 Revision a77324c2: Separate construction and execution of tests
wuttke
17:47 Revision aaeae511: Tuning of ItemSelectorWidget width
pospelov
17:41 Revision 4f1ec685: Bunch of size hints in desperate attempt to make desired docks width.
pospelov
17:27 Revision f0be455f: FuTestRegistry is now a singleton.
wuttke
17:22 Revision 9fd80518: Simplify ISingleton.
wuttke
17:16 Revision e2c776a7: Export necessary classes for use in tests
herck
16:51 Revision 3f9287f5: copy editing while still reading
wuttke
16:48 Revision 863fe682: Export class CoreFunctionalTestComponentRegistry
herck
16:08 Revision 723c40ae: Declare and export specializations of conj()
herck
15:58 Revision 55870508: replace IFactoryCreateFunction by a registry-specific one-liner. Slightly less...
wuttke
15:49 Revision 37765631: Move implementation of getTestResultString() back to cpp, because the static m...
herck
15:31 Revision 6d48eefb: Restored CMAKE_RUNTIME_OUTPUT_DIRECTORY_DEBUG (and _RELEASE)
herck
15:25 Revision 786c8287: similarly, no special call 'createBuilder'
wuttke
15:19 Revision 6c3b8c6e: hard-code identifier type string in IFactory
wuttke
15:17 Revision 209885bc: Default item selection behavior is moved on board of ItemSelectionWidget
pospelov
15:12 Revision a3c9ea1e: keep name 'createItem' for child class
wuttke
15:02 Revision 5387caf4: lots of copy editing; removed some unnecessay includes
wuttke
14:46 Revision 4c3832c5: Unnecessary modelLoaded signal is removed. Default JobItem selection on projec...
pospelov
14:19 Revision 3e7e54c3: FitControlPanel fixed logic to enable widget if no fit is running.
pospelov
13:55 Revision 9dd64285: copy edit while reading
wuttke
13:32 Revision 35e4490a: C++11ify IFactory
wuttke
13:22 Revision 107628a7: Updated 00_PATCHES after removal of symbolic link
herck
13:19 Revision 3aecf76a: Removed symbolic link for patched gtest (for Windows compatibility)
herck
13:10 Revision 75d0e85a: Modifications in manhattan style to remove 1 pixel frame in the case of KDE5 b...
pospelov
13:10 Revision 88bd20aa: Extra include for stringstreams needed under windows
herck
12:47 Revision dcf64b34: Bugfix FitActivityPanel making FitControlWidget freese.
pospelov
12:36 Revision 3cf611ec: merge after stupid conflict between me and me
wuttke
12:35 Revision 1bc563a2: Replaced 2 template specializations into one generic for cross product
herck
12:34 Revision 1a33d1f3: copy editing while reading ...
wuttke
12:30 Revision 161e7118: no need for explicit length=0 in array constructor
wuttke
11:44 Revision 2a5a9429: Merge branch 'analyfutests' of a:BornAgain into analyfutests
wuttke
11:44 Revision fe078462: rm interface IComponentService, which currently has only one child.
wuttke
11:37 Revision 6ca02ea1: Replaced 4 template specializations into one generic for dot product
herck
11:21 Revision e391d3e9: JobPresenter class is finally removed. ItemStackPresenter is used instead in a...
pospelov
11:04 Revision 7e4d548b: Cleanup in JobQueueModel
pospelov
10:30 Revision 54127ee9: JobRealTimeWidget now is derived from QWidget instead of JobPresenter.
pospelov
10:22 Revision 3ed211f5: Refactored JobModel signals in the part of JobItem selection.
pospelov

08 Jun 2016

22:28 Revision 0db17fe6: minor copy edit
wuttke
18:30 Revision 85e1dec3: JobRealTimeWidget is switched to new selection mechanism
pospelov
17:16 Revision 19038932: JobOutputDataWidget is switched to the new selection mechanism and new StackPr...
pospelov
15:43 Revision b8bc02f2: Signals related to JobItem selection are removed from JobModel.
pospelov
15:04 Revision 8cc6e88d: Bugfix in Job selector dock on toggle panel request.
pospelov
15:00 Revision 3d457aa2: Progress related activity is moved from JobView to JobProgressAssistant.
pospelov
13:58 Revision c25a26ea: Beautification of JobPropertiesWidget
pospelov
13:50 Revision 038638b1: JobSelectorWidget now reacts on JobItem selection
pospelov
13:31 Revision 99478e1a: Regenerated Python doc
herck
13:29 Revision ebdd5d54: Merge branch 'isnan' into develop
Conflicts:
auto/Wrap/doxygen_core.i
herck
12:53 Revision 5aff3e07: JobListWidget is switched to common ItemSelectorWidget
pospelov
12:28 Refactoring #1456 (Rejected): Automatize update of Py Examples
Develop a script to push Python example code from source to Drupal.
Nice to have: the script should also run the e...
wuttke
12:19 Refactoring #1291: core functional test machinery: simplify, or at least explain
By now resolved:
* CMake machinery simplified
* Uppercase C++ functions merged into *Suite.cpp
Still to investig...
wuttke
12:01 Revision 8795338d: temporarily disable unit tests
wuttke
12:00 Revision 47a1021c: Merge branch 'analyfutests' into develop: radical simplification of FuTest CMa...
wuttke
11:57 Revision 1c82dfbe: And therefore, no more need for FuTestMacros.cmake
wuttke
11:42 Revision 624a7e19: Radical simplification of FuTest CMake machinery. Only one of four special mac...
wuttke
11:07 Revision 22ffa91e: include_directories was duplicate; no need for loop for target_link_libraries
wuttke
10:58 Revision 308e541e: New JobSelectorActions which isolates actions related to run/removal of jobs.
pospelov
10:57 Revision 7e0bd096: Slightly simplified CMake FuTest mechanism (with temporary debug messages)
wuttke
08:41 Refactoring #1422: provide clue when test fails
It would be nice to let ctest print an informative footer, but there seems to be no simple way: http://stackoverflow.... wuttke
08:38 Refactoring #1433 (Resolved): move massive numeric tests under 'make check' / 'ctest'
resolved a few days ago wuttke
08:37 Refactoring #1433 (Sprint): move massive numeric tests under 'make check' / 'ctest'
wuttke
08:30 Revision af9ef1b7: New CMake option -DAUTOGENERATE=ON (Py docs, Py wrappers, man page).
File auto/README now copied from cmake script so that it is safe to rm -r auto. wuttke
08:09 Revision 65433562: Restore unit tests (were outcommented during development); update auto/README
wuttke

07 Jun 2016

22:52 Revision 78594ad7: Merge branch 'analyfutests' into develop
wuttke
22:52 Revision c26c45c8: copy edit
wuttke
22:47 Revision 6736ce00: corr (CMakeLists.txt for new subdir was missing)
wuttke
18:35 Revision c853053d: Merge branch 'analyfutests' into develop: Resolved #1452, parallel ctest (-j<n...
wuttke
18:32 Revision e293cc1e: copy editing and little simplification
wuttke
18:18 Revision 66667254: Final cleanup in JobViewDocks
pospelov
18:12 Bug #1452: PySuite tests fail when executed in parallel
For the record: cause of the bug were constant file names (Py script and simulation output) in PyScriptFunctionalTest... wuttke
18:10 Bug #1452 (Resolved): PySuite tests fail when executed in parallel
Solved in [analyfutests 3aee823], soon to be merged into develop. wuttke
18:08 Revision 02883ec3: Toggling of jobSelector is moved down to JobViewDocks
pospelov
18:04 Revision 3aee8239: For functional tests with subcomponents (i.e. FormFactors and Basic2DParaCryst...
wuttke
17:56 Revision 619ab774: JobView's resetLayout now is handled by JobViewDocks
pospelov
17:45 Revision 7ee58072: JobView's activity selection is moved to JobViewDocks
pospelov
17:12 Bug #1455 (Resolved): RuntimeError if CrossCorrLength=0
Fixed in 724fe9f8d2e64f0e8d82013f5f36170a2f7a6351 herck
16:49 Bug #1455 (Archived): RuntimeError if CrossCorrLength=0
BornAgain Python script exits with the "RuntimeError: Attempt to set crossCorrLength to zero" message if the cross co... ganeva
17:11 Revision 724fe9f8: Merge branch 'crosscorrlength' into develop
herck
17:10 Revision 5e1c3767: Fixed bug in setting cross correlation length of multilayer
herck
17:03 Revision 5fb5a35e: New JobViewFlags to hold common enums in single place.
pospelov
16:36 Revision f4f08a11: merge code into ICloneableRegistry::getNames()
wuttke
16:26 Revision d8945232: Replaced MathFunctions::isinf with std::isinf
herck
16:18 Revision b228c7ec: Replaced MathFunctions::isnan with std::isnan
herck
16:08 Revision 8d3fab40: JobActivityStatusBar now requires MainWindow for initialization.
pospelov
16:02 Revision 73143d56: copy edit and simplify ...
wuttke
15:45 Revision 213a3b35: copy edit and simplify, while reading
wuttke
15:44 Revision 20d36265: New JobViewDocks to separate docking logic from JobView
pospelov
14:32 Refactoring #1454 (Resolved): Export to Python: generated scripts should not require "from bornag...
Automatically generated scripts should teach best practice in BornAgain/Python usage. Therefore:
import bornag...
wuttke
14:22 Revision 59cd9b77: split directory: TestPyDump for the Core-to-Python export, TestPyCore for Pyth...
wuttke
14:09 Revision 64dfd1b5: copy editing
wuttke
13:14 Revision 045090ce: reenabled unit tests
pospelov
13:05 Revision ba086953: Merge branch 'ImportDataWidget' into develop
pospelov
12:58 Revision 85f33e09: Returning mainwindow to initial state before the merge
pospelov
12:03 Revision 7e50b89b: Further simplify PyScriptFunctionalTest: set m_pyscript_filename from name; us...
wuttke
11:17 Revision 0781cace: simplify PyScriptFunctionalTest
wuttke
10:44 Revision b100be78: missed files
pospelov
10:44 Revision 9fa89f6a: FitActivityPanel is refactored to rely on ItemStackPresenter
pospelov
09:37 Revision 05c5381d: while reading ...
wuttke
09:03 Revision b5aee8eb: Bugfix in real data selection combo.
pospelov
08:50 Revision 44f5b09a: Made FunctionalTestComponentService::getFunctionalTest() pure virtual instead ...
wuttke
08:41 Revision b016e807: rm unused declarations
wuttke
08:34 Revision 545c01da: Merged common code from *Suite into registry. Made info a pointer.
wuttke
07:44 Revision 1d1143f7: merge (fit|gui)_functional_tests.* into *Suite
wuttke
07:03 Revision 0c4dc3a8: New directory Core/TestMachinery.
Remove empty line from Googletest output. wuttke

06 Jun 2016

17:46 Revision 617db4e1: Real data for fit is finally taken from RealDataModel
pospelov
17:31 Revision 033fcc51: STILL BROKEN
wuttke
16:48 Revision 9763edd8: option -DSKIP_UTESTS to accelerate cmake configuration
wuttke
16:38 Revision e4a927bd: Cleanup in SessionModel to get rid fromtopItemMap and family
pospelov
16:16 Revision b8289f39: Refactored the way sample/instrument selected
pospelov
13:41 Revision 8f63863b: ProjectManager dependency is removed from SimulationSetupWidget
pospelov
13:37 Revision 97c5ccf4: Sample/instrument selection logic is extracted from SimulationSetupWidget into...
pospelov
12:38 Revision 0797e6ce: BROKEN: mv futest machinery from Core/StandardSamples/ to Tests/FunctionalTest...
wuttke
11:32 Revision c824e8e5: IntensityData projectFile's saving/reading is refactored for both JobItem and ...
pospelov
10:50 Revision e2ff26c8: merge core_functional_tests into CoreSuite
wuttke
10:44 Revision dcfff64f: merge pyscript_functional_tests into PySuite.cpp
wuttke
10:39 Bug #1452: PySuite tests fail when executed in parallel
I'm investigating .. wuttke
09:54 Bug #1452 (Resolved): PySuite tests fail when executed in parallel
ctest -j4 yields e.g.
The following tests FAILED:
77 - PySuite/FormFactors (Failed)
78 - P...
wuttke
09:41 Revision b426a0cd: correct missing merge (truncate negative convolution results)
wuttke
07:50 Documentation #1451: update to Drupal 8

Suggested order of upgrade:
* Install drupal locally
** with Bitnami Drupal stack https://bitnami.com/stack/dr...
pospelov

05 Jun 2016

23:30 Revision c546094f: Merge branch 'thisandthat' into develop
wuttke
23:28 Revision 669a9f57: Merge branch 'makecheck' into develop
wuttke
23:28 Revision 32968dbb: Merge branch 'develop' of apps.jcns.fz-juelich.de:BornAgain into develop
wuttke
23:27 Revision ffe84046: Merge branch 'makecheck' of apps.jcns.fz-juelich.de:BornAgain into makecheck
wuttke
22:03 Revision 0678324a: New tests: example and code line length
wuttke
21:16 Revision 38dfae37: edit doclines in getSample() in Py examples; limit lines to 85 chars
wuttke
18:53 Revision 668af323: No Core source file longer than 100 chars.
wuttke
16:45 Revision ff595272: no Core source line longer than 120 chars
wuttke

04 Jun 2016

18:45 Revision 1b0e0796: no C++ source line longer than 180 chars
wuttke
18:19 Revision f30fc001: count-line-length with variable limit given as first argument
wuttke
18:15 Revision 8c4d212e: enable_testing() -> top-level CMakeLists, as recommended by CMake doc
wuttke
18:15 Revision 0cf55ccc: enable_testing() not needed below top-level
wuttke
18:15 Revision 7d29f05f: correction, to repair 'make check'
wuttke
18:15 Revision 58ac180b: destination_runtime_configs -> BUILD_AUTO_DIR
wuttke
18:15 Revision 5f958328: get_filename_component -> separate cmake module
wuttke
18:15 Revision 599aba62: split directory: generic CMake modules vs BornAgain-specific CMake modules
wuttke
18:15 Revision e13dfc72: cmake: shorter directory names, clearer hierarchy
wuttke
18:15 Revision 5efbb8ee: renamed BornAgainMacros.cmake -> FuTestMacros.cmake
because that's all the file is about wuttke
18:15 Revision 62c14b01: GoogletestWrapper generates either compile-time or post-build test.
wuttke
18:15 Revision 7fd8cb52: outcomment target property install unit test to binary/lib
wuttke
18:15 Revision 9cb95710: bin/*Suite are now build under target 'all'
TODO: - also build TestCorePQS
- restore EXCLUDE_FROM_ALL
wuttke
18:15 Revision 9f6e9351: TestCorePQS runs under ctest (="make check")
wuttke
18:15 Revision ff67a6ad: rm debmsg
wuttke
18:15 Revision 27dc2f77: try CTest
wuttke
18:15 Revision ae67e096: revert from include(CTest) to enable_testing() [had no advantage]
wuttke
18:15 Revision b7262554: off-topic: demonstrate removal of unused func_arg
wuttke
18:14 Revision 44e1e340: update and simplify line-count script; still not to be taken literally
wuttke
09:01 Revision 623569d6: revert from include(CTest) to enable_testing() [had no advantage]
wuttke

03 Jun 2016

20:59 Revision 389fcb1f: try CTest
wuttke
20:14 Revision cc2115c2: off-topic: demonstrate removal of unused func_arg
wuttke
19:38 Revision bdede291: rm debmsg
wuttke
19:27 Revision 22c2c373: TestCorePQS runs under ctest (="make check")
wuttke
19:20 Revision 1d51d3c3: bin/*Suite are now build under target 'all'
TODO: - also build TestCorePQS
- restore EXCLUDE_FROM_ALL
wuttke
16:46 Revision 04106215: outcomment target property install unit test to binary/lib
wuttke
16:36 Revision 0d3ea2dd: On the way to refactor IntensityData saving
pospelov
16:05 Revision 0be8532d: GoogletestWrapper generates either compile-time or post-build test.
wuttke
15:59 Bug #1449 (Resolved): Apply detector resolution function can give negative results
Negative values arise as a result of the finite precision in the fft's. In special cases, as in the given example, wh... herck
11:15 Bug #1449 (Archived): Apply detector resolution function can give negative results
Reproduce:
use HexCylinders.py from gisas/support/015_AnatolyBerezkin and add the following line to create_simulatio...
herck
15:51 Revision 86dc5205: Merge branch 'det_resolution' into develop
herck
15:50 Revision 0f7636ee: Truncated negative values from convolve with fft
herck
15:32 Revision 207cb1a9: renamed BornAgainMacros.cmake -> FuTestMacros.cmake
because that's all the file is about wuttke
14:35 Revision 3f5befe0: load/save nonXMLData logic moved to ApplicationModels
pospelov
14:10 Revision 88c1e786: Remove commented code
herck
13:52 Revision dcc868d7: cmake: shorter directory names, clearer hierarchy
wuttke
13:29 Revision 4d2f27e2: Break lines that are too long
herck
13:28 Revision 2ca1c685: Remove commented code
herck
13:03 Revision a56fbd10: split directory: generic CMake modules vs BornAgain-specific CMake modules
wuttke
12:56 Revision d74b2126: ReadFrom, writeToXML logic is moved from ProjectDocument to ApplicationModels.
pospelov
12:48 Revision 595cd9ba: get_filename_component -> separate cmake module
wuttke
12:38 Revision 350ecefa: destination_runtime_configs -> BUILD_AUTO_DIR
wuttke
12:26 Revision 78afbcc4: correction, to repair 'make check'
wuttke
12:19 Revision 87e0a94f: enable_testing() not needed below top-level
wuttke
11:53 Documentation #1437: Release requirement: Update example scripts
Under Drupal 8 (#1451), we might use RESTful services, described at https://drupalize.me/blog/201401/introduction-res... wuttke
11:52 Documentation #1451 (Rejected): update to Drupal 8
especially if we want to use RESTful service to automatize update of Python example scripts, #1437 wuttke
11:24 Revision 85d0cfda: Selection logic in IntensityDataView, bunch of sizeHints
pospelov
11:09 Revision e7bbdc35: enable_testing() -> top-level CMakeLists, as recommended by CMake doc
wuttke
10:48 Revision 901e907d: Code that is common to Core and Fit moved to new cmake module
wuttke
10:16 Revision d15a01a9: mv ValidatePythonInstallation to separate cmake module (unused?);
save one line in after-installation message wuttke
09:24 Bug #1448 (Rejected): Remove html directory from source tarball

* It looks like our current 1.5.1 tarball contains unnecessary 'html' directory with whole content
** Our previous...
pospelov
09:22 Configuration #1150 (Sprint): Improve release script procedure
pospelov
08:57 Configuration #1447 (Archived): Migrate to GitHub

* Merging to the develop should be allowed only after successful builds on build server
pospelov
08:26 Revision c39ba1e9: Working on RealDataEditor widget
pospelov

02 Jun 2016

00:11 Revision 4b2a1259: + tool to report too long lines, to trim drupal examples
wuttke
00:11 Documentation #1412: avoid horizontal scrolling in code examples
develop 4b2a125 provides tool dev-tools/code-tools/count-line-length.py
wuttke
11:24 Documentation #1412 (In Progress): avoid horizontal scrolling in code examples
Clue from stackexchange: syntaxhighlighter style can be overwritten in our theme's CSS: in
/www/apps/drupal/sites/...
wuttke
19:10 Documentation #330: Take care of kz=0 case appropriately
no hope that I'll be free for this any soon wuttke
19:08 Envelope task #1402 (Archived): cmake tasks (OS independent)
no tasks left open wuttke
19:07 Revision e0864962: Correction, and improved file header comment
wuttke
18:21 Revision 58d87dfd: Merge branch 'develop' of apps.jcns.fz-juelich.de:BornAgain into develop
wuttke
18:18 Revision f1c3b67a: plot_utils/__init__.py and plot_utils.py work both, but the latter is easier.
wuttke
17:50 Revision eb2be03f: Load of intensity data into realDataItem implemented.
pospelov
17:46 Revision dc950d58: mv python-setup -> python; frombin... -> thisbornagain.
wuttke
17:25 Revision ec6debc4: Fix bug in FormFactorGauss
herck
16:44 Revision 88bb05c7: New ImportDataAssitant responsible for files import, import directory is saved...
pospelov
16:09 Revision 2db61815: mv python-setup -> python
wuttke
16:05 Revision d60c91c2: assemble all __init__ copy commands in Core/CMakeLists
wuttke
16:01 Revision 60a5cf39: rm unused variable
wuttke
15:53 Revision 2b4f7fda: merge Apple and non-Apple code; rm inconsequential copy command.
wuttke
14:45 Revision edc831bd: New AppSvc for common access to key GUI components.
pospelov
14:33 Bug #1070 (Backlog): Unix should install to /usr/local/lib, not to versioned subdirectory
destination_libexec: libexec/ is highly nonstandard; executable should go to bin/ wuttke
12:58 Revision f122795c: Restore auto-generated stuff to git repository.
wuttke
12:56 Revision a1008b26: Use standard CMake command to make directory, instead of system call
wuttke
12:16 Revision fb54442b: rm CMAKE_RUNTIME_OUTPUT_DIRECTORY_DEBUG|RELEASE (apparently unused)
wuttke
11:44 Revision afed21ac: Fixed problem with python binding generation (on system with numpy 1.8.2)
herck
11:18 Revision c0e549be: WRAP_DIR needed outside auto-generation
wuttke

01 Jun 2016

22:53 Bug #1439 (Resolved): put PythonAPI under CMake control
Resolved in 95d1a38f. wuttke
10:58 Bug #1439 (Sprint): put PythonAPI under CMake control
I'll try in branch cmake wuttke
22:51 Revision 95d1a38f: Merge branch 'cmake' into develop: PythonAPI fully under CMake control, tempor...
wuttke
21:29 Revision 2556f885: split compound add_custom_command to keep intermediate files accessible
wuttke
19:45 Revision 41fd1673: Doxyfile generation now also in wrap / tmp / auto scheme
wuttke
17:22 Revision d8ef2dbe: swig parametrization now in Wrap/, swig output in auto/;
simplified tweaks.py and Core/CMakeLists.txt wuttke
16:06 Revision efcedae9: Bugfix with correct widget removal in the case of removed item
pospelov
15:54 Revision 58c5500c: Add data/remove data logic are implemented
pospelov
15:11 Revision b7218afe: New set of icons for ImoprtDataView
pospelov
14:16 Revision eaf0de80: New ItemStackPresenter for uniform treating of SessionItem's stacked widgets.
pospelov
13:53 Revision 3ec1c772: mv dev-tools python-setup -> Wrap/
wuttke
13:21 Revision f2bc389a: mv dev-tools/swig -> Wrap/swig
wuttke
12:40 Revision 197046b2: Make libtiff required, unless flag is set to -DBORNAGAIN_TIFF_SUPPORT=OFF.
libtiffxx is also required. wuttke
12:19 Revision 0ccda90e: exceptionally, auto-indent an important and complex file
wuttke
11:27 Revision cec62903: status messages from CMake: more uniform, more compact
wuttke
10:59 Revision 20949399: Merge branch 'cmake' into develop: pod2man under CMake control, result put to ...
wuttke
10:55 Envelope task #424 (Archived): === PythonAPI ===
no subtasks left open wuttke
10:52 Feature #975 (Resolved): man page should be built at release time
wuttke
10:51 Feature #975 (Sprint): man page should be built at release time
Resolved in 8f51e90. wuttke
10:50 Revision 8f51e90a: Presence of pod2man now correctly checked by CMake.
This concludes the resolution of #975. wuttke
10:38 Revision f9c325fc: Merge branch 'cmake' of apps.jcns.fz-juelich.de:BornAgain into cmake
wuttke
10:38 Revision be58ce90: mv man -> Doc/
wuttke
10:38 Revision 6ebf714f: Starting directory auto, to receive auto-generated code.
Works for man page. wuttke
10:38 Revision 542d7b82: corr PythonAPI/README
wuttke
10:30 Revision 25572531: Merge branch 'fftest' into develop: corrections to make it work on other platf...
wuttke
10:29 Revision 21c00e81: Merge branch 'fftest' into develop:
improved numeric accuracy wuttke
09:50 Revision f94e30cf: Test for presence of pod2man. This partly resolves #975.
wuttke
09:38 Revision dd8ef171: rm remainders of APP
wuttke
09:04 Revision c8fbc98c: now special treatment if any one of u, v1, v2, v is zero
wuttke
08:46 Revision 2fde6d7e: simplify notation in contrib(): m+1 -> M
wuttke

31 May 2016

18:31 Revision 82865617: v=0 broken, rederive factors!
wuttke
17:51 Revision 0e788499: try to restore v=0 case - spectest fails
wuttke
17:45 Revision 6767f7bf: New RealDataModel to hold imported real data
pospelov
17:00 Revision 5044a439: New placeholder widgets for RealData selection/editing
pospelov
16:14 Revision 59e5f2b9: Majority of toolbars refactored to rely on StyledToolBar
pospelov
14:42 Revision 4b802981: New ImportDataView is implemented
pospelov
13:56 Documentation #1437: Release requirement: Update example scripts
From https://www.drupal.org/node/811950
> There is very rarely any justification for directly interacting with the d...
herck
12:58 Documentation #1437: Release requirement: Update example scripts
There is no simple way to automatize this. We may need to write a script that directly accesses the MySQL data base. wuttke
12:21 Revision d915d665: Version number of this develop branch set to 1.5.99, as agreed in meeting today.
wuttke
12:20 Documentation #1282: Drupal: unique form of persistent page URLs
There is a module that auto-generates URLs from titles - but we might prefer shorter names ... wuttke
11:48 Documentation #1282: Drupal: unique form of persistent page URLs
The explicit form is preferred. It can be set under Edit > URL path settings. wuttke
11:47 Bug #900 (Rejected): Custom form factors in python do not work with multithreading
as agreed in meeting wuttke
11:40 Feature #975: man page should be built at release time
Implemented in branch cmake, commit e33ded6da34, except for testing presence of pod2man. wuttke
11:39 Feature #606: Restore automatic doxygen API generation
make clear that this concerns the master branch wuttke
11:36 Bug #1070: Unix should install to /usr/local/lib, not to versioned subdirectory
Discussed today. No fundamental objections - but beware of possible side effects:
* MacOS
* header files, C++ examp...
wuttke
11:31 Documentation #1104 (Rejected): don't use version-dependent URLs in the online docs
Much simpler solution is already implemented: use a few variables in Drupal.
To set them: Drupal > Admin > Structu...
wuttke
10:16 Revision aad92c6f: corr PythonAPI/README
wuttke
10:14 Revision e33ded6d: Starting directory auto, to receive auto-generated code.
Works for man page. wuttke
09:46 Revision f9cd8c4e: mv man -> Doc/
wuttke

30 May 2016

22:18 Refactoring #1440 (Archived): cover Python examples by functional tests
Test should check that all examples execute without failure, and that they produce about the same detector image as b... wuttke
16:21 Bug #1439 (Resolved): put PythonAPI under CMake control
Currently, when API has changed, one needs to rm Core/PythonAPI/lib*. We should put the generation of these wrappers ... wuttke
16:18 Refactoring #1432: final polish of polyhedral form factor
rel err now <1e-11 wuttke
16:15 Bug #1423: == eliminate warnings ==
warnings come from cmake-called processes, but not from CMake wuttke
16:08 Envelope task #1438 (In Progress): === Physics ===
Physical modelling tasks, unless covered by more specific top-level enevelop tasks wuttke
15:15 Documentation #1412: avoid horizontal scrolling in code examples
no clue how to change the font size -> http://drupal.stackexchange.com/questions/202612/ wuttke
13:41 Refactoring #1071 (Resolved): Example scripts: No global import from Python module bornagain
Resolved in 3b5d014b0, using the regular expressions appended below, plus very little hand editing.
All scripts in...
wuttke
13:34 Refactoring #1071 (Sprint): Example scripts: No global import from Python module bornagain
wuttke
13:37 Revision 3b5d014b: Python examples no longer 'from bornagain import *', but 'import bornagain as ...
This resolves #1071.
Manually repaired AllFormFactorsAvailable.py.
wuttke
13:33 Documentation #1437 (Rejected): Release requirement: Update example scripts
During a sprint, examples are updated in Examples/python/...
Upon release, they need to be moved to the Drupal sit...
wuttke
13:19 Bug #1436 (Archived): repair ex06_Miscellaneous/AccessingSimulationResults.py: type object 'IHist...
broken after past refactoring
$ p2 AccessingSimulationResults.py
Traceback (most recent call last):
File "Acc...
wuttke
13:01 Revision 7c770f83: prepare removal of global import from bornagain
wuttke
11:13 Documentation #1360: reequilibrate hierarchy levels in online docs
no objections raised, so we go for it wuttke
11:01 Bug #900: Custom form factors in python do not work with multithreading
Suggestion: Declare this a feature, update the documentation of CustomFormFactor, and close this issue. Serious work ... wuttke
10:18 Bug #1070: Unix should install to /usr/local/lib, not to versioned subdirectory
probably strong interdependence with #1256 wuttke
10:16 Bug #1070 (Rfc): Unix should install to /usr/local/lib, not to versioned subdirectory
wuttke
10:12 Documentation #1104 (Rfc): don't use version-dependent URLs in the online docs
wuttke
09:57 Revision 98e404b5: rm duplicate typedef
wuttke
09:51 Revision 217f737f: Merge branch 'fftest' into develop: rel err now <1e-11.
wuttke

28 May 2016

19:01 Revision ecf8e426: qpalim=3e-2, qlim=1e-2, symtest<3.8e-12, spectest<7.5e-13, cont<88.61e-12
wuttke
12:25 Revision 91c8e967: qpalim=1e-1, qlim=1e-2 => symtest<4e-12 spectest<7.5e-13 cont@sh9<8.55e-13
wuttke
11:52 Revision 0b61674a: Corr: inconsistently, the fixed qperp term was still present in contrib for v=0;
outcommented this case.
Big improvement, q expansion works now up to 1e0 and further.
Test case sym::Cone6 split in t...
wuttke

27 May 2016

13:44 Revision 580eb7fe: Last fine-tuning: qlim=8e-5, qpalim=1.2e-2 => symtests<2.6e-11, spectests<1.8e...
wuttke
10:10 Revision 6bfd74be: start point for today
wuttke

26 May 2016

19:06 Revision f54eda5e: make debmsg'es permanent; make test shape 9 a nontrivial AnisoPyramid
wuttke
18:28 Revision bb231853: with q_lim=8e-5, symtests<2.6e-11, spectests<1.7e-11
wuttke
17:41 Revision 89097c80: in innermost q expansion, expand further to separate constant term qperp*R
wuttke
15:23 Revision d87af84f: Corrected Py binding (TYpes.h -> VDouble, Complex);
improved sum over edges in q expansion. wuttke

25 May 2016

19:13 Revision 6555bde2: exp_I and mul_I in FFPolyhedron
wuttke
18:04 Revision 1644cf21: using mul_I and exp_I throughout the numeric code
wuttke
17:24 Revision af1d9720: renamed Types.h -> Complex.h
wuttke
17:12 Revision 16e6b232: VDouble.h split off from Types.h; using size_t removed from Types.h
wuttke
16:53 Revision 9ce208d2: rm include<cstddef> from Types.h
wuttke
16:31 Refactoring #1296 (Resolved): update internal information about performance tests
Information in README files updated.
Wiki main page provides links to README files.
wuttke
16:24 Revision ece17d6e: + comment
wuttke
16:09 Revision 6b5c0cc5: Notes on Linux tool perf
wuttke
16:06 Revision 534eafae: explanations from wiki -> README files
wuttke
15:38 Feature #1290: === Core: framework ===
To keep the code base readable and maintainable wuttke
14:45 Revision c5d0ab76: convert perf_log to YAML (not pursued to a satisfactory end)
wuttke
12:55 Revision a8d238d3: repair test_performance.py
wuttke
12:32 Revision 3b2df3cf: Merge branch 'fftest' into develop
wuttke

24 May 2016

10:03 Revision 14badade: include cleveref (not yet used)
wuttke

18 May 2016

16:23 Revision ff57c53a: Merge branch 'FitParametersProxy' into develop
pospelov
16:22 Revision 14dbf217: MultiLayer within JobItem now always has fixed name
pospelov
15:51 Revision 4f4812bb: mainwindow is returned to default state
pospelov
15:43 Revision 85fcfea1: Selection in fit parameter tree is propagated to tuning widget
pospelov
15:20 Revision 6f5b4ade: Cleanup in the Addams family
pospelov
15:00 Revision f563c816: Cleanup in overlay label widgets
pospelov
14:54 Revision 1ddc4b80: Finally info label appears/disappears when tree is empty
pospelov
11:23 Revision 37186e28: New controller widget to palce overlay labels on top of abstract scroll areas.
pospelov

17 May 2016

18:03 Revision b5414322: New experimental InfoLabelWidget to display messages on top of arbitrary viewp...
pospelov
16:58 Revision 73f35421: Tooltips for FitParameterItem tree columns
pospelov
16:27 Revision 68bbab64: FitParameterItem now takes limits attributes from first ParameterItem being dr...
pospelov
15:40 Revision e1a97103: Drop of ParameterItem to empty tree, cleanup in FitParameterWidget
pospelov
14:13 Refactoring #1428 (Backlog): Compactify code that handles parameters (use abstract mechanism inst...
agreed in meeting today wuttke
14:13 Refactoring #1428: Compactify code that handles parameters (use abstract mechanism instead of tre...
By convention, all lengths are in nm, all angles are internally in rad. Therefore, we only need the physical dimensio... wuttke
14:10 Refactoring #1430 (Resolved): Consider moving FormFactor unit tests to a single functional test
The main concern will be resolved per issue #1433.
Renaming of subdirectories will follow later, when Core/ is res...
wuttke
13:59 Refactoring #1433 (Resolved): move massive numeric tests under 'make check' / 'ctest'
to be done when the polyhedral FF is stable (#1432) wuttke
13:56 Refactoring #1432 (Rejected): final polish of polyhedral form factor
* specific tests for frusta that are true pyramids
* exact treatment of vertices that coincide
* -improve edge sum ...
wuttke
11:42 Documentation #1431 (Resolved): simplify cross-referencing using package cleveref
wuttke
11:12 Revision c2dc3592: New mime types in SessionXML and minor renaming
pospelov
11:01 Revision 08f30e3f: Blocked drag operation in the case of ParameterLabel item
pospelov
10:45 Revision 23d3a229: Cleanup in ParameterTuning* family
pospelov
10:43 Revision c5f1d8c1: Merge branch 'fftest' into develop: corrected termination criterion for series...
wuttke
09:59 Revision 76fa799e: Renaming in ModelTuningDelegate and co
pospelov
09:39 Revision 071ffc34: ParameterTuningModel is introduced to encapsulate parameter tuning/dragging ac...
pospelov
09:32 Revision c207cc4e: make FormFactorPolyhedron pure virtual
wuttke
08:56 Revision aa87806d: SessionModel modified to allow copy action
pospelov

16 May 2016

17:49 Revision 3683c7b5: First version of dragging from ModelTuningWidget
pospelov
16:51 Revision 13b0d653: FitParameter link drag/drop within FitParameterTree is working
pospelov
16:16 Revision 7dd1cf4a: First drag/drop attempts in FitParameterAbsModel
pospelov
14:49 Revision 21707625: Removal of FitParameterItemLinks from the tree is implemented
pospelov
14:26 Revision 0db5c8e4: todo note
wuttke
14:21 Revision 6739816f: move sym_Ci to Topology
wuttke
14:17 Revision 0b910234: Method for getSelectedParameterItem moved to ModelTuningWidget
pospelov
14:06 Revision 5110b34f: continuity test requires revert of q_lim from 1e-4 to 1e-5; this requires rela...
wuttke
13:50 Revision 212f7e76: Delete event filter installed to fit parameter tree
pospelov
13:47 Revision 9957968e: Further reduction of test limits
wuttke
13:32 Revision f38c51cc: Stricter criteria in spec and sym tests
wuttke
13:20 Revision ebb4ae38: FitParameter's min/max now of grey color if not editable
pospelov
13:11 Revision f29c3e2d: Improved summation now also for q expansion.
wuttke
12:51 Revision ac9f5cee: merged qpa expansion code for prism and others; new termination criterion now ...
wuttke
12:50 Revision 2e275c4e: Updated logic on fit parameter type change
pospelov
12:17 Revision 92c343b6: improved termination criterion for qpa expansion, improves worst-cast continui...
wuttke
11:40 Revision 4ef78262: revert Kahan (no advantage)
wuttke
10:11 Revision 0a795c5e: try Kahan summation algorithm in edge_sum_ff => no advantage, it seems
wuttke

15 May 2016

12:29 Revision 40ae2457: stricter limits for some more tests ..
wuttke
12:21 Revision 6ca4c843: much stricter FormFactorBasicTest
wuttke
12:14 Revision 547592a8: moved common factor e^iqrperp out of analytic ff2d() => breakthrough in accura...
wuttke

13 May 2016

17:10 Feature #1238: nicer layout for newsletter@bornagainproject.org (reopened: v1.6.0 round mail stil...
I really do not like the black topbar.
Plain ASCII would be nicer than this HTML.
wuttke
16:37 Revision c24d3df3: New mapping in FitParameterItems
pospelov
15:42 Revision 1cdeb903: New fit parameter type introduced (fixed, free, etc) and corresponding delegat...
pospelov
15:12 Revision 5cb77085: SessionModel technical view appearance is controlled now from main window.
pospelov
14:57 Revision a8598891: Base of AnisoPyramid has symmetry S2. Matching test strangely broken.
wuttke
13:53 Refactoring #1424: reduce verbosity of googletest output
Feature request submitted at https://github.com/google/googletest/issues/771. wuttke
10:29 Revision 2229e6e4: Zwischenstand
wuttke

12 May 2016

19:15 Revision 50a81263: Found test case where Re F(q) > V
wuttke
18:45 Revision 599f83c6: BROKEN (trying to improve accuracy of 2d analytic ff)
wuttke
18:16 Revision 70b3856a: New developer's SessionModelView will be hidden part of mainwindow on permanen...
pospelov
17:26 Revision cf672c7d: New universal SessionModelDelegate to operate together with SessionModel
pospelov
13:21 Refactoring #1428: Compactify code that handles parameters (use abstract mechanism instead of tre...
So I withdraw default units from the current proposal. Are units acceptable for you? wuttke
13:12 Refactoring #1428: Compactify code that handles parameters (use abstract mechanism instead of tre...
Maybe this issue should also be split: default values vs units herck
13:11 Refactoring #1428: Compactify code that handles parameters (use abstract mechanism instead of tre...
> > It's not their responsibility.
>
> We are free to assign responsibilities to our creatures as we deem appropri...
herck
13:01 Refactoring #1428: Compactify code that handles parameters (use abstract mechanism instead of tre...
So yes, you want users to get default parametrized items. OK, I accept.
> Core form factors should not have any de...
wuttke
12:38 Refactoring #1428: Compactify code that handles parameters (use abstract mechanism instead of tre...
In GUI default values should be provided to reduce amount of clicks/typing. This allows to start a simulation with a ... pospelov
11:59 Refactoring #1428: Compactify code that handles parameters (use abstract mechanism instead of tre...
The very first question then: Is it actually appropriate for the GUI to assign default parameters to newly created it... wuttke
11:43 Refactoring #1428: Compactify code that handles parameters (use abstract mechanism instead of tre...
The {FF}Items need default values because the GUI needs to create them without user initialization. There is no need ... herck
11:39 Refactoring #1428: Compactify code that handles parameters (use abstract mechanism instead of tre...
interesting consequence. why not? wuttke
10:57 Refactoring #1428: Compactify code that handles parameters (use abstract mechanism instead of tre...

> Each parameter should have a default value
What does it mean? "new FormFactorSphere()" becomes valid and becom...
pospelov
13:16 Refactoring #1430: Consider moving FormFactor unit tests to a single functional test
The number 200k comes from arbitrary choices and can be changed if time is a concern.
The tests are concerned with...
wuttke
13:00 Refactoring #1430: Consider moving FormFactor unit tests to a single functional test
I also agree that these tests conceptually do not belong to unit tests. It also obscures unit test coverage (having 2... herck
12:54 Refactoring #1430: Consider moving FormFactor unit tests to a single functional test
My previous reply disappeared since you commented same record I was commenting.
> Why do we actually have a functi...
pospelov
12:42 Refactoring #1430: Consider moving FormFactor unit tests to a single functional test
> [ RUN] OK is better than just [——]
Agree. Implemented in 91d8e8f5b0.
wuttke
12:36 Refactoring #1430: Consider moving FormFactor unit tests to a single functional test
Nothing in googletest says it is limited to unit tests, let alone to unit tests in the most narrow sense. Why do we a... wuttke
12:31 Refactoring #1430: Consider moving FormFactor unit tests to a single functional test
I put two issues in one, that's true. The major issue is to move Unit to Functional. pospelov
12:09 Refactoring #1430: Consider moving FormFactor unit tests to a single functional test
These are two different issues:
* Move extensive ff tests from Unit to Functional?
* Don't split Core/Unit tests in...
wuttke
10:43 Refactoring #1430 (Resolved): Consider moving FormFactor unit tests to a single functional test
I think that tests of form factor behaviour near singularity and along symmetry axes belongs to the functional tests,... pospelov
12:27 Revision 91d8e8f5: improve output from patched gtest.cc.
wuttke
11:31 Revision f8e2695c: New methods in ModelMapper to notify subscribers on item deletion
pospelov
 

Also available in: Atom