Activity

From 12 May 2016 to 10 Jun 2016

10 Jun 2016

20:04 Bug #1458 (Archived): Compilation under Mac OS is broken

CMake Error: File /Users/pospelov/development/BornAgain/BornAgain/cmake/scripts/MacOSXBundleInfo.plist.in does no...
pospelov
20:02 Refactoring #1454: Export to Python: generated scripts should not require "from bornagain import *"
It's not a bug, it how it was done. Changing to "Refactoring". pospelov
15:44 Documentation #1269 (Resolved): Update documentation for new phi angle definition
herck
14:58 Documentation #1269: Update documentation for new phi angle definition
This is about the user manual, not drupal. herck
15:18 Refactoring #1422 (Resolved): provide clue when test fails
Resolved in f72cbb5. CTest actually does have a pertinent macro, see my own answer at http://stackoverflow.com/questi... wuttke
13:43 Refactoring #1457 (Rejected): Calculate precomputed tables at compile time
See class Precompute herck
10:10 Refactoring #1333 (Resolved): MSC switches hopefully obsolete
Replaced with std::isnan and std::isinf and fixed tons of build errors on Windows herck

08 Jun 2016

12:28 Refactoring #1456 (Rejected): Automatize update of Py Examples
Develop a script to push Python example code from source to Drupal.
Nice to have: the script should also run the e...
wuttke
12:19 Refactoring #1291: core functional test machinery: simplify, or at least explain
By now resolved:
* CMake machinery simplified
* Uppercase C++ functions merged into *Suite.cpp
Still to investig...
wuttke
08:41 Refactoring #1422: provide clue when test fails
It would be nice to let ctest print an informative footer, but there seems to be no simple way: http://stackoverflow.... wuttke
08:38 Refactoring #1433 (Resolved): move massive numeric tests under 'make check' / 'ctest'
resolved a few days ago wuttke
08:37 Refactoring #1433 (Sprint): move massive numeric tests under 'make check' / 'ctest'
wuttke

07 Jun 2016

18:12 Bug #1452: PySuite tests fail when executed in parallel
For the record: cause of the bug were constant file names (Py script and simulation output) in PyScriptFunctionalTest... wuttke
18:10 Bug #1452 (Resolved): PySuite tests fail when executed in parallel
Solved in [analyfutests 3aee823], soon to be merged into develop. wuttke
17:12 Bug #1455 (Resolved): RuntimeError if CrossCorrLength=0
Fixed in 724fe9f8d2e64f0e8d82013f5f36170a2f7a6351 herck
16:49 Bug #1455 (Archived): RuntimeError if CrossCorrLength=0
BornAgain Python script exits with the "RuntimeError: Attempt to set crossCorrLength to zero" message if the cross co... ganeva
14:32 Refactoring #1454 (Resolved): Export to Python: generated scripts should not require "from bornag...
Automatically generated scripts should teach best practice in BornAgain/Python usage. Therefore:
import bornag...
wuttke

06 Jun 2016

10:39 Bug #1452: PySuite tests fail when executed in parallel
I'm investigating .. wuttke
09:54 Bug #1452 (Resolved): PySuite tests fail when executed in parallel
ctest -j4 yields e.g.
The following tests FAILED:
77 - PySuite/FormFactors (Failed)
78 - P...
wuttke
07:50 Documentation #1451: update to Drupal 8

Suggested order of upgrade:
* Install drupal locally
** with Bitnami Drupal stack https://bitnami.com/stack/dr...
pospelov

03 Jun 2016

15:59 Bug #1449 (Resolved): Apply detector resolution function can give negative results
Negative values arise as a result of the finite precision in the fft's. In special cases, as in the given example, wh... herck
11:15 Bug #1449 (Archived): Apply detector resolution function can give negative results
Reproduce:
use HexCylinders.py from gisas/support/015_AnatolyBerezkin and add the following line to create_simulatio...
herck
11:53 Documentation #1437: Release requirement: Update example scripts
Under Drupal 8 (#1451), we might use RESTful services, described at https://drupalize.me/blog/201401/introduction-res... wuttke
11:52 Documentation #1451 (Rejected): update to Drupal 8
especially if we want to use RESTful service to automatize update of Python example scripts, #1437 wuttke
09:24 Bug #1448 (Rejected): Remove html directory from source tarball

* It looks like our current 1.5.1 tarball contains unnecessary 'html' directory with whole content
** Our previous...
pospelov
09:22 Configuration #1150 (Sprint): Improve release script procedure
pospelov
08:57 Configuration #1447 (Archived): Migrate to GitHub

* Merging to the develop should be allowed only after successful builds on build server
pospelov

02 Jun 2016

00:11 Documentation #1412: avoid horizontal scrolling in code examples
develop 4b2a125 provides tool dev-tools/code-tools/count-line-length.py
wuttke
11:24 Documentation #1412 (In Progress): avoid horizontal scrolling in code examples
Clue from stackexchange: syntaxhighlighter style can be overwritten in our theme's CSS: in
/www/apps/drupal/sites/...
wuttke
19:10 Documentation #330: Core: beam propagation: take care of kz=0 case appropriately
no hope that I'll be free for this any soon wuttke
19:08 Envelope task #1402 (Archived): cmake tasks (OS independent)
no tasks left open wuttke
14:33 Bug #1070 (Backlog): Unix should install to /usr/local/lib, not to versioned subdirectory
destination_libexec: libexec/ is highly nonstandard; executable should go to bin/ wuttke

01 Jun 2016

22:53 Bug #1439 (Resolved): put PythonAPI under CMake control
Resolved in 95d1a38f. wuttke
10:58 Bug #1439 (Sprint): put PythonAPI under CMake control
I'll try in branch cmake wuttke
10:55 Envelope task #424 (Archived): === PythonAPI ===
no subtasks left open wuttke
10:52 Feature #975 (Resolved): man page should be built at release time
wuttke
10:51 Feature #975 (Sprint): man page should be built at release time
Resolved in 8f51e90. wuttke

31 May 2016

13:56 Documentation #1437: Release requirement: Update example scripts
From https://www.drupal.org/node/811950
> There is very rarely any justification for directly interacting with the d...
herck
12:58 Documentation #1437: Release requirement: Update example scripts
There is no simple way to automatize this. We may need to write a script that directly accesses the MySQL data base. wuttke
12:20 Documentation #1282: Drupal: unique form of persistent page URLs
There is a module that auto-generates URLs from titles - but we might prefer shorter names ... wuttke
11:48 Documentation #1282: Drupal: unique form of persistent page URLs
The explicit form is preferred. It can be set under Edit > URL path settings. wuttke
11:47 Bug #900 (Rejected): Custom form factors in python do not work with multithreading
as agreed in meeting wuttke
11:40 Feature #975: man page should be built at release time
Implemented in branch cmake, commit e33ded6da34, except for testing presence of pod2man. wuttke
11:39 Feature #606: Restore automatic doxygen API generation
make clear that this concerns the master branch wuttke
11:36 Bug #1070: Unix should install to /usr/local/lib, not to versioned subdirectory
Discussed today. No fundamental objections - but beware of possible side effects:
* MacOS
* header files, C++ examp...
wuttke
11:31 Documentation #1104 (Rejected): don't use version-dependent URLs in the online docs
Much simpler solution is already implemented: use a few variables in Drupal.
To set them: Drupal > Admin > Structu...
wuttke

30 May 2016

22:18 Refactoring #1440 (Archived): cover Python examples by functional tests
Test should check that all examples execute without failure, and that they produce about the same detector image as b... wuttke
16:21 Bug #1439 (Resolved): put PythonAPI under CMake control
Currently, when API has changed, one needs to rm Core/PythonAPI/lib*. We should put the generation of these wrappers ... wuttke
16:18 Refactoring #1432: final polish of polyhedral form factor
rel err now <1e-11 wuttke
16:15 Bug #1423: == eliminate warnings ==
warnings come from cmake-called processes, but not from CMake wuttke
15:15 Documentation #1412: avoid horizontal scrolling in code examples
no clue how to change the font size -> http://drupal.stackexchange.com/questions/202612/ wuttke
13:41 Refactoring #1071 (Resolved): Example scripts: No global import from Python module bornagain
Resolved in 3b5d014b0, using the regular expressions appended below, plus very little hand editing.
All scripts in...
wuttke
13:34 Refactoring #1071 (Sprint): Example scripts: No global import from Python module bornagain
wuttke
13:33 Documentation #1437 (Rejected): Release requirement: Update example scripts
During a sprint, examples are updated in Examples/python/...
Upon release, they need to be moved to the Drupal sit...
wuttke
13:19 Bug #1436 (Archived): repair ex06_Miscellaneous/AccessingSimulationResults.py: type object 'IHist...
broken after past refactoring
$ p2 AccessingSimulationResults.py
Traceback (most recent call last):
File "Acc...
wuttke
11:13 Documentation #1360: reequilibrate hierarchy levels in online docs
no objections raised, so we go for it wuttke
11:01 Bug #900: Custom form factors in python do not work with multithreading
Suggestion: Declare this a feature, update the documentation of CustomFormFactor, and close this issue. Serious work ... wuttke
10:18 Bug #1070: Unix should install to /usr/local/lib, not to versioned subdirectory
probably strong interdependence with #1256 wuttke
10:16 Bug #1070 (Rfc): Unix should install to /usr/local/lib, not to versioned subdirectory
wuttke
10:12 Documentation #1104 (Rfc): don't use version-dependent URLs in the online docs
wuttke

25 May 2016

16:31 Refactoring #1296 (Resolved): update internal information about performance tests
Information in README files updated.
Wiki main page provides links to README files.
wuttke
15:38 Feature #1290: === Core: framework ===
To keep the code base readable and maintainable wuttke

17 May 2016

14:13 Refactoring #1428 (Backlog): Compactify code that handles parameters (use abstract mechanism inst...
agreed in meeting today wuttke
14:13 Refactoring #1428: Compactify code that handles parameters (use abstract mechanism instead of tre...
By convention, all lengths are in nm, all angles are internally in rad. Therefore, we only need the physical dimensio... wuttke
14:10 Refactoring #1430 (Resolved): Consider moving FormFactor unit tests to a single functional test
The main concern will be resolved per issue #1433.
Renaming of subdirectories will follow later, when Core/ is res...
wuttke
13:59 Refactoring #1433 (Resolved): move massive numeric tests under 'make check' / 'ctest'
to be done when the polyhedral FF is stable (#1432) wuttke
13:56 Refactoring #1432 (Rejected): final polish of polyhedral form factor
* specific tests for frusta that are true pyramids
* exact treatment of vertices that coincide
* -improve edge sum ...
wuttke
11:42 Documentation #1431 (Resolved): simplify cross-referencing using package cleveref
wuttke

13 May 2016

17:10 Feature #1238: nicer layout for newsletter@bornagainproject.org (reopened: v1.6.0 round mail stil...
I really do not like the black topbar.
Plain ASCII would be nicer than this HTML.
wuttke
13:53 Refactoring #1424: reduce verbosity of googletest output
Feature request submitted at https://github.com/google/googletest/issues/771. wuttke

12 May 2016

13:21 Refactoring #1428: Compactify code that handles parameters (use abstract mechanism instead of tre...
So I withdraw default units from the current proposal. Are units acceptable for you? wuttke
13:12 Refactoring #1428: Compactify code that handles parameters (use abstract mechanism instead of tre...
Maybe this issue should also be split: default values vs units herck
13:11 Refactoring #1428: Compactify code that handles parameters (use abstract mechanism instead of tre...
> > It's not their responsibility.
>
> We are free to assign responsibilities to our creatures as we deem appropri...
herck
13:01 Refactoring #1428: Compactify code that handles parameters (use abstract mechanism instead of tre...
So yes, you want users to get default parametrized items. OK, I accept.
> Core form factors should not have any de...
wuttke
12:38 Refactoring #1428: Compactify code that handles parameters (use abstract mechanism instead of tre...
In GUI default values should be provided to reduce amount of clicks/typing. This allows to start a simulation with a ... pospelov
11:59 Refactoring #1428: Compactify code that handles parameters (use abstract mechanism instead of tre...
The very first question then: Is it actually appropriate for the GUI to assign default parameters to newly created it... wuttke
11:43 Refactoring #1428: Compactify code that handles parameters (use abstract mechanism instead of tre...
The {FF}Items need default values because the GUI needs to create them without user initialization. There is no need ... herck
11:39 Refactoring #1428: Compactify code that handles parameters (use abstract mechanism instead of tre...
interesting consequence. why not? wuttke
10:57 Refactoring #1428: Compactify code that handles parameters (use abstract mechanism instead of tre...

> Each parameter should have a default value
What does it mean? "new FormFactorSphere()" becomes valid and becom...
pospelov
13:16 Refactoring #1430: Consider moving FormFactor unit tests to a single functional test
The number 200k comes from arbitrary choices and can be changed if time is a concern.
The tests are concerned with...
wuttke
13:00 Refactoring #1430: Consider moving FormFactor unit tests to a single functional test
I also agree that these tests conceptually do not belong to unit tests. It also obscures unit test coverage (having 2... herck
12:54 Refactoring #1430: Consider moving FormFactor unit tests to a single functional test
My previous reply disappeared since you commented same record I was commenting.
> Why do we actually have a functi...
pospelov
12:42 Refactoring #1430: Consider moving FormFactor unit tests to a single functional test
> [ RUN] OK is better than just [——]
Agree. Implemented in 91d8e8f5b0.
wuttke
12:36 Refactoring #1430: Consider moving FormFactor unit tests to a single functional test
Nothing in googletest says it is limited to unit tests, let alone to unit tests in the most narrow sense. Why do we a... wuttke
12:31 Refactoring #1430: Consider moving FormFactor unit tests to a single functional test
I put two issues in one, that's true. The major issue is to move Unit to Functional. pospelov
12:09 Refactoring #1430: Consider moving FormFactor unit tests to a single functional test
These are two different issues:
* Move extensive ff tests from Unit to Functional?
* Don't split Core/Unit tests in...
wuttke
10:43 Refactoring #1430 (Resolved): Consider moving FormFactor unit tests to a single functional test
I think that tests of form factor behaviour near singularity and along symmetry axes belongs to the functional tests,... pospelov
 

Also available in: Atom