Activity - BornAgain - Scientific Computing Group

Activity

From 06 Jul 2016 to 04 Aug 2016

04 Aug 2016

21:47 Revision bb24be6c: rm unused; regenerate bindings: wuttke
21:24 Refactoring #1440 (Sprint): cover Python examples by functional tests: Now I know how to do it. Each example, depending on its argument, shall either plot or write to file. The latter beha... wuttke
17:58 Bug #1571: PyCoreTest overlooks complete obstruction of simulation: Resolved in cdc32a6, except for the possible failure to detect zero-filled detector images. wuttke
16:22 Bug #1571 (Sprint): PyCoreTest overlooks complete obstruction of simulation: wuttke
17:55 Revision cdc32a6f: PyCoreTest now writes concise log lines, and by some miracle Python errors als...: wuttke
17:43 Feature #1573: facilitate plotting from Python scripts exported by PyCore tests.: Resolved in 98163aa. wuttke
17:40 Revision 98163aa0: Python script, generated by ExportToPython, now takes argument '-p' for plotti...: wuttke
17:02 Revision 9cf72b7b: Merge IFunctionalTest::analyzeResults() into IFunctionalTest::runTest() [Tests...: wuttke
16:11 Refactoring #1567 (Waiting): omit »FormFactor« from particle geometry class names: wuttke
15:27 Refactoring #1567: omit »FormFactor« from particle geometry class names: Next question then, whether to put them in a namespace. wuttke
15:53 Refactoring #1548 (Waiting): choose name for fit library: Opinion from first discussion: probably something less grandious than "FitSuite". wuttke
15:52 Refactoring #1547 (Backlog): restore ScanningMinimizer: So it shall be refactored and reintegrated into the minimizer selection wuttke
15:48 Refactoring #1549 (Waiting): rename class FitSuite: wuttke
13:23 Refactoring #1549: rename class FitSuite: I don't like FitController that much. It is also hard to explain users, why we have renamed FitSuite to something e... pospelov
12:51 Refactoring #1549: rename class FitSuite: I vote for FitController herck
15:47 Refactoring #1550 (Sprint): in .h file header comments, replace »Declares« by »Defines«: Yes, replace »Declares« by »Defines«.
Remove ' // inheriting from'. wuttke
12:49 Refactoring #1550: in .h file header comments, replace »Declares« by »Defines«: Not related to this one, but to headers auto-update procedure.
* where can I find code tools used for code auto up... pospelov
15:46 Feature #1554 (Backlog): provide script to update Python files upon name changes in BornAgain: As one-time solution.
Later on, for lighter changes, backward compatibility should be ensured differently: obsolete ... wuttke
15:42 Feature #1561 (Rejected): merge FTDistribution.. and FTDecayFunction..: They are different.
* Distributions are pdf's, normalized to integral=1.
* Decay functions do have f(0)=1.
wuttke
15:41 Feature #1564 (Sprint): split "Pi.h" from Units.h: There is definitely no PI in the C++11 standard, so we go for Pi.h. wuttke
15:25 Refactoring #1569: rename hard particle form factors: After first discussion, tendency to answer the $-question with yes: In principle, special cases of generic shapes mer... wuttke
15:22 Refactoring #1565 (Sprint): to associate units with parameters, use string instead of inheritance: member variable of type string is perhaps not the best solution, but in any case a valid first approximation, and wil... wuttke
13:47 Refactoring #1557 (Rejected): FitParameterLinked causes weird coupling: refactoring done under other issue wuttke
13:03 Bug #1574 (Rejected): Find the way of comfort work in Qt creator in the absence of some headers: After removal of WinDllMacros.h from all headers (in the favor of its automatic include via cmake compilation keys), ... pospelov

03 Aug 2016

19:32 Documentation #1351: Drupal: update installation instructions, tutorials for coming release: I guess contents is not left over from 1.6, but refers to the next release? wuttke
19:31 Revision a2586621: Removed unused members from FormFactorInfo. This resolves #1556. Also moved im...: wuttke
19:29 Refactoring #1556 (Resolved): FormFactorInfo: remove unused m_pos_x, m_pos_y: Resolved in a25866219, i.e. removed the unused members. As for inheritance, I had soon understand on my own that this... wuttke
19:16 Feature #1564: split "Pi.h" from Units.h: Overlaps with #1304 ... wuttke
09:28 Feature #1564 (Archived): split "Pi.h" from Units.h: PI is not a unit, and used much more often, and typically in other contexts, than units.
So definitions of PI, PI2, ... wuttke
19:15 Feature #1573 (Archived): facilitate plotting from Python scripts exported by PyCore tests.: PyCoreStandardTest generates scripts like <build>/tmp/pysuite_HexParaCrystal.py. Little changes to these scripts will... wuttke
19:05 Feature #1572: == Python ==: Covers
* Python bindings
* Export of Python scripts from Core wuttke
19:02 Feature #1572 (Rejected): == Python ==: wuttke
19:05 Revision 4be1d3af: move fixed code snippets into constant strings, and into separate namespace.: wuttke
18:49 Bug #1571 (Archived): PyCoreTest overlooks complete obstruction of simulation: Let the Python function getSample(), exported by ExportToPython, return None instead of a multilayer. Then... wuttke
15:49 Revision 66309931: more explicit method name "simulationToPython"; change parameter name into "si...: wuttke
15:01 Refactoring #1570 (Rejected): replace parameter accessor methods getFoo() by getParameterValue("F...: Simplifies the API at no cost in usability. Sole use of the form factor parameter read accessors seems to be in GUI/c... wuttke
14:50 Revision 1685753a: Merge branch 'parunit' into develop: pospelov
14:50 Revision 22395dd4: Merge branch 'hotfix-1.6.2' into develop. Fixed bug #1558: # Conflicts:
# Core/Instrument/DetectorMask.cpp
# Core/Samples/BAVersion.h
# Fit/Minimizer/MinimizerFactory.cpp
# Fit... pospelov
14:01 Refactoring #1555 (Resolved): invert dependence of FitKernel on FitParameterLinked: Resolved in 77bb6a194. Sorry for not closing this earlier. wuttke
09:13 Refactoring #1555: invert dependence of FitKernel on FitParameterLinked: When I can start working on #1478 and #1466?
pospelov
13:53 Refactoring #1569 (Rfc): rename hard particle form factors: Indispensable because some names are in conflict with established geometric terminology. Question is how far we go. S... wuttke
13:25 Feature #1568 (Backlog): Implement TruncatedEllipsoid to replace HemiEllipsoid: HemiEllipsoid describes an elongated droplet in contact with a surface. Are there any physical applications? If yes, ... wuttke
10:56 Refactoring #1567 (Rejected): omit »FormFactor« from particle geometry class names: Rename
* FormFactorCone -> Cone
* FormFactorTruncatedSpheroid -> TruncatedSpheroid
* and so on for all hard partic... wuttke
10:36 Feature #1554 (Rfc): provide script to update Python files upon name changes in BornAgain: wuttke
10:34 Refactoring #1440: cover Python examples by functional tests: required for #1566 (the big renaming) wuttke
10:32 Envelope task #1566: == API changes ==: replacing #1497 wuttke
10:25 Envelope task #1566 (In Progress): == API changes ==: Certain classes and methods should be renamed to better reflect their meaning.
These changes will affect the user ... wuttke
10:19 Refactoring #1497 (Rejected): Agree on new Core directory structure and class renaming to Rename ...: Perhaps it is cleaner to reject this issue, and to open a new issue specifically about the class&method renaming, usi... wuttke
10:12 Refactoring #1497: Agree on new Core directory structure and class renaming to Rename certain cla...: "directory structure" taken out of the title of this issue; if you want, reopen as a separate issue.
A good direct... wuttke
10:04 Refactoring #1565: to associate units with parameters, use string instead of inheritance: at this occasion, correct the limits for angles form +-90 or +-180 to +-PID2 or +-PI wuttke
09:39 Refactoring #1565 (Archived): to associate units with parameters, use string instead of inheritance: While implementing units-in-parameters using the inheritance approach, I learned that units can be undefined when par... wuttke
10:01 Revision 336f773b: rename internal methods in export/label mechanism: wuttke
09:51 Feature #1563: Investigate time-of-life of SampleBuilder in Python context: This is definitely a remnant from the old bindings. In the old bindings, the ownership problem was solved on the C++ ... jmfisher
08:48 Feature #1563 (Archived): Investigate time-of-life of SampleBuilder in Python context: *Item I*
* Is it possible to provide inline usage of SampleBuilder, as in example of Dominique Dresen?... pospelov
09:38 Bug #1559 (Rejected): Restore intensitydata.py functional test: You are right. I was able to do this in boost-python binding only because, as you've explained, he was silently pro... pospelov
09:35 Bug #1559: Restore intensitydata.py functional test: Note that this is the expected behaviour in C++. getXaxis() returns a raw pointer to the axis, which is owned by the ... jmfisher
09:13 Revision 9ad1670e: Locally use "using namespace PythonFormatting" for conciseness: wuttke
09:07 Revision 9620888e: one "define" method is used in GUI: wuttke
09:00 Revision e16af94e: Privatize methods; class comment; regenerate bindings: wuttke
08:48 Revision 6ac45c7d: updated '@file': wuttke
08:46 Revision e0266033: corrections for a few commits ago: missing "BornAgain::": wuttke
08:40 Feature #1562: Provide ISample with possibility to export parameter tree in Python dictionary: this sounds very close to what I am working on right now wuttke
08:26 Feature #1562 (Resolved): Provide ISample with possibility to export parameter tree in Python dic...: Request from Dominique Dresen:
> Print / Retrieve All Possible Fitting Parameters, including Beam Properties.
... pospelov
08:38 Revision f65310b5: update include guards; regenerate bindings: wuttke
08:34 Revision 2865fcbb: more expressive names for PyGen*: ExportToPython, PythonFormatting: wuttke
08:22 Feature #1561 (Rejected): merge FTDistribution.. and FTDecayFunction..: or is there any good reason to maintain two different interfaces and implementations for a Gaussian, a Lorentzian, an... wuttke
08:21 Feature #1560 (Archived): Provide simulation running from Python with text version of progress bar: Request from Franziska Löhrer
> is it possible to track the progress (e.g. via the progress handler), when using... pospelov

02 Aug 2016

23:50 Revision 9dbc2ff3: one more auto-export: wuttke
23:46 Revision 7db204fe: FTDecayfunction automatically exported to Python: wuttke
22:22 Revision 6607a0f7: register _all_ 4 or 5 parameters of the 2D FT-Distributions, and allow them as...: wuttke
21:03 Revision ed9a4abc: simplify export of IFTDecayFunction1D: wuttke
20:41 Revision a2aef303: split FTDistributions -> ..1D, ..2D: wuttke
20:00 Revision 482d87ae: correct missing "\n" in FormFactor export: wuttke
19:41 Revision 162cb4d5: revert automatic output for Beam (it's not a constructor here): wuttke
19:32 Revision 6a451666: Merge branch 'parunit' into develop: wuttke
19:28 Revision 97ddfec6: unified short name for different local pointers, to bring forward code duplica...: wuttke
19:10 Revision ee0d6b11: Merge branch 'parunit' into develop: wuttke
19:10 Revision 53fa1513: minor simplification: wuttke
18:58 Revision 8ce81755: Beam and Roughness exported to Python with automatically generated argument li...: wuttke
18:36 Revision d57a1050: Merge branch 'parunit' into develop. Parameters now have a unit; FormFactor ar...: wuttke
18:30 Revision c9268b4c: Export of form factors to Python now uses automatically generated argument list.: wuttke
18:12 Revision 9736e630: Merge branch 'DisableNastyTest': pospelov
18:11 Revision 3ba67de8: Disabling subtest to bypass failure on make check (the case is not used, but h...: pospelov
18:08 Bug #1559 (Rejected): Restore intensitydata.py functional test: After I have fixed Simulation::getIntensityData ownership within #1558, and the returned Histogram2D object started... pospelov
18:05 Revision e5337f48: Merge branch 'fixwindowsbuild' into develop: herck
17:53 Bug #1558 (Resolved): Memory leakges in Python on Simulation::getIntensityData call: pospelov
10:05 Bug #1558 (Archived): Memory leakges in Python on Simulation::getIntensityData call: Thanks to Dominique Dresen
>I think I narrowed the source of this bug down to the getIntensityData() method of G... pospelov
17:49 Revision 647fb041: Fixed some more compilation errors: herck
17:30 Revision e2194ee1: Merge branch 'hotfix-1.6.2' into develop. Fixed bug #1558: # Conflicts:
# Core/Instrument/DetectorMask.cpp
# Core/Samples/BAVersion.h
# Fit/Minimizer/MinimizerFactory.cpp
# Fit... pospelov
17:12 Revision 81bc2bfd: Converted to new parameter registration API.: wuttke
17:12 Revision cbeff088: minor edits while reading: wuttke
17:12 Revision 980a9814: RealParameter is now pure virtual. Temporarily, all parameters are Scalar. In ...: wuttke
17:12 Revision a7f52ef6: pack Angle, Length, Scalar all in DimensionedParameters.h: wuttke
17:12 Revision 77bb6a19: Two methods removed from FitSuiteParameters, and directly implemented in FitKe...: This make Fit again independent of Core, and thereby resolves #1555. wuttke
17:08 Revision 9ff3ab49: Doxygen comments on Crystal, MesoCrystal, FormFactorCrystal.: wuttke
17:08 Revision d2090a0a: rm keyword "virtual" when there is the more expressive keyword "final": wuttke
17:08 Revision 5c18b284: regenerated XML: wuttke
15:40 Revision 61c9ba10: Merge branch 'hotfix-1.6.2': pospelov
15:39 Revision 34985014: Version number propagated to 1.6.2: pospelov
15:29 Revision 1fd38985: MinimizerTest is returned to MinimizerFactory: pospelov
15:23 Revision 0315a078: Added missing include: herck
15:05 Revision dd711b2d: DetectorMask exposed to Python: pospelov
14:14 Revision 4645b03a: Fixed transfer of ownership to python in FitSuite: pospelov
14:04 Revision 18e2fd50: Bugfix #1588 because of non-transfered ownership to Python.: pospelov
13:35 Revision d99fcfc5: Added missing includes: herck
11:39 Refactoring #1556: FormFactorInfo: remove unused m_pos_x, m_pos_y: m_pos_x and m_pos_y can indeed be removed. Inheriting from IFormFactor is conceptually not a good idea, since FormFac... herck
11:35 Revision 84edf1d5: BROKEN - while converting to new parameter registration API: wuttke
11:04 Revision 42f18c3f: pack Angle, Length, Scalar all in DimensionedParameters.h: wuttke
10:44 Revision 7cd3a4a1: RealParameter is now pure virtual. Temporarily, all parameters are Scalar. In ...: wuttke

01 Aug 2016

22:32 Revision e3db1aa9: minor edits while reading: wuttke
21:42 Refactoring #1557 (Rejected): FitParameterLinked causes weird coupling: FitParameterLinked inherits from FitParameter.
However, its member m_pool_parameters is of type vector<RealParameter... wuttke
21:13 Revision 156e8e35: two methods removed from FitSuiteParameters, and directly implemented in FitKe...: This make Fit again independent of Core, and thereby resolves #1555. wuttke
20:20 Refactoring #1556 (Sprint): FormFactorInfo: remove unused m_pos_x, m_pos_y: wuttke
18:24 Refactoring #1556 (Archived): FormFactorInfo: remove unused m_pos_x, m_pos_y: Members m_pos_x, m_pos_y seem to be unused => delete them.
wuttke
18:07 Revision 4f8bd5fb: BROKEN: in middle of #1555: wuttke
18:04 Refactoring #1555 (Resolved): invert dependence of FitKernel on FitParameterLinked: Subclasses ParameterLength, ParameterAngle etc only make sense in Core/, not in Fit/.
Therefore we need to move Para... wuttke
17:12 Revision d112ce7c: regenerated XML: wuttke
17:10 Refactoring #1432: final polish of polyhedral form factor: can wait wuttke
17:08 Revision 197226e8: rm keyword "virtual" when there is the more expressive keyword "final": wuttke
15:57 Revision 2667c834: Doxygen comments on Crystal, MesoCrystal, FormFactorCrystal.: wuttke
15:34 Feature #1554 (Rejected): provide script to update Python files upon name changes in BornAgain: For users, and for converting our own examples and tests.
Compare #1553 which does the same for XML project files. wuttke
15:31 Feature #1553 (Rejected): Project (XML) read-in: support old versions by automatic conversion of ...: Name changes should be made conditional on this. wuttke
15:26 Revision 9ee71eef: Merge branch 'parunit' into develop, resolving #1543 and #1546.: wuttke
14:59 Refactoring #1546 (Resolved): disambiguate getRadius(): Resolved in 4defcc9.
In passing: removed unnecessary 'virtual' attribute from 'clone' methods. wuttke
11:57 Refactoring #1546: disambiguate getRadius(): Starting in branch parunit, as preparative step towards #1428. wuttke
10:45 Refactoring #1546 (Archived): disambiguate getRadius(): getRadius() currently has two different, though overlapping uses:
* to return the value of »Radius«, if the particle... wuttke
14:57 Revision 4defcc99: Replaced getRadius by getRadialExtension, except where it means "get value of ...: wuttke
14:30 Bug #1552 (Resolved): FormFactorTrivial should have RadialExtension = 0: The physical meaning of FormFactorTrivial is: form factor of a dot.
Accordingly, getRadialExtension() should return ... wuttke
13:52 Revision e6bb045d: Add include dir for forced include w32pragma.h: herck
13:43 Revision 730b7c0f: 11ify FFCrystal: wuttke
11:54 Documentation #1414: regenerate form factor images in manual: I'll come back to this when resuming work on the manual wuttke
11:54 Refactoring #1065: Revise particle form factors: change names, add few form factors, change some ...: Needs further preparation & discussion wuttke
11:53 Refactoring #1469: Package Multifit-Suite as separate library: I'll come back to this wuttke
11:33 Refactoring #1551 (Resolved): rename directory RootWrapper/ and files therein: The subsystem implemented in RootWrapper wraps not only the CERN Root minimizers, but also others. So »Root« and »ROO... wuttke
11:28 Refactoring #1550 (Archived): in .h file header comments, replace »Declares« by »Defines«: Since we discussed nomenclature many weeks ago, I paid attention to it and convinced myself that »declaration« - »def... wuttke
11:22 Refactoring #1549 (Rejected): rename class FitSuite: »FitSuite« is one possible name for the entire fit library (#1548).
It is not so good a name for the top-level cla... wuttke
11:10 Refactoring #1548 (Rejected): choose name for fit library: Per #1469, we'll package our multi-minimizer wrapper as a separate library. How shall we call it?
* libfitagain
*... wuttke
10:58 Refactoring #1547 (Rfc): restore ScanningMinimizer: wuttke
10:57 Refactoring #1547 (Backlog): restore ScanningMinimizer: ScanningMinimizer (previously MinimizerScan) is the only minimizer that directly accesses OutputData<>.
It is cove... wuttke
10:34 Refactoring #1545 (Rejected): INamed: replace default "" by typeid(): In most or all of the ISample hierarchy, m_name is initially set to the class name. This can be easily achieved by a ... wuttke
10:25 Configuration #1544 (Rejected): require libcerf instead of providing ThirdParty/Fadeeva: »Eat your own dogfood«. We are hosting »libcerf«, so we should use it in our own projects. »libcerf-dev« has made it ... wuttke

28 Jul 2016

18:12 Revision e4508652: FitKernel no longer known by FitSuite; call back now accomplished by a std::fu...: wuttke
18:09 Feature #1543 (Resolved): decouple FitKernel from FitSuite: wuttke
18:08 Feature #1543: decouple FitKernel from FitSuite: Resolved in e450865. wuttke
15:59 Feature #1543 (Archived): decouple FitKernel from FitSuite: using std::function callback in FitKernel::notifyObservers() wuttke
16:53 Revision 65cbbd45: Merge branch 'testing' into develop: reduce dependence of Core on Fit by movin...: wuttke
16:00 Revision 9573d6a0: Merge branch 'parunit' into testing: beautify this and that in Fit/, move EXce...: wuttke
15:56 Revision b8bbacb9: 11ify another .cpp file: wuttke
15:23 Revision 8872cd2f: 11ify: wuttke
14:53 Revision d088b7f7: cleanup: wuttke
14:40 Revision dbe48d27: move Exceptions back to Core/: wuttke
14:38 Revision fe67cf34: copy editing: wuttke
13:31 Refactoring #1542 (Resolved): Make ParameterPool and RealParameter independent of IParameterized: Resolved in 1c23198. Went smoothly, using std::function and std::bind. wuttke
10:37 Refactoring #1542 (Archived): Make ParameterPool and RealParameter independent of IParameterized: Currently, they have a member IParameterized* m_parent that is only used to call IParameterized::onChange().
If we... wuttke
13:29 Revision 1c23198e: Merge branch 'testing' into develop: ParameterPool is now independent of IPara...: wuttke
13:19 Revision 09191f9e: Utils divided in Fit/Utils/StringUtils and Core/Tools/Utils.: wuttke
12:39 Revision 8962e9e8: Moved INamed from Fit/ to Core/.: wuttke
12:32 Revision 559353b4: moved IParameterized back to Core/, prepared move of INamed.: wuttke
11:40 Revision f711564f: ParameterPool no longer knows IParameterized; call back now done using std::fu...: wuttke
11:08 Revision d31d4498: Prepare for resolution of #1542: no more direct coupling between RealParameter...: wuttke
10:39 Revision 6d79a15c: Merge branch 'testing' into develop: Pointerify ParameterPool; place Fit/ _bel...: wuttke
10:37 Revision 67a8081b: TODO notice; regenerated bindings: wuttke
10:33 Refactoring #1469: Package Multifit-Suite as separate library: priority set to high because rapid return to stability in directory structures is desired wuttke
10:25 Refactoring #1541: review areAlmostEqual and get_relative_difference: With 7c816ab there comes a rudimentary unit test TestRelDiff, to be expanded while this issue is being solved. wuttke
10:18 Refactoring #1541 (Backlog): review areAlmostEqual and get_relative_difference: Is there need for a tolerance_factor? Probably not.
Are small numbers meant on a linear or a logarithmic scale? Is... wuttke
10:09 Revision 7c816abc: start unit test RelDiffTest; outcome for small arguments needs closer attention: wuttke

27 Jul 2016

21:38 Revision d9c90189: include -> forward class declaration: wuttke
20:54 Revision d7c3c54e: ICloneable moved back to Core/ (otherwise severe problem with SWIG): wuttke
20:48 Revision e1a1772b: copy editing, code line length in Core/ passed: wuttke
20:15 Refactoring #1469: Package Multifit-Suite as separate library: rewrote title and description wuttke
18:54 Refactoring #1469 (Sprint): Package Multifit-Suite as separate library: good progress in 008f21a;
base classes and utilities moved to Fit/ require second thought wuttke
19:24 Revision d628134d: moved import-module from libBornAgainFit.i to ..Core.i; now all tests but two ...: wuttke
18:57 Revision 008f21a0: Started serious work on #1469, separate FitAgain from BornAgain.: Top-level routines moved from Fit/Suite to Core/Fitting.
Some base classes and utilities moved from Core to Fit/Utils... wuttke
17:51 Feature #1540 (Long Term Idea): Implement incoherent z-distribution of particles inside layer: This can be done very efficiently using the same type of attenuation factor as used in:
doi: 10.1107/S00218898060437... herck
16:30 Revision ae745cc8: rm a few more includes: wuttke
15:38 Refactoring #1538 (Rejected): AttLimits::isInRange(value) returns true for value==m_lower_limit, ...: Current implementation is... wuttke
15:01 Revision 94ee6217: renamed RealParameterWrapper -> RealParameter (in my understanding,: a parameter is more than its value. A parameter has at least a name, a
physical dimension, and a value. So, our class... wuttke
13:02 Revision e65af0c3: 11ify: private -> delete; include -> forward class declaratin: wuttke
12:58 Revision ec3e2e2a: FitParameterLinked now also using vector<..Wrapper*>: wuttke
12:46 Revision 12cc1833: nontrivial implementation moved from .cpp to .h: wuttke
12:43 Revision 609680d1: include -> forward class declaration: wuttke
12:40 Revision e095c9fe: Converted ParameterPool::m_params from vector<RealParameterWrapper> to vector<...: wuttke
10:11 Revision 922eaa3a: ParameterPool::getParameter and IParameterized::getParameter now return a poin...: wuttke
08:14 Revision 3a9c7328: renamed FitSuiteParameters::getParameter -> getFitParameter, to distinguish fr...: wuttke
08:01 Revision 8e921a1a: Raise runtime error ("BUG") if IParameterized::IParameterized(const IParameter...: Just to prevent future abuses. wuttke

26 Jul 2016

19:59 Revision 5b4aedb4: renamed MinimizerTest -> TrivialMinimizer (it's not a minimizer test, but a te...: renamed MinimizerScan -> ScanningMinimizer (it does not scan minimizers, but minimizes by scanning) wuttke
19:40 Refactoring #1469: Package Multifit-Suite as separate library: Halted after bbac161 (minor cleanup, and split of Fit/ into four directories with clear include hierarchy)
wuttke
09:19 Refactoring #1469: Package Multifit-Suite as separate library: started with some easy refactoring wuttke
19:36 Feature #1513 (Resolved): Provide more informational throw message from RealParameterWrapper.: ... followed and concluded by simplification of ParameterPool in 9c8e6d. wuttke
18:19 Feature #1513: Provide more informational throw message from RealParameterWrapper.: Resolved in 32e8204d0d4: RealParameterWrapper now has parameter m_name. wuttke
07:43 Feature #1513 (Sprint): Provide more informational throw message from RealParameterWrapper.: wuttke
19:34 Revision 9c8e6d23: Merge branch 'testing' into develop: Parameters now have names, resolving #1513.: wuttke
19:27 Revision f1c54e6f: Since RealParameterWrapper now knows its name, ParameterPool needs no longer t...: wuttke
18:12 Revision 32e8204d: RealParameterWrapper know has a m_name, which is used for more informative err...: This resolves #1513. wuttke
16:27 Revision bbac161a: Fit/ now hierarchichally structured in four directories: wuttke
16:18 Revision 0c56f16b: experimental directory split in Fit/.: wuttke
16:17 Revision c5c9d026: restore IParameterized::printParameters (has good use in Python examples): wuttke
15:40 Revision 63dc612a: Fit/ has now four subdirectories with clear hierarchy: Suite -> Minimizer <-> ...: wuttke
14:34 Revision 968440ba: Merge branch 'testing' into develop: simplifications and code copy editing aro...: wuttke
14:33 Revision 0e707ee1: experimental directory split in Fit/.: wuttke
14:33 Feature #1537 (Rejected): parametrize Gaussians and Lorentzians by mean and fwhm: Whenever possible, different models should use common parameters.
For instance, different distribution functions mig... wuttke
12:18 Revision cd73a287: more of the same: wuttke
11:51 Revision 62099f25: some standard cleanup in FitKernel and Binning/IAxis: wuttke
11:33 Revision 871a09de: Exceptions.h no longer included via IAxis.h: wuttke
11:11 Revision fe19d5dc: Exceptions.h no longer included via BasicVector3D or ThreadInfo: wuttke
10:49 Revision 8bcd0b8d: Exceptions.h no longer included via ICloneable.h: wuttke
10:34 Revision 467ce12b: implementation -> ISimulation.cpp: wuttke
09:53 Revision 0fa5b842: prefer '= delete' over runtime exception: wuttke
09:49 Revision b808d8c7: restore dev-tools/edit/update-filename.py, and prevent automatic edits in some...: wuttke
09:40 Revision fe7f96bb: but don't rename WarningMessageService : IMessageService: wuttke
09:30 Revision 17a10be1: updated '@file': wuttke
09:28 Revision ff088748: renamed MessageService -> Logger. Old name evoked wrong ideas like inter-proce...: wuttke
09:21 Revision 6683f098: no need for "AlgorithmType" in each variable name, as all these variables sit ...: wuttke
09:17 Revision 4448bf93: new file Fit/FitKernel/AlgorithmNames.h so that Fit no longer depends on Core/...: wuttke
08:07 Refactoring #1419 (Resolved): move test code out of core: qGenerator.h has been removed since long.
TestMachinery/ has been moved to Test/Functional/ a few days ago.
Sta... wuttke
08:03 Feature #587: Investigate objective function alternatives.: the field is called "Priority", not "Importance" wuttke
07:57 Feature #587 (Long Term Idea): Investigate objective function alternatives.: wuttke
08:03 Feature #586: Investigate chi2-like objective functions: the field is called "Priority", not "Importance" wuttke
08:02 Configuration #1536 (Resolved): prevent Drupal from sending HTML mails with black horizontal head...: this was supposed to be solved in Sprint 31, but I continue to get such mails wuttke
07:52 Refactoring #1535 (Rejected): rm intermediate directory 'coregui': Currently, GUI/ contains only a few small directories, plus coregui/, which in turn contains the more important direc... wuttke
07:42 Refactoring #1428 (Sprint): Compactify code that handles parameters (use abstract mechanism inste...: I started with simplifying the interface IParameterized (branch 'parunit') ... wuttke

25 Jul 2016

00:18 Revision fb3c33fc: simplify: wuttke
00:04 Revision 2f09a14a: no need for unique ptr that is released two lines later: wuttke
00:00 Revision ce93ad48: relegate clearParameterPool to ParameterPool::clear: wuttke
23:10 Revision 88becabd: rm unnessary clearParameterPool(): wuttke
22:56 Revision d5eb9029: rm unnecessary #include; rm unnecessary clearParameters from FF's: wuttke
22:32 Revision 95b47b75: no need for IParameterized::printParameters(): wuttke
21:56 Revision 3b220f64: Basics mainly contains base classes; Tools contains utilities that are definit...: wuttke
21:29 Revision ee406a08: move a few files out of Tools/: wuttke
21:25 Revision d8f78b5e: ParameterPool.h no longer included through IParameterized.h: wuttke
20:59 Revision 3fc1daf3: IParameterized::m_parameters is now a pointer to ParameterPool.: wuttke
20:52 Revision 8fa2f8fa: mv non-trivial implementation from .h to .cpp: wuttke
20:46 Revision f01e8a9c: rm "TODO": wuttke
20:34 Revision b6f5e650: remove unused constructor, delete unused (and potentially confusing) operator=: wuttke
20:11 Revision ffb5ee17: avoid repetition: wuttke
20:05 Revision 5fb2e76b: moved class ParameterPattern into separate source files: wuttke
19:29 Feature #1534 (Rejected): === Parameter handling ===: Parameter handling needs a separate envelope tasks, because it cannot be subsumed under Core, Fit, or GUI: it concern... wuttke
18:53 Revision d22812f6: + function comment: wuttke
18:43 Refactoring #1527 (Resolved): simplify containsMagneticMaterial, printSampleTree, genPyScript: Resolved in 9e708f4af; ISampleVisitor no longer needed in Core. wuttke
18:41 Revision 9e708f4a: Merge branch 'sampletree' into develop: This resolves #1527, simplify contains...: wuttke
18:29 Revision 6b790150: PyGenVisitor is no longer a visitor: wuttke
18:23 Revision 6f00b47c: all labels are now set through template function ISample::containedSubclass<>(...: wuttke
18:15 Revision 09a65604: simplified handling of Roughness and FormFactors: wuttke
17:43 Revision 70b1a624: new templated function ISample::containedSubclass(), not yet used: wuttke
17:13 Revision d377f134: corr: wuttke
17:01 Refactoring #1514 (Resolved): Remove code duplication in Distributions.h and .cpp: herck
17:00 Revision 31ce3980: in typedef materials_t: LabelMap<const IMaterial*> -> typedef std::map<const I...: wuttke
16:43 Revision a0bfda8c: plainly use operator== to identify two IMaterial's as equal.: wuttke
16:31 Revision f5d53830: ISample::containedMaterials() back to not-unique: wuttke
16:07 Revision 584a38f5: the same for setLabel...: wuttke
15:57 Revision d52cb25d: distinguish functions by names, not just by arguments: wuttke
15:30 Revision 8584e182: ISample::containsMagneticMaterial() now without use ISample::containedMaterial...: wuttke
15:07 Revision 8ca5d55f: compactify: wuttke
14:15 Revision 74192d35: pEqual(const IMaterial*, const IMaterial*) in IMaterial.cpp now fully replaces...: wuttke
14:09 Revision 57aba62a: insertMaterials moved from visit() to top-level; for the moment, called on all...: wuttke
13:33 Revision 8c9f0518: ISample::containedMaterials() returns now a list of unique materials.: No harm for previous usein ISample::containsMagneticMaterial(),
and prepares for use in Python code dump. wuttke
12:40 Revision 69dd49be: merge a few lines into PyGenVisitor(): wuttke
10:47 Revision 0c052b0e: while -> for in Export: wuttke

23 Jul 2016

19:25 Revision 0803af25: prepare for refactoring Python export; simplify OrderedMap -> LabelMap, and mo...: wuttke
15:44 Feature #1533 (Rejected): implement missing Python export for MesoCrystal: If I see correctly, export to Python fails if the sample contains a MesoCrystal. wuttke
15:20 Revision 3ede6342: regenerated bindings; rm SamplePrintVisitor.*, which is fully replaced by to_s...: This resolves the second third of #1527 wuttke
15:04 Revision 416e7779: rm temporary test output: wuttke
14:41 Revision 49ce61e8: special versions of to_str: wuttke

22 Jul 2016

19:19 Revision 81b468c9: New implementation of ISample::to_str() basically works;: todo: migrate special cases from SamplePrintVisitor. wuttke
18:55 Revision 4e1fe5fa: Last improvement of output file before starting reimplementation.: wuttke
18:51 Revision 739822a7: ISample::to_str now takes optional argument indent: wuttke
17:20 Revision f726fec4: replace printSampleTree by to_str(), which returns a string => more flexible, ...: Temporarily, write all standard simulation trees to /tmp/StandardSampleTrees.txt to allow for persistence test in rei... wuttke
16:31 Refactoring #1527: simplify containsMagneticMaterial, printSampleTree, genPyScript: For containsMagneticMaterial, reimplementation went smoothly in no more than 20 lines, cff2abd. wuttke
09:44 Refactoring #1527 (Archived): simplify containsMagneticMaterial, printSampleTree, genPyScript: Try a lighter way to iterate through the children of a Sample. The current implementation of ISample::containsMagneti... wuttke
16:27 Revision cff2abd5: Reimplemented ISample::containsMagneticMaterial(), using novel ISample::contai...: Altogether less than 20 lines, vs 260 in SampleMaterialVisitor.* (plus dependencies thereof).
This resolves the first... wuttke
16:00 Refactoring #1532 (Rejected): clarify relation of PolDWBAMagCylinders2 and StandardSimulations/St...: wuttke
14:57 Revision 8d2749ce: Merge branch 'futests' into develop: further improvement of in-code documentat...: wuttke
14:56 Revision 0ad44226: mv PyCore/suite/PySuiteTest.cpp -> PyCore/suite/PyCoreTest.cpp; wrote or impro...: wuttke
14:31 Revision 6f51e6a6: rm BA_CORE_API_ from Test/Functional: wuttke
12:23 Revision 41038f39: Merge branch 'testing' into develop: wuttke
12:23 Refactoring #1526 (Resolved): replace "FunctionalTest" by more specific terms in several test mac...: Resolved in f5720767e. wuttke
11:37 Refactoring #1526: replace "FunctionalTest" by more specific terms in several test machinery classes: And rename FooTestSuite -> FooStandardTest, because it does not run a suite of tests, but one single test, taken from... wuttke
09:37 Refactoring #1526 (Sprint): replace "FunctionalTest" by more specific terms in several test machi...: wuttke
12:11 Revision f5720767: regenerate wrapper: wuttke
12:03 Revision 5d88e600: fix obvious bug in last renaming commit: wuttke
11:58 Revision 4e486969: rename subtest registries. This concludes resolution of #1526.: wuttke
11:53 Revision 4cb73254: rename FunctionalTestRegistry -> StandardSimulationsRegistry, FunctionalTestIn...: wuttke
11:48 Revision 4ad6edfb: rename TestSuite -> StandardTest (it does not execute a suite, but a single test): wuttke
11:30 Revision 51497d94: IStandardTest: class header comment summarizes architecture of standard functi...: wuttke
11:22 Feature #1004: GUI: revise tooltips in all GUI elements: Revise mechanism of storing tooltips in GUI.
Currently tooltips are stored/handled
* in corresponding SessionIt... pospelov
11:04 Revision b61268b5: rename TestMachinery/FunctionalTestSuite -> IStandardTest: wuttke
09:33 Bug #1509: Version string should be different for executables generated from 'develop', from feat...: this modification should also be propagated to the Doxyfiles wuttke
09:02 Refactoring #1419 (Sprint): move test code out of core: wuttke
09:00 Feature #601 (Rejected): === Investigate OpenMP/MPI/GPU ===: last open issue moved under #284: Fit wuttke
08:57 Feature #1290: === Core: framework ===: All tasks concerned with the simulation framework, not with the physical modeling (which goes under #1438) wuttke

21 Jul 2016

23:50 Revision 7aed11f7: mv Test/Functional/Utils -> TestMachinery in accord with lib name BornAgainTes...: wuttke
17:45 Revision 731b35ec: more explicit interface type ISubtestRegistry instead of generic IRegistry<IPa...: wuttke
17:42 Revision ccfbe0c9: Merge branch 'distributionsrefactor' into develop #1514: herck
17:41 Revision f72809ea: Remove code duplication in Distributions: herck
17:33 Revision 35a35939: mv PySuiteTest.* to specific test directory: wuttke
17:22 Revision d4ed6db6: regenerated bindings: wuttke
17:16 Revision aabcb3fa: Merge branch 'futests' into testing: wuttke
17:15 Revision 575cf5ca: mv Core/TestMachinery -> Tests/Functional/Utils: wuttke
16:07 Refactoring #1526 (Archived): replace "FunctionalTest" by more specific terms in several test mac...: CoreTestSuite and GUITestSuite reside under Test/Functional, and inherit from FunctionalTestSuite.
They take a subte... wuttke
15:51 Revision 57d747c1: improve class description of FunctionalTestRegistry: wuttke
14:19 Revision e9149d86: regenerate wrapper: wuttke
13:59 Feature #1525: consider parameters of types int, enum, bool: By enum I mean a finite set of keywords. This must not imply implementation using the C/C++ 'enum' datatype. wuttke
13:23 Feature #1525: consider parameters of types int, enum, bool: Enums are famous code smells in OO code. We already have too many of these.
Parameterizing the distribution for such... herck
12:22 Feature #1525 (Rejected): consider parameters of types int, enum, bool: Parameters of types enum would allow us to merge physical models, provided they have the same number of parameters, a... wuttke
13:52 Revision f43343bf: Merge branch 'fixwarnings' into develop: herck
13:51 Revision 1b20b0ef: Remove warnings related to defining a class with 'struct' and forward declare ...: herck
13:27 Refactoring #1497 (Sprint): Agree on new Core directory structure and class renaming to Rename ce...: pospelov
12:22 Revision 7f8d5b24: PySuite.cpp -> PyCoreTestSuite.cpp, forgotten in resolution of #1524.: wuttke
12:11 Revision a12fac50: let base class set name of test suite: wuttke
11:51 Refactoring #1524 (Resolved): "FitSuite" currently used in two different meanings: Resolved in 2a2856a wuttke
11:22 Refactoring #1524 (Archived): "FitSuite" currently used in two different meanings: "FitSuite" is a collection of fit routines, wrapped under a common API.
Currently, the name "FitSuite" is also use... wuttke
11:49 Revision 2a2856a9: In all of Tests/Functional, rename <Foo>Suite to <Foo>TestSuite, to avoid conf...: wuttke
11:23 Revision cf949f3a: correct class description: wuttke
10:00 Feature #1475 (Sprint): DOI for BornAgain: Seems easy once we are at GitHub. wuttke
09:56 Feature #1462 (Rejected): enforce zero tolerance for warnings: This question will naturally come up again when configuring the build server. No need to keep this issue open here. wuttke
09:54 Bug #1070 (Rejected): Unix should install to /usr/local/lib, not to versioned subdirectory: merged into #1476 wuttke
09:54 Refactoring #1476: Revise installation directory structure under Linux: I'll close #1070, which essentially said:
- Unix should install to /usr/local/lib, not to versioned subdirectory
... wuttke
09:30 Revision 256a00c5: Core subdirectory names: uniformly singular, except for Basics, Tools, Example...: wuttke
09:16 Revision d68c0df7: Merge branch 'includes' into develop: various simplifications (pointer usage, ...: wuttke
09:15 Revision 724fd754: merge Visitors/ into Samples/: wuttke
09:09 Revision 63f76efc: mv DoxygenLayout.xml -> layout.xml (directory name is specific enough; facilit...: wuttke
09:04 Revision 17af3fea: rm Doxyfile.default (unused and confusing);: the remaining Doxyfiles write to subdirectories html/std, long, dirgraphs wuttke

20 Jul 2016

18:38 Revision 9cbdeba7: for unique_ptr P, prefer 'if(P)' over the equivalent 'if(P.get())': wuttke
18:22 Revision b185fe59: resolve inline: wuttke
17:49 Revision 05081976: Merge branch 'testing' into develop: wuttke
17:34 Revision 302b06fc: Merge branch 'includes' into testing: correct headers; move SimulationOptions ...: wuttke
17:29 Revision 83f7361f: and remove ki2Q (the former IInterferenceFunctionStrategy::getQ) for good, as ...: wuttke
17:28 Revision 174df595: mv IInterferenceFunctionStrategy::getQ -> Bin1DCVector::ki2Q: wuttke
17:09 Revision add07ce7: simplifications here and there: wuttke
16:58 Configuration #1447 (Sprint): Migrate to GitHub: pospelov
16:47 Revision 9164426c: rm duplicate function requiresMatrixRTCoefficients(): wuttke
16:44 Revision 53336c87: 'auto' for overlong iterator types: wuttke
16:40 Revision 09850a37: mv Simulation/SimulationOptions.* -> Basics; correct '@file' entries from last...: wuttke
16:19 Revision 537fe53b: Merge branch 'testing' into develop: + #include<stdexcept> required by TeamCity: wuttke
14:11 Revision e7fcea0c: minor edits while TeamCity broken: wuttke
13:59 Revision 32293b8e: edit just to trigger reload: wuttke
13:42 Revision 695d1e55: repaird (add missing #include<stdexcept>);: finer sorting of include's (C before C++) wuttke
13:28 Revision d4c25a75: error detected by TeamCity: wuttke
13:14 Revision d24b3896: Merge branch 'testing' into develop, based on 'newdirstruct2':: - increased number of subdirectories of Core/
- moved files between subdirectories to minimize dependences
- use in... wuttke
13:04 Revision cca0f648: little edits: wuttke
12:02 Revision e830ddd9: further decoupling from Units.h: wuttke
11:44 Revision c1d669a1: decoupled Lattice.h from ISelectionRule: wuttke
11:34 Revision ef808430: repaired: wuttke
11:24 Revision 2faba9ed: auto-generated comments "inheriting from": wuttke
10:57 Bug #1511 (Resolved): Roughness simulations give incorrect scattering contribution below the samp...: herck
10:56 Revision 2bfd6dba: Merge branch 'roughnessbug' into develop: herck
10:54 Revision cd0d7cc6: Return zero intensity below horizon for roughness simulation: herck
10:21 Revision cffe50dc: one further move; XML regenerated: wuttke
10:11 Revision 70602469: rm further dependence on Units: wuttke
10:09 Revision 86f3e064: new directories Core/Bins, Core/Mask: wuttke
09:44 Revision c688831d: Units.h must be included explicitely: wuttke
09:10 Revision 60d49609: rm dependence on Numeric, cmath, limits, iostream from many source files: wuttke
08:00 Revision edaef8c0: resolve inline's: wuttke

19 Jul 2016

00:14 Revision f63655a7: Further decoupling.: wuttke
22:52 Revision 1ff0f8b5: Fix 'warning: moving a local object in a return statement prevents copy elision': herck
22:33 Revision 264bc610: Fix compilation errors from missing includes: herck
21:16 Revision 00a26f9c: Resolved some inline's: wuttke
20:08 Revision d479fefd: decoupling this and that (preparing for ISample.h without ISampleVisitor.h): wuttke
19:17 Revision fc3d8a47: update-filename: suppress leading ./: wuttke
19:15 Revision a20d439a: '@file': rm leading './': wuttke
19:10 Revision 8cb28b39: include guards in Tests, further repairs: wuttke
18:51 Revision 6bc0674c: Sort include blocks: wuttke
18:50 Revision 618d1d60: updated '@file': wuttke
18:48 Revision 2c7d24b1: update include guards: wuttke
18:44 Revision c9865b66: Sorted include blocks: wuttke
18:27 Revision bf08f202: completed removal of inline 'class' declarations: wuttke
17:59 Revision 0680ece3: Layer.h no longer indirectly included: wuttke
17:31 Revision 95d29493: ctd: wuttke
17:21 Revision 873015c6: further decoupling: wuttke
17:00 Revision 137e4823: ctd: wuttke
16:48 Revision 53cca046: ctd; rm #include "IMaterial.h": wuttke
16:29 Revision c20b4547: take Rotations.h out of IMaterial.h: wuttke
16:24 Documentation #1523 (Resolved): explain numeric value of HomogeneousMagneticMaterial::m_magnetic_...: numeric value in the code comes without any explanation wuttke
16:14 Revision d977adb6: Move 'class' from variable declaration, function return types, and function ar...: wuttke
16:13 Documentation #1522 (Resolved): Create python example with polarized neutrons and magnetic materials: We do not have an example in Examples/python for polarized neutron case.
Withing this item
* create user example ... pospelov
15:49 Refactoring #1487 (Sprint): GUI: introduce ROI (region of interest) in MaskEditor: pospelov
15:48 Feature #1478 (Sprint): Refactor FitParameterLinked to provide simultaneous fit of several sample...: pospelov
15:48 Refactoring #1489 (Sprint): Build: refactor fix_apple_bundle for the production of MacOS installer: pospelov
15:47 Bug #1498 (Sprint): Fitting in GUI: values for all fitting parameters are reported as the same: pospelov
15:47 Refactoring #1492 (Sprint): GUI: Unify WarningSignWidget usage across the whole project: pospelov
15:35 Revision 7b5011b7: forward class definitions for visitor classes in separate statements: wuttke
15:34 Documentation #1014 (Sprint): Manual: describe simulation with distributed parameters: Basing on experience learned from GISAS school, we need this tutorial soon. It is hard to explain the concept of "S... pospelov
15:24 Feature #1521 (Rejected): GUI: find the way for update notifier to not to rely on CHANGELOG: Our GUI's update notifier works as following:
* on every GUI start, if the user has "online update notification"... pospelov
15:09 Revision 9b8504de: update '@file' in header: wuttke
14:57 Revision 659c2476: update include guards: wuttke
14:47 Revision 2a416797: mv Visitor-related files to Core/Visitor: wuttke
13:50 Revision 2feef031: Merge branch 'develop' into HEAD: fixed all warnings.: wuttke
13:42 Bug #1520 (Archived): GUI: global progress bar seems to be not updating: When user runs a time consuming simulation, global progress bar in lower left corner is not updating. The normal pr... pospelov
13:09 Revision 15d751d6: Little repairs to get rid of warnings.: In particularly, derived sample visitor classes now are explicitly "using" ISampleVisitor::visit. wuttke
12:52 Revision 6b7389c9: even more debug messages; no way to understand the segfault: wuttke
12:05 Revision e81640cf: all warnings resolved; mesocrystal1.py still broken: wuttke
11:54 Revision 2623041c: still broken: wuttke
11:24 Revision 1f7ecf2f: repair -Werror=overloaded-virtual: "using ISampleVisitor::visit;": wuttke
10:54 Revision 4447b458: start reverting to forward class declaration in separate statements.: wuttke
09:34 Revision d86ab540: many more debug messages => strange fernwirkung: wuttke

18 Jul 2016

18:46 Documentation #1519 (Rejected): Linking failure of Ubuntu with Python installed via Anaconda bundle: Found an Ubuntu, there in addition to system Python there are two Anaconda's Python2 and Python3 bundles, all in PA... pospelov
18:28 Bug #1518 (Rejected): Build failure on Ubuntu with static version of fftw3 library: Found the Linux with fftw3 installed twice:
* in normal way via the package manager in /usr/lib, shared version ... pospelov
18:06 Documentation #1517 (Archived): Add the case with missed msvc2015 runtime library on Windows syst...: * see #1516
* also mention the case on Drupal's "Windows install instruction"
pospelov
18:04 Bug #1516 (Archived): Consider include of ms-win-runtime library into Windows installer: During GISAS tutorial 5 Windows laptops (out of 20) didn't have api-ms-win-crt-runtime-l1-1-0.dll library installed... pospelov
17:50 Revision d532a481: Merge branch 'hotfix-1.6.1' into develop: herck
17:50 Revision 35498041: Merge branch 'hotfix-1.6.1': herck
17:40 Revision a9df2270: plenty of debug messages: wuttke
15:56 Revision d0a6751f: files missing: wuttke
15:55 Revision 4cd69c67: GUI repaired; test 65 - mesocrystal1.py (SEGFAULT): wuttke
15:41 Revision 1cfb9f91: decoupled ISample from ISampleVisitor; GUI broken: wuttke
11:39 Revision 4047373f: Detector -> Instrument, now also including resolution computation: wuttke

17 Jul 2016

08:14 Revision a188af15: repaired: wuttke

16 Jul 2016

00:48 Revision 413cb3ee: broken after minor move: wuttke
00:41 Revision dbf6273c: remove generous includes from LayerStrategyBuilder.h: wuttke
00:28 Revision 71a9d773: simple moves, good improvement: wuttke
00:14 Revision 9edd351f: missing in previous ca 3 commits: wuttke
00:12 Revision b1383338: and one more: wuttke
00:01 Revision ecd8a47e: another one: wuttke
23:53 Revision a24000cf: moved another .h out of a .h: wuttke
23:20 Revision 71606d4c: went at great lengths to move further include out of Layer.h: wuttke
22:52 Revision 42d1488a: one .h out of .h: wuttke
22:43 Revision ddb0e9e0: further split; repair deletion of IIntensityFunction.cpp: wuttke
22:23 Revision d39f007b: further move: wuttke
22:17 Revision 0bcae9e4: split Multilayer from Assembly: wuttke
19:19 Revision 409dccdf: further shuffling; regenerated bindings: wuttke
18:49 Revision 931d3950: Further moves: wuttke
18:08 Revision fdf2963e: further decoupling of subdirectories achieved: wuttke
17:55 Revision b057590b: some decoupling of novel subdirectories: wuttke
17:27 Revision af752529: Samples,FormFactors -> new directories Multilayer,Assemblies,Particles,Material: wuttke
16:32 Revision de29aa31: FormFactorCrystal.h no longer includes Crystal.h: wuttke
16:15 Revision 7c8b410f: further decoupling: wuttke
16:07 Revision d43d8a51: no more Samples/*.h dependence on Reflections: wuttke
16:04 Revision b0511f6a: disentangle PyGen**: wuttke
15:29 Revision f36fcc48: further decoupling (includes moved from .h to .cpp): wuttke
14:50 Revision 084cd921: dependence of Reflections on Samples now only from .cpp files: wuttke
13:22 Revision effbb3e5: Beam belongs into Detector => Detector becomes independent of Simulation: wuttke
13:17 Revision 5be6d021: further decoupling of .h files: wuttke
12:57 Revision fe3d6d6e: decouple SpecularMagnetic: wuttke
12:47 Revision b49da6fd: less dependencies in SpecularMagnetic.h: wuttke
12:43 Revision c1ad1698: mv MultiLayer back to Samples.: wuttke
12:38 Revision e5c631f2: further decoupling, requires lots of explicit #include's in .cpp files: TODO: group some of them, like in HardParticles.h wuttke
11:28 Revision 945d2859: manual decoupling of include's; move Rotations back to Samples: wuttke
10:26 Revision d6515355: forward class declaration inside namespace does not work: wuttke

15 Jul 2016

18:15 Revision 0fcdffa4: Move Rotations.* to Vector; minimize dependences of Layer.cpp: wuttke
17:26 Revision df202056: mv a few files, much better decoupling: wuttke
16:32 Revision ac47caa0: Merge branch 'testing' into newdirstruct: wuttke
16:05 Revision db802db2: clueless reordering after failure of Eigen/StdVector: wuttke
15:44 Revision 6b101f30: include Eigen before stl: wuttke
14:43 Revision bc05bfe9: repairs fro TeamCity (cherry-picked from develop, and manually edited): wuttke
13:35 Revision 1ad23e7b: rebased on latest 'develop', added SoftParticles/SoftParticles.h: wuttke
13:29 Revision ac70844a: included QAction: wuttke
13:22 Revision fa036b73: minor hand edit: wuttke
13:22 Revision 4ab06ca0: correct tiff includes; further manual edits: wuttke
13:22 Revision 62259a14: manual editing (towards standardized #include order): wuttke
13:22 Revision 920a0621: rm empty lines and comments from some Core sources' includes blocks: wuttke
13:22 Revision 00be447e: sort #include<> before #include"" in Core/Tools; manually correct some #includ...: wuttke
13:22 Revision e14ecd75: sorted: #include<> before #include"" in all of Core: wuttke
13:22 Revision 07a4dfe9: further sorting (this.h to the end) in Core/Tools;: manual editing: operations that require #include<cmath> moved from .h to .cpp wuttke
13:22 Revision 42e4811f: ditto in FormFactors; manually moved #include "IntegratorComplex.h": wuttke
13:22 Revision b27ba733: regenerated Swig bindings; no problem with removal of forward declaration that...: wuttke
13:22 Revision bd38fe70: ditto in Algorithms, with some manual editing: wuttke
13:22 Revision 634d6890: sorted all of Core, some manual editing: wuttke
13:22 Revision b0ef48d4: manual corrections: wuttke
13:22 Revision 5d6656d2: correcting recent commit: wuttke
13:22 Revision 609c69c4: Terminal sorting of Core (now subdirectory <>-includes after plain ones); rege...: wuttke
13:22 Revision 91961407: sorted #include's in Fit, some manual editing: wuttke
13:22 Revision 22b335c5: sort #include's in GUI/coregui/Views/ top level: wuttke
13:22 Revision 2006bd3c: sorted includes in GUI except in Models; little manual editing: wuttke
13:22 Revision 1ea506f6: sorted the other way: "" come before <>: wuttke
13:22 Revision e1eb0acc: corr previous commit, only now it builds: wuttke
13:22 Revision ca9e6f2c: corr code line length: wuttke
13:22 Revision d3b41723: rm unused forward declaration: wuttke
13:22 Revision 5a1c756c: rm 1 unused #include: wuttke
13:22 Revision 815bf6dd: + Doxyfile.dirgraphs, to analyse directory dependences: wuttke
13:22 Revision 9ab3bfba: rm 26 spurious #include's: wuttke
13:22 Revision d979dd8e: corr, only now it builds: wuttke
13:22 Revision 7aa4a93c: further decoupling: wuttke
13:22 Revision da0caed2: split directories: wuttke
13:22 Revision 068dbaa5: Further decoupling, informed by Doxygen directory dependence graphs.: wuttke
13:22 Revision fc432e09: Further decoupling. Directory "Basics" depends on no other directory.: wuttke
13:22 Revision b28e1eac: Repair CMake (needs to know location of WinDllMacros.h). New script print-incl...: wuttke
13:22 Revision ba95ab24: Repair CMake (needs to know location of WinDllMacros.h). New script print-incl...: wuttke
13:22 Revision a9e17439: Much of Core now nicely decoupled.: wuttke
13:22 Revision 707747c8: Update @filename: wuttke
13:22 Revision be0cb5a5: rebased, still broken, XML won't autogenerate: wuttke
13:22 Revision dd510249: Manual corrections => all tests passed.: wuttke
13:21 Revision 95030f4c: corr: #include <QString> // need detected by TeamCity: wuttke
13:12 Bug #1512 (Resolved): GUI crashes when simulating for a lognormal distribution of wavelength with...: pospelov
13:09 Revision 806da856: added #include <QStringList> here and there: wuttke
12:55 Revision 7e2a0062: include <QtCore/QStringList> // need detected by TeamCity: wuttke
12:46 Revision 13759ef3: restart OutputData.* from 'master', just update exceptions: wuttke
11:45 Revision 9d1ab855: try numpy/numpyconfig.h: wuttke
11:25 Revision d4575dba: OutputData.h with its dummy typedef back to top: wuttke
11:20 Revision b6e03d2a: try #include <pyconfig.h>: wuttke
11:12 Revision bd0c1db1: "OutputData.h" included _after_ <Python.h>: wuttke
11:03 Revision d69c59ad: corrections around Python include: wuttke
10:43 Revision 7ba6f15e: template class definition needed by some compilers to construct const_iterator: wuttke
10:28 Revision 5807a3dd: use fpclassify to detect subnormal double: wuttke
09:38 Bug #1515 (Rejected): GUI: error in determination of size of imported tiff file causes crash of f...: How to reproduce:
1. Start BornAgain (1.6.1, hotfix)
2. Instrument-> Set nbins=981 (phi) and nbins=1043 (alpha)
3.... ganeva

14 Jul 2016

20:54 Revision 49e1e9aa: corr, only now it builds: wuttke
19:31 Revision e6c152af: Merge branch 'includes' of apps.jcns.fz-juelich.de:BornAgain into includes: wuttke
19:30 Revision 37c0e992: rm 26 spurious #include's: wuttke
18:51 Revision dd8ff143: + Doxyfile.dirgraphs, to analyse directory dependences: wuttke
17:48 Revision 85e5a0e5: rm 1 unused #include: wuttke
17:47 Revision 14176638: Fix exceptions because of delta limit of distributions: herck
17:42 Revision c23e08d1: rm unused forward declaration: wuttke
17:33 Revision 43f9ff73: corr code line length: wuttke
17:32 Revision 9d3e2bc2: corr previous commit, only now it builds: wuttke
16:24 Refactoring #1514 (Archived): Remove code duplication in Distributions.h and .cpp: herck
16:01 Revision 236d0be1: Return single sample for limiting cases of 1d distributions (when they become ...: herck
15:53 Revision b0bb8ad9: Change of branch name in vagrant/maverick: pospelov
15:43 Revision 8341bddd: sorted the other way: "" come before <>: wuttke
15:32 Revision 36c1e01c: More robust behaviour of ColorMapPlot on OutputData==0, should be refactored w...: pospelov
15:20 Feature #1513 (Archived): Provide more informational throw message from RealParameterWrapper.: Currently it throws with "Value not in range", so in GUI it is almost useless. Ideally it should give the name of p... pospelov
15:17 Revision dafc49a6: sorted includes in GUI except in Models; little manual editing: wuttke
15:16 Revision 0c35e3c2: New VERSION and CHANGELOG for hotfix. Fixed crash in ColorMapPlot in the case ...: pospelov
15:10 Revision e859682f: sort #include's in GUI/coregui/Views/ top level: wuttke
14:43 Revision 6438834d: sorted #include's in Fit, some manual editing: wuttke
14:24 Revision 6de443a8: Terminal sorting of Core (now subdirectory <>-includes after plain ones); rege...: wuttke
14:20 Revision a2fdad80: correcting recent commit: wuttke
14:18 Revision 59d7858e: manual corrections: wuttke
14:15 Revision 1cc3a4f4: sorted all of Core, some manual editing: wuttke
13:58 Revision 52f69080: ditto in Algorithms, with some manual editing: wuttke
13:48 Revision 3427673c: regenerated Swig bindings; no problem with removal of forward declaration that...: wuttke
13:44 Revision 3e471d29: ditto in FormFactors; manually moved #include "IntegratorComplex.h": wuttke
13:31 Revision 322bcd86: further sorting (this.h to the end) in Core/Tools;: manual editing: operations that require #include<cmath> moved from .h to .cpp wuttke
13:20 Revision 8aaeff7a: sorted: #include<> before #include"" in all of Core: wuttke
12:22 Revision 98363da9: sort #include<> before #include"" in Core/Tools; manually correct some #includ...: wuttke
12:17 Revision 0333586b: rm empty lines and comments from some Core sources' includes blocks: wuttke
12:05 Revision 09db3ea3: manual editing (towards standardized #include order): wuttke
11:34 Revision 67106673: correct tiff includes; further manual edits: wuttke
10:57 Revision ed2502dd: minor hand edit: wuttke
09:17 Revision 01570b3d: rm 1271 redundant #include's: wuttke

13 Jul 2016

20:18 Bug #1512 (Archived): GUI crashes when simulating for a lognormal distribution of wavelength with...: Reproduce:
Use cylinders and prisms example, create wavelength distribution log normal and set scale parameter to ze... herck
16:40 Revision f8ecb092: Repair previous commit. It seems, SCALARRTCOEFFICIENTS_H was used in two diffe...: wuttke
14:41 Bug #1511 (Archived): Roughness simulations give incorrect scattering contribution below the samp...: herck
11:58 Feature #1508: GUI JobView: reconsider location of activity view switch: However, before this can be set back to low priority, the tutorial should be updated to what is actually implemented ... wuttke
11:34 Feature #1508: GUI JobView: reconsider location of activity view switch: Perhaps then the solution will emerge from a larger reshuffling. Let's keep this issue with low priority and see how ... wuttke
11:19 Revision 2b544250: Made include guards uniform, using the command sc-intern/edit-scripts/update-i...: wuttke
11:02 Revision 04817763: rename GUI/coregui/utils/stringutils -> qstringutils to distinguish them from ...: wuttke

12 Jul 2016

23:21 Refactoring #1484 (Sprint): GUI: refactor InstrumentItem and DetectorItem: pospelov
23:21 Refactoring #1485 (Sprint): GUI: refactor InstrumentView: pospelov
23:20 Refactoring #1486 (Sprint): GUI: refactor SampleView: pospelov
21:13 Refactoring #1486: GUI: refactor SampleView: In general, my idea to have same dock menu switch, as in JobView (very right bottom corner). So the right-bottom co... pospelov
20:21 Refactoring #1486: GUI: refactor SampleView: Adding here Joachim's comments
By default (unless overwritten by more specific behavior) a right click pops ... pospelov
23:20 Refactoring #1488 (Sprint): GUI: provide integration of ImportDataView and InstrumentView: pospelov
23:20 Refactoring #1490 (Sprint): GUI: refactor JobView and IntensityData widgets: pospelov
22:32 Revision 73adc346: all include guards rewritten in standardized form using sc-intern/edit-scripts...: wuttke
21:00 Feature #1504: GUI: support standard control keys: This item should be extended to something more global. We can summarize here all shortcuts we have by now, and all ... pospelov
09:30 Feature #1504 (New): GUI: support standard control keys: * ^A: select all wigets
* ^V: paste previously cut widget(s)
* ^X: cut selected widget(s)
* ^Z: revert last action... wuttke
20:43 Feature #1503: GUI: provide intuitive way to insert layer into multilayer: Here are some clarifications:
You can drag-and-drop "Layer" from ItemsToolBox into a MultiLayer, when move it ou... pospelov
09:26 Feature #1503 (Rejected): GUI: provide intuitive way to insert layer into multilayer: Trying out the GUI in impatient beginner's mode (i.e. without reading the tutorial), I found the following:
Starti... wuttke
20:30 Feature #1505 (Rejected): GUI: move windows menu from right-click-popup to topbar "Windows" pulldown: I have moved your comment into #1486, where among other things I'm going to address this one too.
Let me reject th... pospelov
10:09 Feature #1505 (Rejected): GUI: move windows menu from right-click-popup to topbar "Windows" pulldown: By default (unless overwritten by more specific behavior) a right click pops up a menu window that allows to choose w... wuttke
20:16 Feature #1508: GUI JobView: reconsider location of activity view switch: True, tutorial was not updated yet. I also agree, that lower right corner is not most intuitive place. The problem ... pospelov
12:07 Feature #1508 (Rejected): GUI JobView: reconsider location of activity view switch: Current location of button that activates the Job View Activity menu is at bottom right.
This it at variance from ... wuttke
19:54 Feature #1510 (Rejected): replace "Houston, we have a problem": I added this task into bigger issue #1492. Rejecting this one.
pospelov
14:34 Feature #1510 (Rejected): replace "Houston, we have a problem": funny enough for the lifetime of one release, but not the permanent solution, I suppose wuttke
19:52 Revision f54390eb: script file names uniformely with hyphen, not with underscore: wuttke
19:49 Feature #1506: GUI Sample Tree View: cut / paste or move to be added to right-click popup menu: The "move" functionality was there already (not as a context menu, but rather natural hold-click-and-move), but was... pospelov
10:14 Feature #1506 (New): GUI Sample Tree View: cut / paste or move to be added to right-click popup menu: The ight-click popup menu in the Sample Tree View should provide a means to move items around. Either using a cut/pas... wuttke
19:46 Revision 1f4168e2: rename some subdirectories of dev-tools: wuttke
15:41 Refactoring #1477 (Resolved): Provide more detailed info on Exception thrown from Polyhedron base...: Resolved in 7450e48. wuttke
15:30 Refactoring #1477 (Sprint): Provide more detailed info on Exception thrown from Polyhedron based ...: wuttke
15:40 Revision 7450e48b: More explicit error messages from FormFactorPolyhedron and FormFactorPrism.: This resolves #1477. wuttke
14:30 Bug #1509 (Resolved): Version string should be different for executables generated from 'develop'...: This we have discussed previously, but I have to come back to it:
An executable that differs, at times even consid... wuttke
13:47 Revision bbe0d153: rm "using Exceptions" from Exceptions.h: wuttke
11:41 Documentation #840: Create movie with first GUI tutorial: I removed the following from http://bornagainproject.org/documentation/usage/gui: »The following video presents how t... wuttke
11:34 Feature #1507 (New): GUI: SHIFT+LeftClick should add to selection: In Sample Editor and Sample Tree View, LeftClick selects one item.
As per de factor standard for GUI behavior, SHI... wuttke

11 Jul 2016

14:05 Feature #1238: nicer layout for newsletter@bornagainproject.org (reopened: v1.6.0 round mail stil...: reopened: round mail announcing v1.6.0 still had black bars, and no horizontal margin wuttke
13:22 Configuration #1502 (Rejected): rebase all branches after release (change release script or instr...: 'develop' and any living feature branch should at any time contain the common history at least up to the latest relea... wuttke
12:58 Configuration #1501 (Archived): version tag must start with 'v' (change release script or instruc...: Per agreement with Cristiano Feldero, version tags should always start with 'v'. Hence 'v1.6.0', not '1.6.0'.
Is t... wuttke

07 Jul 2016

11:27 Revision 46273d22: Added comment: herck
11:25 Revision 15263588: Merge branch 'nanbug2' into develop: herck
11:23 Revision 88a90009: Correction to overflow prevention in R,T coefficient calculation: herck

06 Jul 2016

17:59 Configuration #1500 (Rejected): MacOS: provide vagrant test box for El Capitan: * create vagrant box for El Capitan
** it will be used to test Mavericks dmg installer
** so it will have to cont... pospelov
17:56 Configuration #1255 (Sprint): MacOS: provide vagrant build configurations for Mavericks: * install buildslave to maverick box
* provide build configuration for making dmg (Python2)
* provide build confi... pospelov
17:54 Configuration #1344 (Sprint): MacOS: install buildslave to macmini: pospelov
15:57 Bug #1499 (Resolved): GUI Segmentation fault if layer is too thick: herck
15:57 Bug #1499 (Sprint): GUI Segmentation fault if layer is too thick: herck
09:46 Bug #1499: GUI Segmentation fault if layer is too thick: The crash happens only if the particle layout is present. ganeva
09:42 Bug #1499 (Archived): GUI Segmentation fault if layer is too thick: Users from Juelich would like to simulate a system with quite thick layers (in a micrometer range). However, BornAgai... ganeva
15:56 Revision 49c35e3a: Merge branch 'nanbug' into develop: herck
15:52 Revision 9b72c0c3: Fix complex overflows in SpecularMatrix: herck
15:28 Refactoring #995 (Rejected): New GUI buttons are badly visible under MacOS: I've made already two attempts to make this wonderful Walter's colored buttons works under MacOS and didn't succeed... pospelov
14:15 Revision 4d759954: Prevent overflows in T,R calculation for large layer thickness: herck
14:03 Revision 50658988: Refactor: removed code duplication: herck

Also available in: Atom