Activity

From 25 Jul 2016 to 23 Aug 2016

23 Aug 2016

23:09 Revision 1fe6629c: restore non-copyable status
wuttke
23:02 Revision afb43920: Possibly closed an important memory leak: were the DecoratedLayerComputation t...
New function MultiLayer::hasRoughness(). wuttke
22:54 Revision 0bcd919b: corrections
wuttke
22:47 Revision ec6bb6e6: merge IComputation into MainComputation
wuttke
22:30 Revision c1f1134b: simplify API of MainComputation
wuttke
22:23 Revision 2b7bc896: RoughMultiLayerComputation no longer inherits from IComputation.
wuttke
21:39 Revision fb28509d: improve API -> const &
wuttke
21:35 Revision 61ad3db5: DecoratedLayerComputation no longer inherits from ISimulation.
wuttke
21:08 Revision 7e858c5b: looks worse, but prepares for removal of ISimulation inheritance
wuttke
20:24 Revision 16095645: merge functions to prepare for further refactoring
wuttke
20:17 Revision dd3b2c99: rm inner try{..}; exceptions are still catched in MainComputation::run
wuttke
19:09 Revision a8a90e47: rm unused FastVector
wuttke
17:09 Revision d9bc9688: Regenerated Python API
herck
17:07 Revision 4eac87b1: Merge branch 'corrections' into develop
# Conflicts:
# auto/Wrap/libBornAgainCore.py
# auto/Wrap/libBornAgainCore_wrap.cpp
herck
16:08 Refactoring #1594 (Archived): Review and possibly refactor IFormFactor class hierarchy
It seems that conceptually all concrete IFormFactor classes (with the exception of the two DWBA form factors) could b... herck
15:43 Revision 0bbb28a2: Clarified comment
herck
15:32 Revision 89cb6313: Merge branch 'parunit' into develop: refactoring this and that
wuttke
15:31 Revision b15f6116: restrict namespace Geometry to masking.
wuttke
15:08 Revision af6291e3: implementation of cloneInvertB moved up to IRotation.
wuttke
14:39 Revision d3712204: Remove unused methods; replaced '.conjugate().dot(x)' with '.tranpose() * x'
herck
12:55 Refactoring #1593 (Archived): Remove soft particle constructors that have a volume argument inste...
There is a risk that users overlook the unusual meaning of the argument, and interpret the volume as a length.
Thi...
wuttke
12:27 Revision d5107615: rm unused FormFactorDecoratorMultiPositionFactor.
wuttke
08:33 Revision 0500a26d: mv call to containsMagneticMaterial() to where it is needed
wuttke
07:47 Revision 4a217a8e: add ../Basics/INoncopyable.h (missing in older commit); mv Computation -> ICom...
wuttke

22 Aug 2016

23:36 Revision 79880f24: m_outcome not used except in MainComputation
wuttke
23:05 Revision 2e13c355: Renamed MultiLayerComputation -> MainComputation, to distantiate it from Decor...
rm unused clone methods; introduce new basic mix-in INoncopyable.
This led to problems with SafePointerVector, which ...
wuttke
20:07 Revision 3021f4bb: rm intermediate class LayerComputation to achieve symmetry among the subclasse...
wuttke
19:50 Revision 44aa7e8d: rm unused
wuttke
19:20 Revision ef4c9319: Merge branch 'parunit' into develop: review Simulation; split off Computation.
wuttke
19:18 Revision 7b55f1f1: rm unused m_dwba_intensity
wuttke
19:12 Revision b7bbcada: rm unused getDWBAIntensity
wuttke
19:07 Revision bf971137: DWBASimulation -> Computation
wuttke
19:03 Revision 79000f39: Model -> Computation
wuttke
18:46 Revision 1a6f299c: ISimulation -> ComputationOutcome; root class -> mix-in
wuttke
18:32 Revision 3613ffd9: comments, ..
wuttke
18:02 Revision 03cc1cf4: virtual -> final
wuttke
17:57 Revision 5e087228: minor
wuttke
17:40 Revision 0a9b0104: Class comments: DecoratedLayerDWBASimulation and MultiLayerRoughnessDWBASimula...
are not alternatives, but contributions to MultiLayerDWBASimulation. wuttke
17:10 Revision 59703567: rm ISimulation.cpp
wuttke
17:07 Revision 59ea8a6c: rm unnecessary assert
wuttke
16:34 Revision f3eb69d1: start split Simulation/Model
wuttke
15:51 Revision 19e16156: minor edits
wuttke
15:19 Revision 53b7d60c: minor edits
wuttke
14:58 Revision 214b62ef: simplify Layer API
wuttke
14:09 Revision 14f412ba: New file IAbstractParticle.h separated from IParticle.h. rm unused includes. v...
wuttke
13:07 Revision e88f916e: rm unnecessary includes; vitual -> final; mv some .h files to includeCollections
wuttke
12:28 Revision c573f812: rm unnecessary includes
wuttke
11:31 Revision 21a309fc: mv SimulationElement and IPixelMap down the hierarchy => MultiLayer no longer ...
wuttke
11:22 Revision 5a536a3e: rm unnecessary include
wuttke
10:11 Revision 39016b84: Merge branch 'parunit' into develop: got rid of cyclic directory dependencies.
wuttke
10:03 Revision 81547f97: automatize export of distributions
wuttke
08:41 Revision d81810f4: parametrized sample better without default value
wuttke
07:44 Revision cd3bb3fd: usetex must be explicitly enabled in matplotlib 1.5
wuttke
07:42 Revision ac345a82: correct utils/plot_intensity_data.py (sys no longer provided by other imports)
wuttke
07:33 Revision e735fd97: more explicit directory names
wuttke

21 Aug 2016

19:54 Revision 77978073: rm a few more includes
wuttke
18:19 Revision c56eee73: mv INamed to Basics; refresh @file; regenerate bindings
wuttke
18:10 Revision fdc80c8a: Merge branch 'parunit' of apps.jcns.fz-juelich.de:BornAgain into parunit
wuttke
18:10 Revision babf91e0: mv containsMagneticMaterial() from ISample to MultiLayer
wuttke
15:31 Revision 0419823b: pass transform instead of rotation as function argument
wuttke
15:21 Revision 3586c14d: mv StringUsageMap to separate file in directory where it is used.
wuttke
15:10 Revision 4cec1204: rm unused include
wuttke
15:07 Revision d6beb762: replace double_epsilon by direct use of <limits>
wuttke
14:51 Revision 91d4b573: replace double_min by direct use of <limits>
wuttke
14:29 Revision ba2dff7f: Change math of areAlmostEqual: rm non-monotonic step from dependence on |b|.
wuttke
13:44 Revision dca1bf89: Simplify FitSuiteParameters::numbersDiffer; correct error in FitSuiteParameter...
wuttke
13:33 Revision 05f8e474: mv Numeric.* from Fit to Core; add private implementation 'numbersDiffer' to F...
wuttke
13:11 Revision 9eae4d20: regenerate bindings
wuttke
13:06 Revision 0cc2c651: Class comments; virtual -> final.
wuttke
13:03 Revision c2dff918: fix line length
wuttke
10:19 Revision 7a97a54f: improve class comments
wuttke

20 Aug 2016

23:58 Revision b5405de4: Reverted IFormFactorBorn to non-pure-virtual, because CustomFormFactor.py othe...
wuttke
20:48 Revision a842f4e1: FormFactorCrystal is an IFormFactor, not an IFormFactorBorn, since it evaluate...
wuttke
20:44 Revision 684c8d35: condense largely duplicate functions FormFactorCrystal::evaluate[Pol]
wuttke
20:21 Revision 0334dd69: new vector function real()
wuttke
19:27 Revision fd490c2c: SoftParticles virtual -> final
wuttke
19:18 Revision d088fe8a: Similar refactorings in FFDWBAPol and IFFBorn.
wuttke
17:50 Revision 7ab3315d: Merge duplicate wavevector evaluation from evaluate and evaluatePol into priva...
wuttke
17:13 Revision d499afc8: virtual -> final
wuttke
16:50 Revision 7ce02f33: With IFormFactorDecorator() =delete, there is no more need to test for mp_form...
wuttke
13:19 Revision 866e43c8: virtual -> final or nil
wuttke
12:40 Revision a96001d0: Use delegate constructor for isotropic DWF.
wuttke
12:35 Revision 4d626248: FormFactorDecoratorMultiPositionFactor::getRadialExtension() throws makes-no-s...
wuttke
12:22 Revision 01fc25c6: Class comments; Doxyfile corrections.
wuttke
10:53 Revision b80845f6: Class comments; update '@file'.
wuttke
10:46 Revision 809ddf81: Class comments; correct Doxyfile's; IFormFactor::accept -> =0
wuttke

19 Aug 2016

19:33 Revision a2bb970e: Regenerated bindings. Doxygen: merge brief and detailed description.
wuttke
19:22 Revision 4ee896d9: FormFactor -> FFDecorators; includes BornAgainNamespace from .h to .cpp; class...
wuttke
16:59 Revision b47dcfeb: Aggregate no longer knows about Multilayer.
wuttke
16:26 Revision 24020840: Further decoupling of directories: mv FormFactorDWBA* -> MultiLayer/
wuttke
16:22 Revision fe7d713e: No more need for directory Rotation. Move IFormFactorBorn to Sample.
wuttke
16:04 Revision b0074108: Magnetic materials needs only to know about Transform3D, not about Rotation. T...
wuttke
15:40 Revision 04b190b2: LayerStrategyBuilder needs only to know about MultiLayer, not about Simulation.
wuttke
15:12 Revision a4f0f0de: manual; regenerated bindings
wuttke
15:01 Revision e5effa07: Trying to clarify relation between Simulation classes.
wuttke
12:53 Revision 851dd3ea: rm spurious inheritance from ISimulation from reflectivity calculation classes...
wuttke
12:32 Revision e441491e: Move overlooked children of ISimulation back to Simulation/
wuttke
12:27 Revision db655b43: Move some files (back) down to Multilayer; class headers
wuttke
12:07 Revision cd1775f6: Make ISimulation pure virtual.
wuttke
11:45 Revision 9b534115: rm one-time used one-liners
wuttke
11:38 Revision f1018f69: getIn/OutCoefficients: argument is now Sim_Element instead of lambda,alpha,phi...
Tests written in terms of lambda,alpha,phi had to be disabled. wuttke
10:32 Revision b3be2098: minor
wuttke
10:02 Revision a8284399: include -> forward class declaration
wuttke
09:43 Revision bce67de4: moving SpecularInfoMap's
wuttke

18 Aug 2016

23:18 Revision 0964aa1a: minor edits (class comment, ..)
wuttke
21:34 Revision cb5c0b67: rm unnessary includes
wuttke
21:21 Revision 40038411: Move a few files so that Simulation is alone at second level of dependence hie...
wuttke
21:12 Revision 9b48a20a: similarly for DecoratedLayerDWBASimulation (not covered by any test??)
wuttke
21:07 Revision 9aa85ebd: simulation should know about sample model, not vice versa
wuttke
20:52 Revision 2be347c0: Consequently, rename ISampleBuilder -> IMultiLayerBuilder.
wuttke
20:37 Revision 7dbfc3ba: buildSample now returns MultiLayer* instead of ISample*
wuttke
19:15 Revision 7a1fb62c: Comments; throw exception upon inappropriate call of createDWBASimulation()
wuttke
17:44 Revision bb5ca15d: separate transformation of coordinates from transformation of intensities
wuttke
16:24 Revision f411dcf7: Revise manual section on detector geometry.
wuttke
14:34 Revision 3208bdc8: rm unused chapters. Improve draft mode, show index entries in margin
wuttke
12:42 Revision b46e7848: Merge branch 'parunit' into develop
wuttke
12:41 Revision 80420b6e: A few more virtual->final, protected->private. Start manual revision (reactiva...
wuttke
10:24 Revision 84ae9f3d: virtual -> final and other copy edits
wuttke
10:00 Revision 8e12243c: repair memory leak
wuttke
09:57 Revision a4e876f5: use delegate constructor
wuttke
09:44 Revision 867913c8: minor edits to InterferenceFunction1DLattice
wuttke

17 Aug 2016

23:51 Revision 3a746cb5: 11ify IShape2D and children (intended to enable automatic Python export, which...
wuttke
18:25 Revision 9cbfc32a: Merge branch 'tmp' into develop: first reaction to test coverage test results.
wuttke
18:24 Revision aec4eaf4: minor edits
wuttke
18:04 Revision b298e724: IMinimizer is now pure virtual
wuttke
17:11 Revision 0ce7e02a: rm unused.
wuttke
16:56 Revision 5a076456: rm unused Utils::String::getScientificDoubleString(double value, size_t precision
wuttke
16:54 Revision c3cadb2f: rm unused
wuttke
16:52 Revision 11c3b4cf: mv NumpyUtils to the only directory where they are used
wuttke
16:48 Revision fd547ed4: rm unused
wuttke
14:50 Revision 486973c2: Merge branch 'code-coverage' into develop
wuttke
14:33 Refactoring #1565 (Resolved): to associate units with parameters, use string instead of inheritance
Resolved in 07c2106.
The unit name is wrapped in by class Unit.
Parameter registration now has chain form, e.g.
r...
wuttke
14:29 Revision 62d3f524: Merge branch 'parunit' into develop: parameter registration now has form regis...
wuttke
14:28 Revision 07c21061: Completed conversion to new form of parameter registration. This resolves #1565.
wuttke
14:19 Revision 20c73beb: added code coverage options to cmake
jmfisher
13:53 Revision 26700852: broken (missing include)
wuttke
13:41 Revision 5f33a851: broken ...
wuttke
13:16 Revision 14140528: ...
wuttke
13:03 Revision 66128fd9: converting to registerParameter
wuttke
12:24 Revision 2af86480: ready for conversion to registerParameter().setLimited().setUnit()
wuttke
11:40 Revision 63d4fe1e: rm child classes of RealParameter; unit now stored as member variable of RealP...
wuttke
10:30 Revision b70cb098: rm erroneous duplicate line from example
wuttke
10:24 Revision a1ab53d4: Parameter(s) -> FitParameter(s) where appropriate
wuttke
10:06 Revision bce3561d: mv FitParameterLinked -> Core/Fitting/
wuttke
09:44 Revision a7ce3e2e: rm unused "virtual" from some FitParameter and FitParameterLinked methods.
wuttke
08:58 Revision d4de071d: mv Units -> Core/Parametrization/; regenerate bindings
wuttke

16 Aug 2016

00:02 Revision 36964865: AttLimits split -> Attributes & Limits
wuttke
17:52 Revision e06d284b: Merge branch 'doxrepair' into develop
wuttke
17:49 Revision e1cf0bdf: Correct Python for compatibility with Python3. Correct some @ingroup lines.
wuttke
15:43 Revision 7278aa0b: More explicit class comments on FTDistribution1D*
wuttke
15:15 Revision 2f405ae7: class comments on distribution normalization
wuttke
14:51 Revision 2a2e6637: copy editing decay/distribution functions: virtual -> final, rm destructor, in...
wuttke
13:45 Revision 82f57420: reworked Doxygen comments in Aggregate/
wuttke
11:26 Revision 6df22b3c: JAVADOC_AUTOBRIEF=YES in all Doxyfile's.
wuttke

15 Aug 2016

11:51 Revision 3a5973d2: Doxygen comments and other copy editing here and there
wuttke
10:04 Revision d44e337a: Normalize doxygen header of form factor classes
wuttke

14 Aug 2016

20:59 Revision b53e5492: new doxygen groups hardParticle & legacyGrating
wuttke
18:00 Revision 91150b38: Doxygen include file extension .doc -> .dox
wuttke

12 Aug 2016

16:00 Revision 6a5f87f7: New wrapper for GSL Levenberg Marquardt minimizer
pospelov
14:35 Revision 09853586: New GSLMultiMinimizer wrapper
pospelov
11:47 Revision 97ec3268: New MinimizerInfo for BaseMinimizer, which can be used in both, catalogue cons...
pospelov
10:19 Documentation #1589 (Resolved): Clone drupal website
Clone now on:
apps.jcns.fz-juelich.de/drupal8
herck

11 Aug 2016

18:05 Revision 71e70774: Correlation matrix now saved to FitParameterSet after fit is complete. Printin...
pospelov
17:41 Revision e1ace08c: FitParameter is a composition of AttLimits
pospelov
16:02 Documentation #1589: Clone drupal website
After some investigation, it seems that switching between two drupal sites is not the most effective way of achieving... herck
14:17 Documentation #1589 (Archived): Clone drupal website
The idea is to have two separate drupal websites:
-the one that is publicly available under our current web address
...
herck
15:49 Revision d96aef0a: PythonAPI regenerated
pospelov
15:19 Revision bcb447d9: MaxFunctionCalls added to Minuit2Minimizer
pospelov
14:37 Revision a25448de: Minor method move on the way to big reloccation.
pospelov
14:18 Documentation #1590 (Rejected): Update to drupal 8
After issue #1589 herck
14:11 Revision ea58729d: FitSuiteParameters renamed to FitParameterSet, additional convenience methods
pospelov
11:29 Configuration #1496: Switch Windows10 buildslave from virtual box to vagrant box
On hold until we fix the activation issue with the underlying virtual machine herck
11:14 Revision eb050c7d: FitSuite, FitKernel and IMinimizer switched to reportResults instead of printR...
pospelov
10:46 Revision 608c90a2: BasicMinimizer now reports edm and minValue, Minuit2Minimizer reports covarian...
pospelov
10:26 Revision b548c8de: New MinimizerOptions class, previous one renamed to ObsoleteMinimizerOptions
pospelov
08:34 Feature #1475: DOI for BornAgain
depends on #1447, is not a subtask thereof wuttke

10 Aug 2016

23:38 Configuration #1577 (Resolved): Qt qcreator navigation/recognition is broken for all unit tests
Hopefully resolved in 4b73a91:
Google test wrapper replaced by a lighter macro.
Now each unit test subdirectory h...
wuttke
23:38 Configuration #1577 (Sprint): Qt qcreator navigation/recognition is broken for all unit tests
wuttke
20:24 Configuration #1577: Qt qcreator navigation/recognition is broken for all unit tests
Some web discussions suggest qtcreator has a problem with absolute paths; relative paths might help with this kind of... wuttke
20:19 Configuration #1577: Qt qcreator navigation/recognition is broken for all unit tests
See also right-click-menu > Open Include Hierarchy (SHIFT+CTRL_I) on any source file.
For LayerTest.h, it says: In...
wuttke
23:35 Revision 4b73a91e: Google test wrapper replaced by a lighter macro. This resolves #1577.
Now each unit test subdirectory has an identical copy of main.cpp,
and a file testlist.h that consists of #include's ...
wuttke
20:25 Revision b8ccbe53: Merge branch 'iss1577' into develop; issue unresolved.
wuttke
20:22 Revision ca6b118d: revert to absolute paths, since relative paths didn't help.
wuttke
20:08 Revision 0a0827c9: try relative paths in an attempt to solve #1577
wuttke
18:08 Revision 34af441c: Error status is added to BasicMinimizer
pospelov
17:14 Refactoring #1440: cover Python examples by functional tests
Persistence test machinery is now working.
Still TODO:
* Explain new plot-or-save function in tutorial
* Cover r...
wuttke
10:20 Refactoring #1440: cover Python examples by functional tests

* -Now it is too late, but I would have a transition period about 1-2 month, when old tests are still in place, whi...
pospelov
17:04 Revision 9c5b4b51: Minuit2Minimizer class is equipped with statusString
pospelov
16:36 Revision 3a3b1ff9: COnfigurable renamed to OptionContainer, inheretance in IMinimizer is replaced...
pospelov
16:00 Revision 634c2272: Regenerated bindings
wuttke
15:53 Revision f5117117: Merge branch 'pychecks' into develop
wuttke
15:51 Revision 47f89ea8: repair recursive comparison of YAML entries (conversion from YAML::Node to str...
PyPersistenceTest/FitCylindersPrisms_detailed now works. wuttke
15:33 Revision 3da56e9d: New MinimizerResultsHelper for printing fitting results into the string
pospelov
14:51 Revision c0f1e431: Restore a few section comments; they are useful even after most details are go...
wuttke
14:41 Revision 4aa8e527: Finished conversion to boolean return value for runTest.
wuttke
14:25 Revision 18db28ef: Merge branch 'develop' into pychecks
wuttke
14:25 Revision 04e47f89: converting runTest() to return bool success.
wuttke
13:28 Revision a4a4d794: refactor glob2map into separate function
wuttke
12:46 Refactoring #1588: FitSuiteParameters inhibits Python iterator

* FitSuiteParameters has a lot of convenience methods (see FitSuiteParameters.cpp file)
** initially it was vector...
pospelov
10:44 Refactoring #1588 (Archived): FitSuiteParameters inhibits Python iterator
When controlling a fit from Python I would expect to be able to write... wuttke
12:38 Revision c098f261: refactor runPython into separate function
wuttke
12:22 Revision 49555c40: Merge branch 'ReviseMinimizer' into develop
pospelov
11:49 Revision d5c69d05: cleanup
wuttke
11:35 Revision 496344dd: New Minuit2Minimizer is functional, except printResults.
pospelov
11:29 Revision d71d9912: Merge branch 'pychecks' of a:BornAgain into pychecks
wuttke
11:24 Revision e402652e: correct alignement to prevent -Werror=misleading-indentation
wuttke
10:57 Revision 14b56537: One more fit example covered by functional tests. BROKEN: unexpected behavior ...
wuttke
10:51 Revision 96dcdfa5: MinimizerOption and Configurable classes equipped with unit tests.
pospelov
10:51 Revision 332a985b: On the way to refactoring Minuit2 minimizer options.
pospelov
10:51 Revision fc2dc309: New ExperimentalFit functional test on the way to minimizer refactoring
pospelov
10:51 Revision 0caca000: New experimental MinimizerOption class
pospelov
08:25 Revision 711eb046: Fit example ex01_SampleParametersIntro/SampleParametersIntro.py now covered by...
wuttke

09 Aug 2016

19:10 Revision 0693f6a9: PyPersistTest now compares dat and ref YAML tree entry by entry, allowing for ...
Still to do:
- allow for "VARIABILITY" anywhere in the tree
- generate YAML output from Fit tests.
wuttke
17:05 Revision 3927cab9: New Minuit2Minimizer is functional, except printResults.
pospelov
15:53 Revision b317cdfa: broken, whil implementing yaml parsing
wuttke
15:24 Revision 92f486ed: SpecularSimulation now writing all absolute values of R and T to YAML.
wuttke
14:55 Refactoring #1584 (Resolved): replace deprecated "exec_program"
Resolved in a96b53b. Deprecated command was left in UseLATEX.cmake, which is third party code, and should be updated ... wuttke
14:54 Refactoring #1584 (Sprint): replace deprecated "exec_program"
wuttke
14:38 Refactoring #1584 (Resolved): replace deprecated "exec_program"
in cmake modules, by "exec_process" wuttke
14:53 Revision 8b1067ed: deprececated exec_programm replaced by execute_process, except in UseLATEX.cma...
wuttke
14:35 Revision 63898c49: Persistence tests now writing non-int output in true YAML format.
wuttke
13:48 Revision d65762eb: New ExperimentalFit functional test on the way to minimizer refactoring
pospelov
13:36 Refactoring #1440: cover Python examples by functional tests
In e7f0a6d, removed redundant legacy tests. The remaining ones will be left as they are, for the time being. wuttke
13:34 Revision e7f0a6df: Merge branch 'pychecks' into develop: rm legacy tests that are covered by exam...
wuttke
13:23 Bug #1583 (Resolved): PyPersist tests fail if build directory path contains a '.'
Resolved in 4308c882, with correction in 464491f.
Restored compilation on scgmini.
wuttke
10:59 Bug #1583 (Archived): PyPersist tests fail if build directory path contains a '.'
wuttke
13:22 Revision fe53aee4: rm customformfactor.py, covered by more mature example ex04_ComplexShapes/Cust...
wuttke
13:18 Revision 6987eed1: rm montecarlo_integration.py, covered by ex04_ComplexShapes/LargeParticlesForm...
wuttke
13:15 Revision 4a548bb2: Remove legacy tests that are fully covered by examples:
layerwithroughness.py covered by ex02_LayeredStructures/CorrelatedRoughness.py
detector_resolution.py covered ...
wuttke
13:07 Revision 464491fb: Correct 4308c88: one path decomposition was not yet converted
wuttke
12:40 Revision 67518eae: Merge branch 'pychecks' into develop
wuttke
12:39 Revision 4308c882: Correct decomposition of paths in PyPersistenceTest to allow for directories t...
wuttke
11:29 Revision 85a47f51: correct previous commit; remove last M_PI in our own code (there are still a f...
wuttke
11:25 Feature #1564 (Resolved): split "Pi.h" from Units.h
Resolved in 775c0c6. wuttke
11:24 Revision 775c0c60: Pi.h with namespace Pi taken out of Units.h. This resolves #1564.
wuttke
10:41 Refactoring #1550 (Resolved): in .h file header comments, replace »Declares« by »Defines«
Resolved in 52d6c6f. wuttke
10:39 Revision 52d6c6f5: Correct .h file header comments: "Declares" -> "Defines". Also remove include ...
wuttke
10:27 Bug #1552 (Resolved): FormFactorTrivial should have RadialExtension = 0
Resolved in 179f427562. wuttke
10:21 Revision d67a6e11: Merge branch 'testing' into develop
wuttke
10:04 Revision 693948b5: Merge branch 'pychecks' into testing
wuttke
09:56 Revision 1bea2b68: class Utils::FileSystem -> namespace FileSystem
wuttke
09:51 Revision 7353a089: rm unused functions from FileSystem; member variables not needed any more.
wuttke
09:39 Revision 179f4275: FormFactorTrivial (to become »Dot«): radial extension corrected to 0. This res...
wuttke
09:30 Revision 72c0e47e: in error message that should never be raised: "BUG" -> "Bug"
wuttke
08:53 Refactoring #1582 (Resolved): Correct model for dense particles on surface
This is more of a question then a change request, maybe a request to update the documentation:
All example models ...
a.glavic
08:34 Refactoring #1581 (Rejected): get... -> create... if new pointer is returned
wuttke
08:33 Refactoring #1545 (Rejected): INamed: replace default "" by typeid()
won't work as typeid() will return "INamed", not the name of the child class wuttke

08 Aug 2016

18:01 Bug #1580 (Resolved): Core: ParticleComposition with destructive interference (selection rules no...
As first step to simulated AF spin arrangements on a square lattice I have tried to duplicate the simple single parti... a.glavic
17:13 Revision 1523e667: On the way to refactoring Minuit2 minimizer options.
pospelov
16:16 Feature #1579 (Resolved): provide trapezoid resolution function to describe instruments with neut...
Many small angle neutron instruments use velocity selectors to monochromize the beam. These typically generate a tria... a.glavic
16:01 Refactoring #1578 (Backlog): Core: FF: reimplement ripples as Cartesian product Profile * Decay
with FF(x,y,z) = Profile(x,z) * Decay(y),
n profiles and m decay functions allow n*m combinations, while only n+m+1 ...
wuttke
15:58 Feature #1575 (Rejected): INamed: promote member m_name from private to protected
No convincing case for change. wuttke
15:56 Revision 2521571c: MinimizerOption and Configurable classes equipped with unit tests.
pospelov
15:56 Bug #1571 (Resolved): PyCoreTest overlooks complete obstruction of simulation
Errors now do appear in the CTest output.
Insensitivity of the tests to empty simulation output cannot be confirmed....
wuttke
15:54 Feature #1573 (Resolved): facilitate plotting from Python scripts exported by PyCore tests.
Resolved in 98163aa0d. wuttke
15:51 Refactoring #1440: cover Python examples by functional tests
Mostly done in ef783ff2b.
Still todo:
* -implement meaningful check for YAML output-
* write meaningful YAML outpu...
wuttke
15:36 Revision ef783ff2: Merge branch 'testing' into develop: Examples/python/simulation now covered by...
wuttke
15:35 Revision 8d8d5231: correct '@file' lines and include guards
wuttke
15:34 Revision 6dd766e2: Merge branch 'winlinkfix' into develop
herck
15:31 Revision 76d65304: correct class comment
wuttke
15:20 Revision 447a8a7d: Meaningful persistence tests in place for all Example/python/simulation, excep...
wuttke
12:20 Configuration #1483 (Rejected): Fix shuwdown of Windows10 build slave
Rejected because fix will be automatic after issue #1496 herck
12:18 Configuration #1577 (Archived): Qt qcreator navigation/recognition is broken for all unit tests

Qt creator doesn't know about Core/Fit include files, auto completion is broken for all BornAgain classes in the co...
pospelov
11:55 Revision 67316ba0: Add missing references. Introduce threshold as additional argument to RunPyPer...
This is, however, no good solution because one test may write several intensity maps with different reproducibility l... wuttke
08:34 Bug #1574 (Rejected): Find the way of comfort work in Qt creator in the absence of some headers
Setting status rejected, even if it is rather "resolved". Only Sprint item can be turned into "resolved". But this it... pospelov

07 Aug 2016

22:59 Revision 8ce5b321: Persistence tests fully functional. Still TODO: check error messages.
wuttke
21:08 Revision 3ab140fc: Refactoring in order to improve error messages; setting of threshold is broken.
wuttke
17:55 Revision a57242af: minor cleanup; regenerate bindings
wuttke
17:34 Revision ce23e8bd: IntensityDataFunctions::getRelativeDifference has now same implementation for ...
wuttke
14:55 Revision 1e2a5c37: Non-intensity files must not be compressed.
wuttke
12:55 Revision ab7bb320: Comparing yaml files line by line. TODO: ungzip.
wuttke
11:38 Revision 95e1c72f: restore unit tests; new CMake option ZERO_TOLERANCE
wuttke
10:58 Revision 14f5ed36: all fu tests pass but no actual persistence tests performed
wuttke
10:45 Revision 7b617574: persistence test machinery now prepared to handle aribtrary file extensions
wuttke

06 Aug 2016

13:49 Revision 4a204d15: rm TestUtils.
wuttke
13:41 Revision c47b5b26: ad-hoc repair for polmagcylinders2.py
wuttke
13:31 Revision 88ec7ee3: all except 3 tests pass
wuttke
13:11 Revision b22363cf: corrections, renamed Standard reference files
wuttke
11:52 Revision d7f4ea2c: rm unused flatFilename
wuttke
11:50 Revision aae9fd4d: repairs
wuttke
11:27 Revision cadd0e4d: Use directory hierarchy instead of prepended "ref_" or "pyexport_"
wuttke
09:27 Revision a09fb6a1: Persistence test now able to read multiple data and reference files; detects m...
wuttke

05 Aug 2016

22:39 Revision db56ac7a: rm direct python include (CorePython.py) from libBornAgainCore.i: we use the C...
wuttke
22:35 Revision 83ca80a5: starting comparison ... not yet for examples with multiple output
wuttke
20:50 Revision 60a60b2f: Merge branch 'testing' into develop: persistence testing framework for Py exam...
wuttke
20:44 Revision 9d78dd7d: moved three (hopefully last) matplotlib imports out of the functional test's way
wuttke
20:40 Revision b6c9c91f: moved new Py functions to plot_utils.py
wuttke
20:13 Revision 9e52735b: We do not want a sys.path=... command in each example. Therefore in PyPersiste...
wuttke
20:00 Revision 29a57b1b: rm unused "import os" from exported Py scripts; tmp files now named "pyexport_...
wuttke
19:54 Bug #1576 (Resolved): bornagain/__init__.py must not require matplotlib
Resolved in 40607ef. wuttke
19:53 Bug #1576 (Archived): bornagain/__init__.py must not require matplotlib
Functional tests must not require matplotlib to work.
Actually, there is no matplotlib on our apps server, and our...
wuttke
19:54 Revision 40607ef4: plot_utils no longer requires matplotlib (import moved into DefaultFitObserver...
wuttke
19:35 Revision 5dc75b25: rm outcommented; regenerate bindings
wuttke
19:06 Revision 71c844a3: rm outcommented; regenerate bindings
wuttke
18:49 Revision f439b669: corr: don't require matplotlib for functional test
wuttke
18:36 Revision d4e0c230: Merge branch 'pychecks' into develop
wuttke
18:34 Revision 50c87bf5: All simulation examples now take argument -p or filename. All fitting examples...
wuttke
18:04 Revision dca66a1a: ...
wuttke
17:43 Revision 216766f8: repair this and that
wuttke
16:50 Revision da8c22fb: last repair of faulty replacement of "map."
wuttke
16:50 Revision d6535d8f: repair
wuttke
16:48 Revision 168ed727: corr
wuttke
16:42 Revision e3f1f43c: restore AxesInDifferentUnits.py, not yet convertible
wuttke
16:41 Revision 6bfb9632: convert further examples
wuttke
16:24 Revision ecca5d3e: Converted ex01-ex04; the others temporarily broken
wuttke
15:54 Feature #1475: DOI for BornAgain
we got green light from FZJ library not to wait for them but to use the extrenal solution offered by GitHub wuttke
15:42 Revision c9deabe2: Make all Python code more concise with function simulate_then_plot_or_save.
wuttke
15:38 Revision 67b2ea05: Make TestMachinery into static library to avoid BA_CORE_API_ macros for Window...
herck
15:33 Revision 44137c8a: Fix some linking errors on Windows because of lack of exporting library symbols
herck
15:11 Revision 19581e54: New experimental MinimizerOption class
pospelov
14:57 Revision 1b75c065: converted example 3: CylindersInBA.py
wuttke
14:57 Revision 234d1487: Merge branch 'WinDllMacro' into develop
pospelov
14:47 Bug #1574: Find the way of comfort work in Qt creator in the absence of some headers
Ok, returned back WinDll macros. Qt qcreator is happy again in both, finding and highlighting. I think in general for... pospelov
13:42 Bug #1574: Find the way of comfort work in Qt creator in the absence of some headers
Found another issue in Qt creator: "find usage" often is not working. It finds something, but not everywhere. It wasn... pospelov
14:45 Revision 51dce7b5: further simplified ExportToPython; converted example 2 CylindersAndPrisms.py
wuttke
14:37 Revision 5bb92c91: Fixing macmini build error. Can "inline" keyword in wrong place be the problem?
pospelov
14:27 Revision 6dffeeeb: Simplified auto-generated scripts from ExportToPython; prepared first Python E...
wuttke
14:20 Revision 01b00b45: Fixing long waiting compilation errors under macmini.
pospelov
14:17 Revision cd2bcaf7: WinDllMacro is back
pospelov
12:24 Revision 99aa28ce: Resolving #1440: CMake part done. C++ part half done. Still TODO: (C++) compar...
wuttke
11:38 Feature #1575: INamed: promote member m_name from private to protected
There is no need, obviously, but it might be convenient.
There is no implementation, and there will never be one. ...
wuttke
11:26 Feature #1575: INamed: promote member m_name from private to protected
There's no need to expose it since derived classes can set it directly using setName(...). Exposing it would expose t... herck
11:23 Feature #1575 (Rejected): INamed: promote member m_name from private to protected
This member variable has many good uses in inherited classes, so why not expose it to them? wuttke
11:02 Revision a0c91603: CMake configuration basically ready for Examples persistence tests; unit tests...
wuttke
10:10 Revision e9a2a580: Start PyPersistenceTest, to resolve #1440
wuttke
10:07 Refactoring #1490: GUI: refactor JobView and IntensityData widgets
*Bug in the widget for projections:* units in projections are not changed according to the units of the plot. To repr... ganeva
09:29 Revision af2ca294: rename PyCoreTest -> PyExportTest to leave room to other tests of Python Core ...
wuttke

04 Aug 2016

21:47 Revision bb24be6c: rm unused; regenerate bindings
wuttke
21:24 Refactoring #1440 (Sprint): cover Python examples by functional tests
Now I know how to do it. Each example, depending on its argument, shall either plot or write to file. The latter beha... wuttke
17:58 Bug #1571: PyCoreTest overlooks complete obstruction of simulation
Resolved in cdc32a6, except for the possible failure to detect zero-filled detector images. wuttke
16:22 Bug #1571 (Sprint): PyCoreTest overlooks complete obstruction of simulation
wuttke
17:55 Revision cdc32a6f: PyCoreTest now writes concise log lines, and by some miracle Python errors als...
wuttke
17:43 Feature #1573: facilitate plotting from Python scripts exported by PyCore tests.
Resolved in 98163aa. wuttke
17:40 Revision 98163aa0: Python script, generated by ExportToPython, now takes argument '-p' for plotti...
wuttke
17:02 Revision 9cf72b7b: Merge IFunctionalTest::analyzeResults() into IFunctionalTest::runTest() [Tests...
wuttke
16:11 Refactoring #1567 (Waiting): Core: FF: API: omit »FormFactor« from particle geometry class names
wuttke
15:27 Refactoring #1567: Core: FF: API: omit »FormFactor« from particle geometry class names
Next question then, whether to put them in a namespace. wuttke
15:53 Refactoring #1548 (Waiting): choose name for fit library
Opinion from first discussion: probably something less grandious than "FitSuite". wuttke
15:52 Refactoring #1547 (Backlog): restore ScanningMinimizer
So it shall be refactored and reintegrated into the minimizer selection wuttke
15:48 Refactoring #1549 (Waiting): rename class FitSuite
wuttke
13:23 Refactoring #1549: rename class FitSuite

I don't like FitController that much. It is also hard to explain users, why we have renamed FitSuite to something e...
pospelov
12:51 Refactoring #1549: rename class FitSuite
I vote for FitController herck
15:47 Refactoring #1550 (Sprint): in .h file header comments, replace »Declares« by »Defines«
Yes, replace »Declares« by »Defines«.
Remove ' // inheriting from'.
wuttke
12:49 Refactoring #1550: in .h file header comments, replace »Declares« by »Defines«
Not related to this one, but to headers auto-update procedure.
* where can I find code tools used for code auto up...
pospelov
15:46 Feature #1554 (Backlog): provide script to update Python files upon name changes in BornAgain
As one-time solution.
Later on, for lighter changes, backward compatibility should be ensured differently: obsolete ...
wuttke
15:42 Feature #1561 (Rejected): merge FTDistribution.. and FTDecayFunction..
They are different.
* Distributions are pdf's, normalized to integral=1.
* Decay functions do have f(0)=1.
wuttke
15:41 Feature #1564 (Sprint): split "Pi.h" from Units.h
There is definitely no PI in the C++11 standard, so we go for Pi.h. wuttke
15:25 Refactoring #1569: Core: FF: API: rename hard particle form factors
After first discussion, tendency to answer the $-question with yes: In principle, special cases of generic shapes mer... wuttke
15:22 Refactoring #1565 (Sprint): to associate units with parameters, use string instead of inheritance
member variable of type string is perhaps not the best solution, but in any case a valid first approximation, and wil... wuttke
13:47 Refactoring #1557 (Rejected): FitParameterLinked causes weird coupling
refactoring done under other issue wuttke
13:03 Bug #1574 (Rejected): Find the way of comfort work in Qt creator in the absence of some headers
After removal of WinDllMacros.h from all headers (in the favor of its automatic include via cmake compilation keys), ... pospelov

03 Aug 2016

19:32 Documentation #1351: Drupal: update installation instructions, tutorials for coming release
I guess contents is not left over from 1.6, but refers to the next release? wuttke
19:31 Revision a2586621: Removed unused members from FormFactorInfo. This resolves #1556. Also moved im...
wuttke
19:29 Refactoring #1556 (Resolved): FormFactorInfo: remove unused m_pos_x, m_pos_y
Resolved in a25866219, i.e. removed the unused members. As for inheritance, I had soon understand on my own that this... wuttke
19:16 Feature #1564: split "Pi.h" from Units.h
Overlaps with #1304 ... wuttke
09:28 Feature #1564 (Archived): split "Pi.h" from Units.h
PI is not a unit, and used much more often, and typically in other contexts, than units.
So definitions of PI, PI2, ...
wuttke
19:15 Feature #1573 (Archived): facilitate plotting from Python scripts exported by PyCore tests.
PyCoreStandardTest generates scripts like <build>/tmp/pysuite_HexParaCrystal.py. Little changes to these scripts will... wuttke
19:05 Feature #1572: == Python ==
Covers
* Python bindings
* Export of Python scripts from Core
wuttke
19:02 Feature #1572 (Rejected): == Python ==
wuttke
19:05 Revision 4be1d3af: move fixed code snippets into constant strings, and into separate namespace.
wuttke
18:49 Bug #1571 (Archived): PyCoreTest overlooks complete obstruction of simulation
Let the Python function getSample(), exported by ExportToPython, return None instead of a multilayer. Then... wuttke
15:49 Revision 66309931: more explicit method name "simulationToPython"; change parameter name into "si...
wuttke
15:01 Refactoring #1570 (Rejected): replace parameter accessor methods getFoo() by getParameterValue("F...
Simplifies the API at no cost in usability. Sole use of the form factor parameter read accessors seems to be in GUI/c... wuttke
14:50 Revision 1685753a: Merge branch 'parunit' into develop
pospelov
14:50 Revision 22395dd4: Merge branch 'hotfix-1.6.2' into develop. Fixed bug #1558
# Conflicts:
# Core/Instrument/DetectorMask.cpp
# Core/Samples/BAVersion.h
# Fit/Minimizer/MinimizerFactory.cpp
# Fit...
pospelov
14:01 Refactoring #1555 (Resolved): invert dependence of FitKernel on FitParameterLinked
Resolved in 77bb6a194. Sorry for not closing this earlier. wuttke
09:13 Refactoring #1555: invert dependence of FitKernel on FitParameterLinked
When I can start working on #1478 and #1466?
pospelov
13:53 Refactoring #1569 (Backlog): Core: FF: API: rename hard particle form factors
Indispensable because some names are in conflict with established geometric terminology. Question is how far we go. S... wuttke
13:25 Feature #1568 (Backlog): Core: FF: Implement TruncatedEllipsoid to replace HemiEllipsoid
HemiEllipsoid describes an elongated droplet in contact with a surface. Are there any physical applications? If yes, ... wuttke
10:56 Refactoring #1567 (Rejected): Core: FF: API: omit »FormFactor« from particle geometry class names
Rename
* FormFactorCone -> Cone
* FormFactorTruncatedSpheroid -> TruncatedSpheroid
* and so on for all hard partic...
wuttke
10:36 Feature #1554 (Rfc): provide script to update Python files upon name changes in BornAgain
wuttke
10:34 Refactoring #1440: cover Python examples by functional tests
required for #1566 (the big renaming) wuttke
10:19 Refactoring #1497 (Rejected): Agree on new Core directory structure and class renaming to Rename ...
Perhaps it is cleaner to reject this issue, and to open a new issue specifically about the class&method renaming, usi... wuttke
10:12 Refactoring #1497: Agree on new Core directory structure and class renaming to Rename certain cla...
"directory structure" taken out of the title of this issue; if you want, reopen as a separate issue.
A good direct...
wuttke
10:04 Refactoring #1565: to associate units with parameters, use string instead of inheritance
at this occasion, correct the limits for angles form +-90 or +-180 to +-PID2 or +-PI wuttke
09:39 Refactoring #1565 (Archived): to associate units with parameters, use string instead of inheritance
While implementing units-in-parameters using the inheritance approach, I learned that units can be undefined when par... wuttke
10:01 Revision 336f773b: rename internal methods in export/label mechanism
wuttke
09:51 Feature #1563: Investigate time-of-life of SampleBuilder in Python context
This is definitely a remnant from the old bindings. In the old bindings, the ownership problem was solved on the C++ ... jmfisher
08:48 Feature #1563 (Archived): Investigate time-of-life of SampleBuilder in Python context

*Item I*
* Is it possible to provide inline usage of SampleBuilder, as in example of Dominique Dresen?...
pospelov
09:38 Bug #1559 (Rejected): Restore intensitydata.py functional test

You are right. I was able to do this in boost-python binding only because, as you've explained, he was silently pro...
pospelov
09:35 Bug #1559: Restore intensitydata.py functional test
Note that this is the expected behaviour in C++. getXaxis() returns a raw pointer to the axis, which is owned by the ... jmfisher
09:13 Revision 9ad1670e: Locally use "using namespace PythonFormatting" for conciseness
wuttke
09:07 Revision 9620888e: one "define" method is used in GUI
wuttke
09:00 Revision e16af94e: Privatize methods; class comment; regenerate bindings
wuttke
08:48 Revision 6ac45c7d: updated '@file'
wuttke
08:46 Revision e0266033: corrections for a few commits ago: missing "BornAgain::"
wuttke
08:40 Feature #1562: Provide ISample with possibility to export parameter tree in Python dictionary
this sounds very close to what I am working on right now wuttke
08:26 Feature #1562 (Resolved): Provide ISample with possibility to export parameter tree in Python dic...

Request from Dominique Dresen:
> Print / Retrieve All Possible Fitting Parameters, including Beam Properties.
...
pospelov
08:38 Revision f65310b5: update include guards; regenerate bindings
wuttke
08:34 Revision 2865fcbb: more expressive names for PyGen*: ExportToPython, PythonFormatting
wuttke
08:22 Feature #1561 (Rejected): merge FTDistribution.. and FTDecayFunction..
or is there any good reason to maintain two different interfaces and implementations for a Gaussian, a Lorentzian, an... wuttke
08:21 Feature #1560 (Archived): Provide simulation running from Python with text version of progress bar

Request from Franziska Löhrer
> is it possible to track the progress (e.g. via the progress handler), when using...
pospelov

02 Aug 2016

23:50 Revision 9dbc2ff3: one more auto-export
wuttke
23:46 Revision 7db204fe: FTDecayfunction automatically exported to Python
wuttke
22:22 Revision 6607a0f7: register _all_ 4 or 5 parameters of the 2D FT-Distributions, and allow them as...
wuttke
21:03 Revision ed9a4abc: simplify export of IFTDecayFunction1D
wuttke
20:41 Revision a2aef303: split FTDistributions -> ..1D, ..2D
wuttke
20:00 Revision 482d87ae: correct missing "\n" in FormFactor export
wuttke
19:41 Revision 162cb4d5: revert automatic output for Beam (it's not a constructor here)
wuttke
19:32 Revision 6a451666: Merge branch 'parunit' into develop
wuttke
19:28 Revision 97ddfec6: unified short name for different local pointers, to bring forward code duplica...
wuttke
19:10 Revision ee0d6b11: Merge branch 'parunit' into develop
wuttke
19:10 Revision 53fa1513: minor simplification
wuttke
18:58 Revision 8ce81755: Beam and Roughness exported to Python with automatically generated argument li...
wuttke
18:36 Revision d57a1050: Merge branch 'parunit' into develop. Parameters now have a unit; FormFactor ar...
wuttke
18:30 Revision c9268b4c: Export of form factors to Python now uses automatically generated argument list.
wuttke
18:12 Revision 9736e630: Merge branch 'DisableNastyTest'
pospelov
18:11 Revision 3ba67de8: Disabling subtest to bypass failure on make check (the case is not used, but h...
pospelov
18:08 Bug #1559 (Rejected): Restore intensitydata.py functional test

After I have fixed Simulation::getIntensityData ownership within #1558, and the returned Histogram2D object started...
pospelov
18:05 Revision e5337f48: Merge branch 'fixwindowsbuild' into develop
herck
17:53 Bug #1558 (Resolved): Memory leakges in Python on Simulation::getIntensityData call
pospelov
10:05 Bug #1558 (Archived): Memory leakges in Python on Simulation::getIntensityData call

Thanks to Dominique Dresen
>I think I narrowed the source of this bug down to the getIntensityData() method of G...
pospelov
17:49 Revision 647fb041: Fixed some more compilation errors
herck
17:30 Revision e2194ee1: Merge branch 'hotfix-1.6.2' into develop. Fixed bug #1558
# Conflicts:
# Core/Instrument/DetectorMask.cpp
# Core/Samples/BAVersion.h
# Fit/Minimizer/MinimizerFactory.cpp
# Fit...
pospelov
17:12 Revision 81bc2bfd: Converted to new parameter registration API.
wuttke
17:12 Revision cbeff088: minor edits while reading
wuttke
17:12 Revision 980a9814: RealParameter is now pure virtual. Temporarily, all parameters are Scalar. In ...
wuttke
17:12 Revision a7f52ef6: pack Angle, Length, Scalar all in DimensionedParameters.h
wuttke
17:12 Revision 77bb6a19: Two methods removed from FitSuiteParameters, and directly implemented in FitKe...
This make Fit again independent of Core, and thereby resolves #1555. wuttke
17:08 Revision 9ff3ab49: Doxygen comments on Crystal, MesoCrystal, FormFactorCrystal.
wuttke
17:08 Revision d2090a0a: rm keyword "virtual" when there is the more expressive keyword "final"
wuttke
17:08 Revision 5c18b284: regenerated XML
wuttke
15:40 Revision 61c9ba10: Merge branch 'hotfix-1.6.2'
pospelov
15:39 Revision 34985014: Version number propagated to 1.6.2
pospelov
15:29 Revision 1fd38985: MinimizerTest is returned to MinimizerFactory
pospelov
15:23 Revision 0315a078: Added missing include
herck
15:05 Revision dd711b2d: DetectorMask exposed to Python
pospelov
14:14 Revision 4645b03a: Fixed transfer of ownership to python in FitSuite
pospelov
14:04 Revision 18e2fd50: Bugfix #1588 because of non-transfered ownership to Python.
pospelov
13:35 Revision d99fcfc5: Added missing includes
herck
11:39 Refactoring #1556: FormFactorInfo: remove unused m_pos_x, m_pos_y
m_pos_x and m_pos_y can indeed be removed. Inheriting from IFormFactor is conceptually not a good idea, since FormFac... herck
11:35 Revision 84edf1d5: BROKEN - while converting to new parameter registration API
wuttke
11:04 Revision 42f18c3f: pack Angle, Length, Scalar all in DimensionedParameters.h
wuttke
10:44 Revision 7cd3a4a1: RealParameter is now pure virtual. Temporarily, all parameters are Scalar. In ...
wuttke

01 Aug 2016

22:32 Revision e3db1aa9: minor edits while reading
wuttke
21:42 Refactoring #1557 (Rejected): FitParameterLinked causes weird coupling
FitParameterLinked inherits from FitParameter.
However, its member m_pool_parameters is of type vector<RealParameter...
wuttke
21:13 Revision 156e8e35: two methods removed from FitSuiteParameters, and directly implemented in FitKe...
This make Fit again independent of Core, and thereby resolves #1555. wuttke
20:20 Refactoring #1556 (Sprint): FormFactorInfo: remove unused m_pos_x, m_pos_y
wuttke
18:24 Refactoring #1556 (Archived): FormFactorInfo: remove unused m_pos_x, m_pos_y
Members m_pos_x, m_pos_y seem to be unused => delete them.
wuttke
18:07 Revision 4f8bd5fb: BROKEN: in middle of #1555
wuttke
18:04 Refactoring #1555 (Resolved): invert dependence of FitKernel on FitParameterLinked
Subclasses ParameterLength, ParameterAngle etc only make sense in Core/, not in Fit/.
Therefore we need to move Para...
wuttke
17:12 Revision d112ce7c: regenerated XML
wuttke
17:10 Refactoring #1432: final polish of polyhedral form factor
can wait wuttke
17:08 Revision 197226e8: rm keyword "virtual" when there is the more expressive keyword "final"
wuttke
15:57 Revision 2667c834: Doxygen comments on Crystal, MesoCrystal, FormFactorCrystal.
wuttke
15:34 Feature #1554 (Rejected): provide script to update Python files upon name changes in BornAgain
For users, and for converting our own examples and tests.
Compare #1553 which does the same for XML project files.
wuttke
15:31 Feature #1553 (Rejected): Project (XML) read-in: support old versions by automatic conversion of ...
Name changes should be made conditional on this. wuttke
15:26 Revision 9ee71eef: Merge branch 'parunit' into develop, resolving #1543 and #1546.
wuttke
14:59 Refactoring #1546 (Resolved): disambiguate getRadius()
Resolved in 4defcc9.
In passing: removed unnecessary 'virtual' attribute from 'clone' methods.
wuttke
11:57 Refactoring #1546: disambiguate getRadius()
Starting in branch parunit, as preparative step towards #1428. wuttke
10:45 Refactoring #1546 (Archived): disambiguate getRadius()
getRadius() currently has two different, though overlapping uses:
* to return the value of »Radius«, if the particle...
wuttke
14:57 Revision 4defcc99: Replaced getRadius by getRadialExtension, except where it means "get value of ...
wuttke
14:30 Bug #1552 (Resolved): FormFactorTrivial should have RadialExtension = 0
The physical meaning of FormFactorTrivial is: form factor of a dot.
Accordingly, getRadialExtension() should return ...
wuttke
13:52 Revision e6bb045d: Add include dir for forced include w32pragma.h
herck
13:43 Revision 730b7c0f: 11ify FFCrystal
wuttke
11:54 Documentation #1414: regenerate form factor images in manual
I'll come back to this when resuming work on the manual wuttke
11:54 Refactoring #1065: Revise particle form factors: change names, add few form factors, change some ...
Needs further preparation & discussion wuttke
11:53 Refactoring #1469: Package Multifit-Suite as separate library
I'll come back to this wuttke
11:33 Refactoring #1551 (Resolved): rename directory RootWrapper/ and files therein
The subsystem implemented in RootWrapper wraps not only the CERN Root minimizers, but also others. So »Root« and »ROO... wuttke
11:28 Refactoring #1550 (Archived): in .h file header comments, replace »Declares« by »Defines«
Since we discussed nomenclature many weeks ago, I paid attention to it and convinced myself that »declaration« - »def... wuttke
11:22 Refactoring #1549 (Rejected): rename class FitSuite
»FitSuite« is one possible name for the entire fit library (#1548).
It is not so good a name for the top-level cla...
wuttke
11:10 Refactoring #1548 (Rejected): choose name for fit library
Per #1469, we'll package our multi-minimizer wrapper as a separate library. How shall we call it?
* libfitagain
*...
wuttke
10:58 Refactoring #1547 (Rfc): restore ScanningMinimizer
wuttke
10:57 Refactoring #1547 (Resolved): restore ScanningMinimizer
ScanningMinimizer (previously MinimizerScan) is the only minimizer that directly accesses OutputData<>.
It is cove...
wuttke
10:34 Refactoring #1545 (Rejected): INamed: replace default "" by typeid()
In most or all of the ISample hierarchy, m_name is initially set to the class name. This can be easily achieved by a ... wuttke
10:25 Configuration #1544 (Rejected): require libcerf instead of providing ThirdParty/Fadeeva
»Eat your own dogfood«. We are hosting »libcerf«, so we should use it in our own projects. »libcerf-dev« has made it ... wuttke

28 Jul 2016

18:12 Revision e4508652: FitKernel no longer known by FitSuite; call back now accomplished by a std::fu...
wuttke
18:09 Feature #1543 (Resolved): decouple FitKernel from FitSuite
wuttke
18:08 Feature #1543: decouple FitKernel from FitSuite
Resolved in e450865. wuttke
15:59 Feature #1543 (Archived): decouple FitKernel from FitSuite
using std::function callback in FitKernel::notifyObservers() wuttke
16:53 Revision 65cbbd45: Merge branch 'testing' into develop: reduce dependence of Core on Fit by movin...
wuttke
16:00 Revision 9573d6a0: Merge branch 'parunit' into testing: beautify this and that in Fit/, move EXce...
wuttke
15:56 Revision b8bbacb9: 11ify another .cpp file
wuttke
15:23 Revision 8872cd2f: 11ify
wuttke
14:53 Revision d088b7f7: cleanup
wuttke
14:40 Revision dbe48d27: move Exceptions back to Core/
wuttke
14:38 Revision fe67cf34: copy editing
wuttke
13:31 Refactoring #1542 (Resolved): Make ParameterPool and RealParameter independent of IParameterized
Resolved in 1c23198. Went smoothly, using std::function and std::bind. wuttke
10:37 Refactoring #1542 (Archived): Make ParameterPool and RealParameter independent of IParameterized
Currently, they have a member IParameterized* m_parent that is only used to call IParameterized::onChange().
If we...
wuttke
13:29 Revision 1c23198e: Merge branch 'testing' into develop: ParameterPool is now independent of IPara...
wuttke
13:19 Revision 09191f9e: Utils divided in Fit/Utils/StringUtils and Core/Tools/Utils.
wuttke
12:39 Revision 8962e9e8: Moved INamed from Fit/ to Core/.
wuttke
12:32 Revision 559353b4: moved IParameterized back to Core/, prepared move of INamed.
wuttke
11:40 Revision f711564f: ParameterPool no longer knows IParameterized; call back now done using std::fu...
wuttke
11:08 Revision d31d4498: Prepare for resolution of #1542: no more direct coupling between RealParameter...
wuttke
10:39 Revision 6d79a15c: Merge branch 'testing' into develop: Pointerify ParameterPool; place Fit/ _bel...
wuttke
10:37 Revision 67a8081b: TODO notice; regenerated bindings
wuttke
10:33 Refactoring #1469: Package Multifit-Suite as separate library
priority set to high because rapid return to stability in directory structures is desired wuttke
10:25 Refactoring #1541: review areAlmostEqual and get_relative_difference
With 7c816ab there comes a rudimentary unit test TestRelDiff, to be expanded while this issue is being solved. wuttke
10:18 Refactoring #1541 (Rejected): review areAlmostEqual and get_relative_difference
Is there need for a tolerance_factor? Probably not.
Are small numbers meant on a linear or a logarithmic scale? Is...
wuttke
10:09 Revision 7c816abc: start unit test RelDiffTest; outcome for small arguments needs closer attention
wuttke

27 Jul 2016

21:38 Revision d9c90189: include -> forward class declaration
wuttke
20:54 Revision d7c3c54e: ICloneable moved back to Core/ (otherwise severe problem with SWIG)
wuttke
20:48 Revision e1a1772b: copy editing, code line length in Core/ passed
wuttke
20:15 Refactoring #1469: Package Multifit-Suite as separate library
rewrote title and description wuttke
18:54 Refactoring #1469 (Sprint): Package Multifit-Suite as separate library
good progress in 008f21a;
base classes and utilities moved to Fit/ require second thought
wuttke
19:24 Revision d628134d: moved import-module from libBornAgainFit.i to ..Core.i; now all tests but two ...
wuttke
18:57 Revision 008f21a0: Started serious work on #1469, separate FitAgain from BornAgain.
Top-level routines moved from Fit/Suite to Core/Fitting.
Some base classes and utilities moved from Core to Fit/Utils...
wuttke
17:51 Feature #1540 (Long Term Idea): Core: support incoherent z-distribution of particles inside layer
This can be done very efficiently using the same type of attenuation factor as used in:
doi: 10.1107/S00218898060437...
herck
16:30 Revision ae745cc8: rm a few more includes
wuttke
15:38 Refactoring #1538 (Rejected): AttLimits::isInRange(value) returns true for value==m_lower_limit, ...
Current implementation is... wuttke
15:01 Revision 94ee6217: renamed RealParameterWrapper -> RealParameter (in my understanding,
a parameter is more than its value. A parameter has at least a name, a
physical dimension, and a value. So, our class...
wuttke
13:02 Revision e65af0c3: 11ify: private -> delete; include -> forward class declaratin
wuttke
12:58 Revision ec3e2e2a: FitParameterLinked now also using vector<..Wrapper*>
wuttke
12:46 Revision 12cc1833: nontrivial implementation moved from .cpp to .h
wuttke
12:43 Revision 609680d1: include -> forward class declaration
wuttke
12:40 Revision e095c9fe: Converted ParameterPool::m_params from vector<RealParameterWrapper> to vector<...
wuttke
10:11 Revision 922eaa3a: ParameterPool::getParameter and IParameterized::getParameter now return a poin...
wuttke
08:14 Revision 3a9c7328: renamed FitSuiteParameters::getParameter -> getFitParameter, to distinguish fr...
wuttke
08:01 Revision 8e921a1a: Raise runtime error ("BUG") if IParameterized::IParameterized(const IParameter...
Just to prevent future abuses. wuttke

26 Jul 2016

19:59 Revision 5b4aedb4: renamed MinimizerTest -> TrivialMinimizer (it's not a minimizer test, but a te...
renamed MinimizerScan -> ScanningMinimizer (it does not scan minimizers, but minimizes by scanning) wuttke
19:40 Refactoring #1469: Package Multifit-Suite as separate library
Halted after bbac161 (minor cleanup, and split of Fit/ into four directories with clear include hierarchy)
wuttke
09:19 Refactoring #1469: Package Multifit-Suite as separate library
started with some easy refactoring wuttke
19:36 Feature #1513 (Resolved): Provide more informational throw message from RealParameterWrapper.
... followed and concluded by simplification of ParameterPool in 9c8e6d. wuttke
18:19 Feature #1513: Provide more informational throw message from RealParameterWrapper.
Resolved in 32e8204d0d4: RealParameterWrapper now has parameter m_name. wuttke
07:43 Feature #1513 (Sprint): Provide more informational throw message from RealParameterWrapper.
wuttke
19:34 Revision 9c8e6d23: Merge branch 'testing' into develop: Parameters now have names, resolving #1513.
wuttke
19:27 Revision f1c54e6f: Since RealParameterWrapper now knows its name, ParameterPool needs no longer t...
wuttke
18:12 Revision 32e8204d: RealParameterWrapper know has a m_name, which is used for more informative err...
This resolves #1513. wuttke
16:27 Revision bbac161a: Fit/ now hierarchichally structured in four directories
wuttke
16:18 Revision 0c56f16b: experimental directory split in Fit/.
wuttke
16:17 Revision c5c9d026: restore IParameterized::printParameters (has good use in Python examples)
wuttke
15:40 Revision 63dc612a: Fit/ has now four subdirectories with clear hierarchy: Suite -> Minimizer <-> ...
wuttke
14:34 Revision 968440ba: Merge branch 'testing' into develop: simplifications and code copy editing aro...
wuttke
14:33 Revision 0e707ee1: experimental directory split in Fit/.
wuttke
14:33 Feature #1537 (Rejected): parametrize Gaussians and Lorentzians by mean and fwhm
Whenever possible, different models should use common parameters.
For instance, different distribution functions mig...
wuttke
12:18 Revision cd73a287: more of the same
wuttke
11:51 Revision 62099f25: some standard cleanup in FitKernel and Binning/IAxis
wuttke
11:33 Revision 871a09de: Exceptions.h no longer included via IAxis.h
wuttke
11:11 Revision fe19d5dc: Exceptions.h no longer included via BasicVector3D or ThreadInfo
wuttke
10:49 Revision 8bcd0b8d: Exceptions.h no longer included via ICloneable.h
wuttke
10:34 Revision 467ce12b: implementation -> ISimulation.cpp
wuttke
09:53 Revision 0fa5b842: prefer '= delete' over runtime exception
wuttke
09:49 Revision b808d8c7: restore dev-tools/edit/update-filename.py, and prevent automatic edits in some...
wuttke
09:40 Revision fe7f96bb: but don't rename WarningMessageService : IMessageService
wuttke
09:30 Revision 17a10be1: updated '@file'
wuttke
09:28 Revision ff088748: renamed MessageService -> Logger. Old name evoked wrong ideas like inter-proce...
wuttke
09:21 Revision 6683f098: no need for "AlgorithmType" in each variable name, as all these variables sit ...
wuttke
09:17 Revision 4448bf93: new file Fit/FitKernel/AlgorithmNames.h so that Fit no longer depends on Core/...
wuttke
08:07 Refactoring #1419 (Resolved): move test code out of core
qGenerator.h has been removed since long.
TestMachinery/ has been moved to Test/Functional/ a few days ago.
Sta...
wuttke
08:03 Feature #587: Fit: investigate objective function alternatives
the field is called "Priority", not "Importance" wuttke
07:57 Feature #587 (Long Term Idea): Fit: investigate objective function alternatives
wuttke
08:03 Feature #586: Investigate chi2-like objective functions
the field is called "Priority", not "Importance" wuttke
08:02 Configuration #1536 (Resolved): prevent Drupal from sending HTML mails with black horizontal head...
this was supposed to be solved in Sprint 31, but I continue to get such mails wuttke
07:52 Refactoring #1535 (Rejected): rm intermediate directory 'coregui'
Currently, GUI/ contains only a few small directories, plus coregui/, which in turn contains the more important direc... wuttke
07:42 Refactoring #1428 (Sprint): Compactify code that handles parameters (use abstract mechanism inste...
I started with simplifying the interface IParameterized (branch 'parunit') ... wuttke

25 Jul 2016

00:18 Revision fb3c33fc: simplify
wuttke
00:04 Revision 2f09a14a: no need for unique ptr that is released two lines later
wuttke
00:00 Revision ce93ad48: relegate clearParameterPool to ParameterPool::clear
wuttke
23:10 Revision 88becabd: rm unnessary clearParameterPool()
wuttke
22:56 Revision d5eb9029: rm unnecessary #include; rm unnecessary clearParameters from FF's
wuttke
22:32 Revision 95b47b75: no need for IParameterized::printParameters()
wuttke
21:56 Revision 3b220f64: Basics mainly contains base classes; Tools contains utilities that are definit...
wuttke
21:29 Revision ee406a08: move a few files out of Tools/
wuttke
21:25 Revision d8f78b5e: ParameterPool.h no longer included through IParameterized.h
wuttke
20:59 Revision 3fc1daf3: IParameterized::m_parameters is now a pointer to ParameterPool.
wuttke
20:52 Revision 8fa2f8fa: mv non-trivial implementation from .h to .cpp
wuttke
20:46 Revision f01e8a9c: rm "TODO"
wuttke
20:34 Revision b6f5e650: remove unused constructor, delete unused (and potentially confusing) operator=
wuttke
20:11 Revision ffb5ee17: avoid repetition
wuttke
20:05 Revision 5fb2e76b: moved class ParameterPattern into separate source files
wuttke
19:29 Feature #1534 (Rejected): === Parameter handling ===
Parameter handling needs a separate envelope tasks, because it cannot be subsumed under Core, Fit, or GUI: it concern... wuttke
18:53 Revision d22812f6: + function comment
wuttke
18:43 Refactoring #1527 (Resolved): simplify containsMagneticMaterial, printSampleTree, genPyScript
Resolved in 9e708f4af; ISampleVisitor no longer needed in Core. wuttke
18:41 Revision 9e708f4a: Merge branch 'sampletree' into develop: This resolves #1527, simplify contains...
wuttke
18:29 Revision 6b790150: PyGenVisitor is no longer a visitor
wuttke
18:23 Revision 6f00b47c: all labels are now set through template function ISample::containedSubclass<>(...
wuttke
18:15 Revision 09a65604: simplified handling of Roughness and FormFactors
wuttke
17:43 Revision 70b1a624: new templated function ISample::containedSubclass(), not yet used
wuttke
17:13 Revision d377f134: corr
wuttke
17:01 Refactoring #1514 (Resolved): Remove code duplication in Distributions.h and .cpp
herck
17:00 Revision 31ce3980: in typedef materials_t: LabelMap<const IMaterial*> -> typedef std::map<const I...
wuttke
16:43 Revision a0bfda8c: plainly use operator== to identify two IMaterial's as equal.
wuttke
16:31 Revision f5d53830: ISample::containedMaterials() back to not-unique
wuttke
16:07 Revision 584a38f5: the same for setLabel...
wuttke
15:57 Revision d52cb25d: distinguish functions by names, not just by arguments
wuttke
15:30 Revision 8584e182: ISample::containsMagneticMaterial() now without use ISample::containedMaterial...
wuttke
15:07 Revision 8ca5d55f: compactify
wuttke
14:15 Revision 74192d35: pEqual(const IMaterial*, const IMaterial*) in IMaterial.cpp now fully replaces...
wuttke
14:09 Revision 57aba62a: insertMaterials moved from visit() to top-level; for the moment, called on all...
wuttke
13:33 Revision 8c9f0518: ISample::containedMaterials() returns now a list of unique materials.
No harm for previous usein ISample::containsMagneticMaterial(),
and prepares for use in Python code dump.
wuttke
12:40 Revision 69dd49be: merge a few lines into PyGenVisitor()
wuttke
10:47 Revision 0c052b0e: while -> for in Export
wuttke
 

Also available in: Atom